When using a `StringBuilder` or `StringBuffer` to create a string message,
using implicit string concatenation inside an `.append()` call will
create a nested StringBuilder for the purposes of creating the arguments,
which will subsequently be converted to a String and then passed to
the outer StringBuilder.
Skip the creation of the intermediate object and String by simply
replacing such calls with `buffer.append(a).append(b)`.
Where values are compile time String constants, leave as is so
that the javac compiler can perform compile-time String concatenation.
Ensure that NEWLINE isn't appended in such a way since it is not
a compile time constant `System.getProperty("line.separator")`
Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
There are many opportunities for replacing `StringBuffer` with
`StringBuilder` provided that the type isn't visible from the
public API and is used only in internal methods. Replace these
where appropriate.
Change-Id: Ic2f50c5b6f3c3a4eae301bb3b40fb6faed235f79
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Using `new Integer` and other wrapper types such as `new Character` results in
potential extra heap utilisation as the values are not cached. The built-in
`Integer.valueOf` will perform caching on numbers in the range -128..127 (at
least) using a flyweight pattern. In addition, parsing `int` values can be done
with `Integer.parseInt` which avoids object construction.
Adjust tests such as `"true".equals(expr)` to `Boolean.parseBoolean(expr)`.
Change-Id: I0408a5c69afc4ca6ede71acaf6cc4abd67538006
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
When using DSF-GDB, the handleSuspend event is received only when a
breakpoint is hit (i.e. not when it's actually suspended),
However memory changed events are received when applicable during
stepping, however the base code does not call the "archiveDeltas()" for
this event.
This change adds a call to archiveDeltas if the update mode is set to
UPDATE_ALWAYS upon reception of memory change events.
TO REPRODUCE this problem:
The issue is that only one snap shot of history is applied with the first
address / expression search, and this is used for all other comparissions,
So you can search for a variable with bigger address value as a first
memory search, and then step the code and see that variables close by
with smaller address values will be updated but not colored.
e.g.
&Test -> address 0x110
&X -> address 0x100
if &Test is used as the first memory search, and then the code changes
value of &X while stepping the code, the cell holding &X will not be
colored as expected.
Change-Id: Ibdc1fae6ed73ec2819fe9539d56f9ea9b6302535
spaces with 64-bit address
- Fix scroll adjustments according to current viewport addresses
- Add CTRL-Home/CTRL-END to go to start/end of memory space
- Add Home/END to go to start/end of the row
- Add eclipse debug tracing support
Change-Id: Ifba9f1e6c67e1cc6ccb8f6f8787a55520d8bf9be
Signed-off-by: Teodor Madan <teodor.madan@freescale.com>
This would make Tycho 0.23.0 fail. See bug 464649.
Change-Id: I4e4ce6fc2714b5179eeb7fdd16c9461517d67a47
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
getAdaptable() in 4.5 M6 has changed to use generics, making casting its
result no longer necessary.
Change-Id: Idd943216a925576bb72c784b2c5a2a4b8e8b00d2
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
features
Change-Id: I52a71e62f8161990657e96ef52403fd7f69698a2
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27499
This means that:
- feature.xml files now make a reference to the shared license plugin
using version 0.0.0
- feature.properties files no longer have the text for the license
- license.html and epl-v10.html files are removed as they are part
of the shared license plugin
- build.properties files no longer reference removed files
- the main pom.xml file references the license repository
Change-Id: Ibd880480de3a07597084d44cce7b822903509079
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27250
Change-Id: I0e72b6a4d685197191427c93b67b9a96d80da682
Signed-off-by: Ling Wang <ling.wang@silabs.com>
Reviewed-on: https://git.eclipse.org/r/15214
Reviewed-by: Marc Khouzam <marc.khouzam@ericsson.com>
IP-Clean: Marc Khouzam <marc.khouzam@ericsson.com>
Tested-by: Marc Khouzam <marc.khouzam@ericsson.com>
Bug 398332 : The validation logic and feedback for all of the Importers/Exporters is very bad
Added more error checking. See comments in the bugzillas for the details.
Bug 398332 : The validation logic and feedback for all of the Importers/Exporters is very bad
I found some more editing edge cases as well as an NPE on starting a
new connection with the Browser up, which was the result of a previous
edit.
