2007-09-24 00:51:40 +02:00
|
|
|
#!/bin/sh
|
|
|
|
#
|
|
|
|
# Copyright (c) 2007 Lars Hjemli
|
|
|
|
#
|
|
|
|
|
2008-09-03 10:59:33 +02:00
|
|
|
test_description='git merge
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2010-08-17 08:53:56 +02:00
|
|
|
Testing basic merge operations/option parsing.
|
|
|
|
|
|
|
|
! [c0] commit 0
|
|
|
|
! [c1] commit 1
|
|
|
|
! [c2] commit 2
|
|
|
|
! [c3] commit 3
|
|
|
|
! [c4] c4
|
|
|
|
! [c5] c5
|
|
|
|
! [c6] c6
|
|
|
|
* [master] Merge commit 'c1'
|
|
|
|
--------
|
|
|
|
- [master] Merge commit 'c1'
|
|
|
|
+ * [c1] commit 1
|
|
|
|
+ [c6] c6
|
|
|
|
+ [c5] c5
|
|
|
|
++ [c4] c4
|
|
|
|
++++ [c3] commit 3
|
|
|
|
+ [c2] commit 2
|
|
|
|
+++++++* [c0] commit 0
|
|
|
|
'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
|
|
|
. ./test-lib.sh
|
merge: do not create a signed tag merge under --ff-only option
Starting at release v1.7.9, if you ask to merge a signed tag, "git merge"
always creates a merge commit, even when the tag points at a commit that
happens to be a descendant of your current commit.
Unfortunately, this interacts rather badly for people who use --ff-only to
make sure that their branch is free of local developments. It used to be
possible to say:
$ git checkout -b frotz v1.7.9~30
$ git merge --ff-only v1.7.9
and expect that the resulting tip of frotz branch matches v1.7.9^0 (aka
the commit tagged as v1.7.9), but this fails with the updated Git with:
fatal: Not possible to fast-forward, aborting.
because a merge that merges v1.7.9 tag to v1.7.9~30 cannot be created by
fast forwarding.
We could teach users that now they have to do
$ git merge --ff-only v1.7.9^0
but it is far more pleasant for users if we DWIMmed this ourselves.
When an integrator pulls in a topic from a lieutenant via a signed tag,
even when the work done by the lieutenant happens to fast-forward, the
integrator wants to have a merge record, so the integrator will not be
asking for --ff-only when running "git pull" in such a case. Therefore,
this change should not regress the support for the use case v1.7.9 wanted
to add.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-02-06 01:22:12 +01:00
|
|
|
. "$TEST_DIRECTORY"/lib-gpg.sh
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
printf '%s\n' 1 2 3 4 5 6 7 8 9 >file
|
|
|
|
printf '%s\n' '1 X' 2 3 4 5 6 7 8 9 >file.1
|
|
|
|
printf '%s\n' 1 2 3 4 '5 X' 6 7 8 9 >file.5
|
|
|
|
printf '%s\n' 1 2 3 4 5 6 7 8 '9 X' >file.9
|
|
|
|
printf '%s\n' '1 X' 2 3 4 5 6 7 8 9 >result.1
|
|
|
|
printf '%s\n' '1 X' 2 3 4 '5 X' 6 7 8 9 >result.1-5
|
|
|
|
printf '%s\n' '1 X' 2 3 4 '5 X' 6 7 8 '9 X' >result.1-5-9
|
2011-05-17 01:46:23 +02:00
|
|
|
>empty
|
2010-08-17 08:53:56 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
create_merge_msgs () {
|
2011-11-05 05:31:28 +01:00
|
|
|
echo "Merge tag 'c2'" >msg.1-5 &&
|
|
|
|
echo "Merge tags 'c2' and 'c3'" >msg.1-5-9 &&
|
2011-05-06 22:58:52 +02:00
|
|
|
{
|
|
|
|
echo "Squashed commit of the following:" &&
|
|
|
|
echo &&
|
|
|
|
git log --no-merges ^HEAD c1
|
|
|
|
} >squash.1 &&
|
|
|
|
{
|
|
|
|
echo "Squashed commit of the following:" &&
|
|
|
|
echo &&
|
|
|
|
git log --no-merges ^HEAD c2
|
|
|
|
} >squash.1-5 &&
|
|
|
|
{
|
|
|
|
echo "Squashed commit of the following:" &&
|
|
|
|
echo &&
|
|
|
|
git log --no-merges ^HEAD c2 c3
|
|
|
|
} >squash.1-5-9 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
: >msg.nologff &&
|
2014-05-15 00:12:45 +02:00
|
|
|
: >msg.nolognoff &&
|
2011-05-06 22:58:52 +02:00
|
|
|
{
|
2011-11-05 05:31:28 +01:00
|
|
|
echo "* tag 'c3':" &&
|
2014-05-15 00:12:45 +02:00
|
|
|
echo " commit 3"
|
2011-05-06 22:58:52 +02:00
|
|
|
} >msg.log
|
|
|
|
}
|
2010-08-17 08:53:56 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
verify_merge () {
|
|
|
|
test_cmp "$2" "$1" &&
|
|
|
|
git update-index --refresh &&
|
|
|
|
git diff --exit-code &&
|
|
|
|
if test -n "$3"
|
|
|
|
then
|
2014-05-15 00:12:45 +02:00
|
|
|
git show -s --pretty=tformat:%s HEAD >msg.act &&
|
2011-05-06 22:58:52 +02:00
|
|
|
test_cmp "$3" msg.act
|
|
|
|
fi
|
|
|
|
}
|
2010-08-17 08:53:56 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
verify_head () {
|
|
|
|
echo "$1" >head.expected &&
|
|
|
|
git rev-parse HEAD >head.actual &&
|
|
|
|
test_cmp head.expected head.actual
|
|
|
|
}
|
2010-08-17 08:53:56 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
verify_parents () {
|
|
|
|
printf '%s\n' "$@" >parents.expected &&
|
|
|
|
>parents.actual &&
|
|
|
|
i=1 &&
|
|
|
|
while test $i -le $#
|
|
|
|
do
|
|
|
|
git rev-parse HEAD^$i >>parents.actual &&
|
|
|
|
i=$(expr $i + 1) ||
|
|
|
|
return 1
|
|
|
|
done &&
|
2011-05-06 23:00:21 +02:00
|
|
|
test_must_fail git rev-parse --verify "HEAD^$i" &&
|
2011-05-06 22:58:52 +02:00
|
|
|
test_cmp parents.expected parents.actual
|
|
|
|
}
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
verify_mergeheads () {
|
|
|
|
printf '%s\n' "$@" >mergehead.expected &&
|
2011-11-07 23:45:10 +01:00
|
|
|
while read sha1 rest
|
|
|
|
do
|
|
|
|
git rev-parse $sha1
|
|
|
|
done <.git/MERGE_HEAD >mergehead.actual &&
|
|
|
|
test_cmp mergehead.expected mergehead.actual
|
2011-05-06 22:58:52 +02:00
|
|
|
}
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2011-05-06 22:58:52 +02:00
|
|
|
verify_no_mergehead () {
|
|
|
|
! test -e .git/MERGE_HEAD
|
|
|
|
}
|
2007-09-24 00:51:40 +02:00
|
|
|
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
git add file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "commit 0" &&
|
|
|
|
git tag c0 &&
|
|
|
|
c0=$(git rev-parse HEAD) &&
|
|
|
|
cp file.1 file &&
|
|
|
|
git add file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "commit 1" &&
|
|
|
|
git tag c1 &&
|
|
|
|
c1=$(git rev-parse HEAD) &&
|
|
|
|
git reset --hard "$c0" &&
|
|
|
|
cp file.5 file &&
|
|
|
|
git add file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "commit 2" &&
|
|
|
|
git tag c2 &&
|
|
|
|
c2=$(git rev-parse HEAD) &&
|
|
|
|
git reset --hard "$c0" &&
|
|
|
|
cp file.9 file &&
|
|
|
|
git add file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "commit 3" &&
|
|
|
|
git tag c3 &&
|
|
|
|
c3=$(git rev-parse HEAD)
|
|
|
|
git reset --hard "$c0" &&
|
|
|
|
create_merge_msgs
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2008-07-20 14:34:47 +02:00
|
|
|
test_expect_success 'test option parsing' '
|
2008-07-16 10:33:52 +02:00
|
|
|
test_must_fail git merge -$ c1 &&
|
|
|
|
test_must_fail git merge --no-such c1 &&
|
|
|
|
test_must_fail git merge -s foobar c1 &&
|
|
|
|
test_must_fail git merge -s=foobar c1 &&
|
|
|
|
test_must_fail git merge -m &&
|
|
|
|
test_must_fail git merge
|
2007-09-24 00:51:40 +02:00
|
|
|
'
|
|
|
|
|
2010-10-22 08:49:45 +02:00
|
|
|
test_expect_success 'merge -h with invalid index' '
|
|
|
|
mkdir broken &&
|
|
|
|
(
|
|
|
|
cd broken &&
|
|
|
|
git init &&
|
|
|
|
>.git/index &&
|
|
|
|
test_expect_code 129 git merge -h 2>usage
|
|
|
|
) &&
|
2012-08-27 07:36:55 +02:00
|
|
|
test_i18ngrep "[Uu]sage: git merge" broken/usage
|
2010-10-22 08:49:45 +02:00
|
|
|
'
|
|
|
|
|
2008-07-30 01:17:01 +02:00
|
|
|
test_expect_success 'reject non-strategy with a git-merge-foo name' '
|
|
|
|
test_must_fail git merge -s index c1
|
|
|
|
'
|
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
test_expect_success 'merge c0 with c1' '
|
2010-08-17 08:56:13 +02:00
|
|
|
echo "OBJID HEAD@{0}: merge c1: Fast-forward" >reflog.expected &&
|
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge c1 &&
|
|
|
|
verify_merge file result.1 &&
|
2010-08-17 08:56:13 +02:00
|
|
|
verify_head "$c1" &&
|
|
|
|
|
|
|
|
git reflog -1 >reflog.actual &&
|
|
|
|
sed "s/$_x05[0-9a-f]*/OBJID/g" reflog.actual >reflog.fuzzy &&
|
|
|
|
test_cmp reflog.expected reflog.fuzzy
|
2007-09-24 00:51:40 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2009-10-29 23:08:31 +01:00
|
|
|
test_expect_success 'merge c0 with c1 with --ff-only' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge --ff-only c1 &&
|
|
|
|
git merge --ff-only HEAD c0 c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_head "$c1"
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2010-08-17 08:56:46 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge from unborn branch' '
|
|
|
|
git checkout -f master &&
|
|
|
|
test_might_fail git branch -D kid &&
|
|
|
|
|
|
|
|
echo "OBJID HEAD@{0}: initial pull" >reflog.expected &&
|
|
|
|
|
|
|
|
git checkout --orphan kid &&
|
|
|
|
test_when_finished "git checkout -f master" &&
|
|
|
|
git rm -fr . &&
|
|
|
|
test_tick &&
|
|
|
|
git merge --ff-only c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_head "$c1" &&
|
|
|
|
|
|
|
|
git reflog -1 >reflog.actual &&
|
|
|
|
sed "s/$_x05[0-9a-f][0-9a-f]/OBJID/g" reflog.actual >reflog.fuzzy &&
|
|
|
|
test_cmp reflog.expected reflog.fuzzy
|
|
|
|
'
|
|
|
|
|
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2009-10-29 23:08:31 +01:00
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
test_expect_success 'merge c1 with c2' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge c2 &&
|
|
|
|
verify_merge file result.1-5 msg.1-5 &&
|
|
|
|
verify_parents $c1 $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge c1 with c2 and c3' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge c2 c3 &&
|
|
|
|
verify_merge file result.1-5-9 msg.1-5-9 &&
|
|
|
|
verify_parents $c1 $c2 $c3
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2011-05-06 21:27:05 +02:00
|
|
|
test_expect_success 'merges with --ff-only' '
|
2009-10-29 23:08:31 +01:00
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
|
|
|
test_must_fail git merge --ff-only c2 &&
|
|
|
|
test_must_fail git merge --ff-only c3 &&
|
2011-05-06 21:27:05 +02:00
|
|
|
test_must_fail git merge --ff-only c2 c3 &&
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge c3 &&
|
|
|
|
verify_head $c3
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'merges with merge.ff=only' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config merge.ff "only" &&
|
2011-05-06 21:27:05 +02:00
|
|
|
test_must_fail git merge c2 &&
|
|
|
|
test_must_fail git merge c3 &&
|
|
|
|
test_must_fail git merge c2 c3 &&
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge c3 &&
|
|
|
|
verify_head $c3
|
2009-10-29 23:08:31 +01:00
|
|
|
'
|
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
test_expect_success 'merge c0 with c1 (no-commit)' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge --no-commit c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_head $c1
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge c1 with c2 (no-commit)' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge --no-commit c2 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_head $c1 &&
|
|
|
|
verify_mergeheads $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge c1 with c2 and c3 (no-commit)' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge --no-commit c2 c3 &&
|
|
|
|
verify_merge file result.1-5-9 &&
|
|
|
|
verify_head $c1 &&
|
|
|
|
verify_mergeheads $c2 $c3
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge c0 with c1 (squash)' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge --squash c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_head $c0 &&
|
|
|
|
verify_no_mergehead &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp squash.1 .git/SQUASH_MSG
|
2007-09-24 00:51:40 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2009-10-29 23:08:31 +01:00
|
|
|
test_expect_success 'merge c0 with c1 (squash, ff-only)' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge --squash --ff-only c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_head $c0 &&
|
|
|
|
verify_no_mergehead &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp squash.1 .git/SQUASH_MSG
|
2009-10-29 23:08:31 +01:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2009-10-29 23:08:31 +01:00
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
test_expect_success 'merge c1 with c2 (squash)' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge --squash c2 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_head $c1 &&
|
|
|
|
verify_no_mergehead &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp squash.1-5 .git/SQUASH_MSG
|
2007-09-24 00:51:40 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2013-06-19 07:37:24 +02:00
|
|
|
test_expect_success 'unsuccessful merge of c1 with c2 (squash, ff-only)' '
|
2009-10-29 23:08:31 +01:00
|
|
|
git reset --hard c1 &&
|
|
|
|
test_must_fail git merge --squash --ff-only c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2009-10-29 23:08:31 +01:00
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
test_expect_success 'merge c1 with c2 and c3 (squash)' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge --squash c2 c3 &&
|
|
|
|
verify_merge file result.1-5-9 &&
|
|
|
|
verify_head $c1 &&
|
|
|
|
verify_no_mergehead &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp squash.1-5-9 .git/SQUASH_MSG
|
2007-09-24 00:51:40 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:40 +02:00
|
|
|
|
2007-09-24 00:51:43 +02:00
|
|
|
test_expect_success 'merge c1 with c2 (no-commit in config)' '
|
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--no-commit" &&
|
2007-09-24 00:51:43 +02:00
|
|
|
git merge c2 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_head $c1 &&
|
|
|
|
verify_mergeheads $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:43 +02:00
|
|
|
|
2011-05-05 02:42:51 +02:00
|
|
|
test_expect_success 'merge c1 with c2 (log in config)' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge --log c2 &&
|
|
|
|
git show -s --pretty=tformat:%s%n%b >expect &&
|
|
|
|
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--log" &&
|
2011-05-05 02:42:51 +02:00
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge c2 &&
|
|
|
|
git show -s --pretty=tformat:%s%n%b >actual &&
|
|
|
|
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'merge c1 with c2 (log in config gets overridden)' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge c2 &&
|
|
|
|
git show -s --pretty=tformat:%s%n%b >expect &&
|
|
|
|
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--no-log" &&
|
|
|
|
test_config merge.log "true" &&
|
2011-05-05 02:42:51 +02:00
|
|
|
git reset --hard c1 &&
|
|
|
|
git merge c2 &&
|
|
|
|
git show -s --pretty=tformat:%s%n%b >actual &&
|
|
|
|
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2007-09-24 00:51:43 +02:00
|
|
|
test_expect_success 'merge c1 with c2 (squash in config)' '
|
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--squash" &&
|
2007-09-24 00:51:43 +02:00
|
|
|
git merge c2 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_head $c1 &&
|
|
|
|
verify_no_mergehead &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp squash.1-5 .git/SQUASH_MSG
|
2007-09-24 00:51:43 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:43 +02:00
|
|
|
|
2008-04-06 03:23:43 +02:00
|
|
|
test_expect_success 'override config option -n with --summary' '
|
2007-09-24 00:51:43 +02:00
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "-n" &&
|
2007-09-24 00:51:43 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge --summary c2 >diffstat.txt &&
|
|
|
|
verify_merge file result.1-5 msg.1-5 &&
|
|
|
|
verify_parents $c1 $c2 &&
|
2008-03-12 22:32:17 +01:00
|
|
|
if ! grep "^ file | *2 +-$" diffstat.txt
|
2007-09-24 00:51:43 +02:00
|
|
|
then
|
2008-04-06 03:23:43 +02:00
|
|
|
echo "[OOPS] diffstat was not generated with --summary"
|
|
|
|
false
|
|
|
|
fi
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'override config option -n with --stat' '
|
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "-n" &&
|
2008-04-06 03:23:43 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge --stat c2 >diffstat.txt &&
|
|
|
|
verify_merge file result.1-5 msg.1-5 &&
|
|
|
|
verify_parents $c1 $c2 &&
|
|
|
|
if ! grep "^ file | *2 +-$" diffstat.txt
|
|
|
|
then
|
|
|
|
echo "[OOPS] diffstat was not generated with --stat"
|
|
|
|
false
|
2007-09-24 00:51:43 +02:00
|
|
|
fi
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:43 +02:00
|
|
|
|
2008-04-06 03:23:43 +02:00
|
|
|
test_expect_success 'override config option --stat' '
|
2007-09-24 00:51:43 +02:00
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--stat" &&
|
2007-09-24 00:51:43 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge -n c2 >diffstat.txt &&
|
|
|
|
verify_merge file result.1-5 msg.1-5 &&
|
|
|
|
verify_parents $c1 $c2 &&
|
2008-03-12 22:32:17 +01:00
|
|
|
if grep "^ file | *2 +-$" diffstat.txt
|
2007-09-24 00:51:43 +02:00
|
|
|
then
|
|
|
|
echo "[OOPS] diffstat was generated"
|
|
|
|
false
|
|
|
|
fi
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:43 +02:00
|
|
|
|
2007-09-24 00:51:44 +02:00
|
|
|
test_expect_success 'merge c1 with c2 (override --no-commit)' '
|
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--no-commit" &&
|
2007-09-24 00:51:44 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge --commit c2 &&
|
|
|
|
verify_merge file result.1-5 msg.1-5 &&
|
|
|
|
verify_parents $c1 $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:44 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge c1 with c2 (override --squash)' '
|
|
|
|
git reset --hard c1 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--squash" &&
|
2007-09-24 00:51:44 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge --no-squash c2 &&
|
|
|
|
verify_merge file result.1-5 msg.1-5 &&
|
|
|
|
verify_parents $c1 $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:44 +02:00
|
|
|
|
2007-09-24 00:51:45 +02:00
|
|
|
test_expect_success 'merge c0 with c1 (no-ff)' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge --no-ff c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_parents $c0 $c1
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:45 +02:00
|
|
|
|
2011-05-06 21:27:05 +02:00
|
|
|
test_expect_success 'merge c0 with c1 (merge.ff=false)' '
|
|
|
|
git reset --hard c0 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config merge.ff "false" &&
|
2011-05-06 21:27:05 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_parents $c0 $c1
|
|
|
|
'
|
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
|
|
|
|
|
|
|
test_expect_success 'combine branch.master.mergeoptions with merge.ff' '
|
|
|
|
git reset --hard c0 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--ff" &&
|
|
|
|
test_config merge.ff "false" &&
|
2011-05-06 21:27:05 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_parents "$c0"
|
|
|
|
'
|
|
|
|
|
2011-05-06 23:59:47 +02:00
|
|
|
test_expect_success 'tolerate unknown values for merge.ff' '
|
|
|
|
git reset --hard c0 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config merge.ff "something-new" &&
|
2011-05-06 23:59:47 +02:00
|
|
|
test_tick &&
|
|
|
|
git merge c1 2>message &&
|
|
|
|
verify_head "$c1" &&
|
|
|
|
test_cmp empty message
|
|
|
|
'
|
|
|
|
|
git-merge.sh: better handling of combined --squash,--no-ff,--no-commit options
git-merge used to use either the --squash,--no-squash, --no-ff,--ff,
--no-commit,--commit option, whichever came last in the command line.
This lead to some un-intuitive behavior, having
git merge --no-commit --no-ff <branch>
actually commit the merge. Now git-merge respects --no-commit together
with --no-ff, as well as other combinations of the options. However,
this broke a selftest in t/t7600-merge.sh which expected to have --no-ff
completely override the --squash option, so that
git merge --squash --no-ff <branch>
fast-forwards, and makes a merge commit; combining --squash with --no-ff
doesn't really make sense though, and is now refused by git-merge. The
test is adapted to test --no-ff without the preceding --squash, and
another test is added to make sure the --squash --no-ff combination is
refused.
The unexpected behavior was reported by John Goerzen through
http://bing.sdebian.org/468568
Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-03-03 10:22:03 +01:00
|
|
|
test_expect_success 'combining --squash and --no-ff is refused' '
|
2011-05-06 23:59:47 +02:00
|
|
|
git reset --hard c0 &&
|
git-merge.sh: better handling of combined --squash,--no-ff,--no-commit options
git-merge used to use either the --squash,--no-squash, --no-ff,--ff,
--no-commit,--commit option, whichever came last in the command line.
This lead to some un-intuitive behavior, having
git merge --no-commit --no-ff <branch>
actually commit the merge. Now git-merge respects --no-commit together
with --no-ff, as well as other combinations of the options. However,
this broke a selftest in t/t7600-merge.sh which expected to have --no-ff
completely override the --squash option, so that
git merge --squash --no-ff <branch>
fast-forwards, and makes a merge commit; combining --squash with --no-ff
doesn't really make sense though, and is now refused by git-merge. The
test is adapted to test --no-ff without the preceding --squash, and
another test is added to make sure the --squash --no-ff combination is
refused.
The unexpected behavior was reported by John Goerzen through
http://bing.sdebian.org/468568
Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-03-03 10:22:03 +01:00
|
|
|
test_must_fail git merge --squash --no-ff c1 &&
|
|
|
|
test_must_fail git merge --no-ff --squash c1
|
|
|
|
'
|
|
|
|
|
2013-07-02 16:47:57 +02:00
|
|
|
test_expect_success 'option --ff-only overwrites --no-ff' '
|
|
|
|
git merge --no-ff --ff-only c1 &&
|
|
|
|
test_must_fail git merge --no-ff --ff-only c2
|
|
|
|
'
|
|
|
|
|
2013-07-23 19:08:40 +02:00
|
|
|
test_expect_success 'option --no-ff overrides merge.ff=only config' '
|
2013-07-02 16:47:57 +02:00
|
|
|
git reset --hard c0 &&
|
|
|
|
test_config merge.ff only &&
|
|
|
|
git merge --no-ff c1
|
2009-10-29 23:08:31 +01:00
|
|
|
'
|
|
|
|
|
2007-09-24 00:51:45 +02:00
|
|
|
test_expect_success 'merge c0 with c1 (ff overrides no-ff)' '
|
|
|
|
git reset --hard c0 &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config branch.master.mergeoptions "--no-ff" &&
|
2007-09-24 00:51:45 +02:00
|
|
|
git merge --ff c1 &&
|
|
|
|
verify_merge file result.1 &&
|
|
|
|
verify_head $c1
|
|
|
|
'
|
|
|
|
|
2008-04-06 03:23:46 +02:00
|
|
|
test_expect_success 'merge log message' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge --no-log c2 &&
|
|
|
|
git show -s --pretty=format:%b HEAD >msg.act &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_cmp msg.nologff msg.act &&
|
|
|
|
|
|
|
|
git reset --hard c0 &&
|
|
|
|
test_config branch.master.mergeoptions "--no-ff" &&
|
|
|
|
git merge --no-log c2 &&
|
|
|
|
git show -s --pretty=format:%b HEAD >msg.act &&
|
|
|
|
test_cmp msg.nolognoff msg.act &&
|
2008-07-10 09:50:59 +02:00
|
|
|
|
2008-04-06 03:23:46 +02:00
|
|
|
git merge --log c3 &&
|
|
|
|
git show -s --pretty=format:%b HEAD >msg.act &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp msg.log msg.act &&
|
2008-07-10 09:50:59 +02:00
|
|
|
|
|
|
|
git reset --hard HEAD^ &&
|
2013-03-24 22:06:12 +01:00
|
|
|
test_config merge.log "yes" &&
|
2008-07-10 09:50:59 +02:00
|
|
|
git merge c3 &&
|
|
|
|
git show -s --pretty=format:%b HEAD >msg.act &&
|
2010-08-17 08:53:56 +02:00
|
|
|
test_cmp msg.log msg.act
|
2008-04-06 03:23:46 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2007-09-24 00:51:45 +02:00
|
|
|
|
2008-07-13 10:13:55 +02:00
|
|
|
test_expect_success 'merge c1 with c0, c2, c0, and c1' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge c0 c2 c0 c1 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_parents $c1 $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2008-07-13 10:13:55 +02:00
|
|
|
|
2008-07-14 09:09:41 +02:00
|
|
|
test_expect_success 'merge c1 with c0, c2, c0, and c1' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge c0 c2 c0 c1 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_parents $c1 $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2008-07-14 09:09:41 +02:00
|
|
|
|
|
|
|
test_expect_success 'merge c1 with c1 and c2' '
|
|
|
|
git reset --hard c1 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge c1 c2 &&
|
|
|
|
verify_merge file result.1-5 &&
|
|
|
|
verify_parents $c1 $c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2008-07-14 09:09:41 +02:00
|
|
|
|
2008-08-21 00:09:28 +02:00
|
|
|
test_expect_success 'merge fast-forward in a dirty tree' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
mv file file1 &&
|
|
|
|
cat file1 >file &&
|
|
|
|
rm -f file1 &&
|
|
|
|
git merge c2
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2008-08-21 00:09:28 +02:00
|
|
|
|
2011-04-14 23:36:14 +02:00
|
|
|
test_expect_success 'in-index merge' '
|
merge: fix numerus bugs around "trivial merge" area
The "trivial merge" codepath wants to optimize itself by making an
internal call to the read-tree machinery, but it does not read the index
before doing so, and the codepath is never exercised. Incidentally, this
failure to read the index upfront means that the safety to refuse doing
anything when the index is unmerged does not kick in, either.
These two problem are fixed by using read_cache_unmerged() that does read
the index before checking if it is unmerged at the beginning of
cmd_merge().
The primary logic of the merge, however, assumes that the process never
reads the index in-core, and the call to write_cache_as_tree() it makes
from write_tree_trivial() will always read from the on-disk index that is
prepared the strategy back-ends. This assumption is now broken by the
above fix. To fix this issue, we now call discard_cache() before calling
write_tree_trivial() when it wants to write the on-disk index as a tree.
When multiple strategies are tried, their results are evaluated by reading
the resulting index and inspecting it. The codepath needs to make a call
to read_cache() for each successful strategy, and for that to work, they
need to discard_cache() the one read by the previous round.
Also the "trivial merge" forgot that the current commit is one of the
parents of the resulting commit.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-08-23 21:56:57 +02:00
|
|
|
git reset --hard c0 &&
|
2010-08-17 08:53:56 +02:00
|
|
|
git merge --no-ff -s resolve c1 >out &&
|
2011-04-14 23:36:14 +02:00
|
|
|
test_i18ngrep "Wonderful." out &&
|
merge: fix numerus bugs around "trivial merge" area
The "trivial merge" codepath wants to optimize itself by making an
internal call to the read-tree machinery, but it does not read the index
before doing so, and the codepath is never exercised. Incidentally, this
failure to read the index upfront means that the safety to refuse doing
anything when the index is unmerged does not kick in, either.
These two problem are fixed by using read_cache_unmerged() that does read
the index before checking if it is unmerged at the beginning of
cmd_merge().
The primary logic of the merge, however, assumes that the process never
reads the index in-core, and the call to write_cache_as_tree() it makes
from write_tree_trivial() will always read from the on-disk index that is
prepared the strategy back-ends. This assumption is now broken by the
above fix. To fix this issue, we now call discard_cache() before calling
write_tree_trivial() when it wants to write the on-disk index as a tree.
When multiple strategies are tried, their results are evaluated by reading
the resulting index and inspecting it. The codepath needs to make a call
to read_cache() for each successful strategy, and for that to work, they
need to discard_cache() the one read by the previous round.
Also the "trivial merge" forgot that the current commit is one of the
parents of the resulting commit.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-08-23 21:56:57 +02:00
|
|
|
verify_parents $c0 $c1
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
merge: fix numerus bugs around "trivial merge" area
The "trivial merge" codepath wants to optimize itself by making an
internal call to the read-tree machinery, but it does not read the index
before doing so, and the codepath is never exercised. Incidentally, this
failure to read the index upfront means that the safety to refuse doing
anything when the index is unmerged does not kick in, either.
These two problem are fixed by using read_cache_unmerged() that does read
the index before checking if it is unmerged at the beginning of
cmd_merge().
The primary logic of the merge, however, assumes that the process never
reads the index in-core, and the call to write_cache_as_tree() it makes
from write_tree_trivial() will always read from the on-disk index that is
prepared the strategy back-ends. This assumption is now broken by the
above fix. To fix this issue, we now call discard_cache() before calling
write_tree_trivial() when it wants to write the on-disk index as a tree.
When multiple strategies are tried, their results are evaluated by reading
the resulting index and inspecting it. The codepath needs to make a call
to read_cache() for each successful strategy, and for that to work, they
need to discard_cache() the one read by the previous round.
Also the "trivial merge" forgot that the current commit is one of the
parents of the resulting commit.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-08-23 21:56:57 +02:00
|
|
|
|
2008-10-03 15:02:31 +02:00
|
|
|
test_expect_success 'refresh the index before merging' '
|
|
|
|
git reset --hard c1 &&
|
2010-04-07 02:08:54 +02:00
|
|
|
cp file file.n && mv -f file.n file &&
|
2008-10-03 15:02:31 +02:00
|
|
|
git merge c3
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:52:48 +02:00
|
|
|
cat >expected.branch <<\EOF
|
|
|
|
Merge branch 'c5-branch' (early part)
|
|
|
|
EOF
|
|
|
|
cat >expected.tag <<\EOF
|
|
|
|
Merge commit 'c5~1'
|
2008-10-13 22:54:25 +02:00
|
|
|
EOF
|
|
|
|
|
|
|
|
test_expect_success 'merge early part of c2' '
|
|
|
|
git reset --hard c3 &&
|
2010-08-17 08:53:56 +02:00
|
|
|
echo c4 >c4.c &&
|
2008-10-13 22:54:25 +02:00
|
|
|
git add c4.c &&
|
|
|
|
git commit -m c4 &&
|
|
|
|
git tag c4 &&
|
2010-08-17 08:53:56 +02:00
|
|
|
echo c5 >c5.c &&
|
2008-10-13 22:54:25 +02:00
|
|
|
git add c5.c &&
|
|
|
|
git commit -m c5 &&
|
|
|
|
git tag c5 &&
|
|
|
|
git reset --hard c3 &&
|
2010-08-17 08:53:56 +02:00
|
|
|
echo c6 >c6.c &&
|
2008-10-13 22:54:25 +02:00
|
|
|
git add c6.c &&
|
|
|
|
git commit -m c6 &&
|
|
|
|
git tag c6 &&
|
2010-08-17 08:52:48 +02:00
|
|
|
git branch -f c5-branch c5 &&
|
|
|
|
git merge c5-branch~1 &&
|
2014-05-15 00:12:45 +02:00
|
|
|
git show -s --pretty=tformat:%s HEAD >actual.branch &&
|
2010-08-17 08:52:48 +02:00
|
|
|
git reset --keep HEAD^ &&
|
2008-10-13 22:54:25 +02:00
|
|
|
git merge c5~1 &&
|
2014-05-15 00:12:45 +02:00
|
|
|
git show -s --pretty=tformat:%s HEAD >actual.tag &&
|
2010-08-17 08:52:48 +02:00
|
|
|
test_cmp expected.branch actual.branch &&
|
|
|
|
test_cmp expected.tag actual.tag
|
2008-10-13 22:54:25 +02:00
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
2008-10-03 15:02:31 +02:00
|
|
|
|
builtin-commit: use reduce_heads() only when appropriate
Since commit 6bb6b034 (builtin-commit: use commit_tree(), 2008-09-10),
builtin-commit performs a reduce_heads() unconditionally. However,
it's not always needed, and in some cases even harmful.
reduce_heads() is not needed for the initial commit or for an
"ordinary" commit, because they don't have any or have only one
parent, respectively.
reduce_heads() must be avoided when 'git commit' is run after a 'git
merge --no-ff --no-commit', otherwise it will turn the
non-fast-forward merge into fast-forward. For the same reason,
reduce_heads() must be avoided when amending such a merge commit.
To resolve this issue, 'git merge' will write info about whether
fast-forward is allowed or not to $GIT_DIR/MERGE_MODE. Based on this
info, 'git commit' will only perform reduce_heads() when it's
committing a merge and fast-forward is enabled.
Also add test cases to ensure that non-fast-forward merges are
committed and amended properly.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
2008-10-03 14:04:47 +02:00
|
|
|
test_expect_success 'merge --no-ff --no-commit && commit' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git merge --no-ff --no-commit c1 &&
|
|
|
|
EDITOR=: git commit &&
|
|
|
|
verify_parents $c0 $c1
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
builtin-commit: use reduce_heads() only when appropriate
Since commit 6bb6b034 (builtin-commit: use commit_tree(), 2008-09-10),
builtin-commit performs a reduce_heads() unconditionally. However,
it's not always needed, and in some cases even harmful.
reduce_heads() is not needed for the initial commit or for an
"ordinary" commit, because they don't have any or have only one
parent, respectively.
reduce_heads() must be avoided when 'git commit' is run after a 'git
merge --no-ff --no-commit', otherwise it will turn the
non-fast-forward merge into fast-forward. For the same reason,
reduce_heads() must be avoided when amending such a merge commit.
To resolve this issue, 'git merge' will write info about whether
fast-forward is allowed or not to $GIT_DIR/MERGE_MODE. Based on this
info, 'git commit' will only perform reduce_heads() when it's
committing a merge and fast-forward is enabled.
Also add test cases to ensure that non-fast-forward merges are
committed and amended properly.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
2008-10-03 14:04:47 +02:00
|
|
|
|
|
|
|
test_expect_success 'amending no-ff merge commit' '
|
|
|
|
EDITOR=: git commit --amend &&
|
|
|
|
verify_parents $c0 $c1
|
|
|
|
'
|
|
|
|
|
2010-08-17 08:54:59 +02:00
|
|
|
test_debug 'git log --graph --decorate --oneline --all'
|
builtin-commit: use reduce_heads() only when appropriate
Since commit 6bb6b034 (builtin-commit: use commit_tree(), 2008-09-10),
builtin-commit performs a reduce_heads() unconditionally. However,
it's not always needed, and in some cases even harmful.
reduce_heads() is not needed for the initial commit or for an
"ordinary" commit, because they don't have any or have only one
parent, respectively.
reduce_heads() must be avoided when 'git commit' is run after a 'git
merge --no-ff --no-commit', otherwise it will turn the
non-fast-forward merge into fast-forward. For the same reason,
reduce_heads() must be avoided when amending such a merge commit.
To resolve this issue, 'git merge' will write info about whether
fast-forward is allowed or not to $GIT_DIR/MERGE_MODE. Based on this
info, 'git commit' will only perform reduce_heads() when it's
committing a merge and fast-forward is enabled.
Also add test cases to ensure that non-fast-forward merges are
committed and amended properly.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
2008-10-03 14:04:47 +02:00
|
|
|
|
2011-10-08 20:39:52 +02:00
|
|
|
cat >editor <<\EOF
|
|
|
|
#!/bin/sh
|
|
|
|
# Add a new message string that was not in the template
|
|
|
|
(
|
|
|
|
echo "Merge work done on the side branch c1"
|
|
|
|
echo
|
|
|
|
cat <"$1"
|
|
|
|
) >"$1.tmp" && mv "$1.tmp" "$1"
|
|
|
|
# strip comments and blank lines from end of message
|
|
|
|
sed -e '/^#/d' < "$1" | sed -e :a -e '/^\n*$/{$d;N;ba' -e '}' > expected
|
|
|
|
EOF
|
|
|
|
chmod 755 editor
|
|
|
|
|
|
|
|
test_expect_success 'merge --no-ff --edit' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
EDITOR=./editor git merge --no-ff --edit c1 &&
|
|
|
|
verify_parents $c0 $c1 &&
|
|
|
|
git cat-file commit HEAD >raw &&
|
|
|
|
grep "work done on the side branch" raw &&
|
|
|
|
sed "1,/^$/d" >actual raw &&
|
|
|
|
test_cmp actual expected
|
|
|
|
'
|
|
|
|
|
merge: do not create a signed tag merge under --ff-only option
Starting at release v1.7.9, if you ask to merge a signed tag, "git merge"
always creates a merge commit, even when the tag points at a commit that
happens to be a descendant of your current commit.
Unfortunately, this interacts rather badly for people who use --ff-only to
make sure that their branch is free of local developments. It used to be
possible to say:
$ git checkout -b frotz v1.7.9~30
$ git merge --ff-only v1.7.9
and expect that the resulting tip of frotz branch matches v1.7.9^0 (aka
the commit tagged as v1.7.9), but this fails with the updated Git with:
fatal: Not possible to fast-forward, aborting.
because a merge that merges v1.7.9 tag to v1.7.9~30 cannot be created by
fast forwarding.
We could teach users that now they have to do
$ git merge --ff-only v1.7.9^0
but it is far more pleasant for users if we DWIMmed this ourselves.
When an integrator pulls in a topic from a lieutenant via a signed tag,
even when the work done by the lieutenant happens to fast-forward, the
integrator wants to have a merge record, so the integrator will not be
asking for --ff-only when running "git pull" in such a case. Therefore,
this change should not regress the support for the use case v1.7.9 wanted
to add.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-02-06 01:22:12 +01:00
|
|
|
test_expect_success GPG 'merge --ff-only tag' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git commit --allow-empty -m "A newer commit" &&
|
|
|
|
git tag -s -m "A newer commit" signed &&
|
|
|
|
git reset --hard c0 &&
|
|
|
|
|
|
|
|
git merge --ff-only signed &&
|
|
|
|
git rev-parse signed^0 >expect &&
|
|
|
|
git rev-parse HEAD >actual &&
|
|
|
|
test_cmp actual expect
|
|
|
|
'
|
|
|
|
|
2012-02-09 22:30:52 +01:00
|
|
|
test_expect_success GPG 'merge --no-edit tag should skip editor' '
|
|
|
|
git reset --hard c0 &&
|
|
|
|
git commit --allow-empty -m "A newer commit" &&
|
|
|
|
git tag -f -s -m "A newer commit" signed &&
|
|
|
|
git reset --hard c0 &&
|
|
|
|
|
|
|
|
EDITOR=false git merge --no-edit signed &&
|
|
|
|
git rev-parse signed^0 >expect &&
|
|
|
|
git rev-parse HEAD^2 >actual &&
|
|
|
|
test_cmp actual expect
|
|
|
|
'
|
|
|
|
|
2007-09-24 00:51:40 +02:00
|
|
|
test_done
|