2005-04-08 00:16:10 +02:00
|
|
|
/*
|
|
|
|
|
* GIT - The information manager from hell
|
|
|
|
|
*
|
|
|
|
|
* Copyright (C) Linus Torvalds, 2005
|
|
|
|
|
*/
|
2005-04-08 00:13:13 +02:00
|
|
|
#include "cache.h"
|
2005-04-27 18:21:00 +02:00
|
|
|
#include "diff.h"
|
Log message printout cleanups
On Sun, 16 Apr 2006, Junio C Hamano wrote:
>
> In the mid-term, I am hoping we can drop the generate_header()
> callchain _and_ the custom code that formats commit log in-core,
> found in cmd_log_wc().
Ok, this was nastier than expected, just because the dependencies between
the different log-printing stuff were absolutely _everywhere_, but here's
a patch that does exactly that.
The patch is not very easy to read, and the "--patch-with-stat" thing is
still broken (it does not call the "show_log()" thing properly for
merges). That's not a new bug. In the new world order it _should_ do
something like
if (rev->logopt)
show_log(rev, rev->logopt, "---\n");
but it doesn't. I haven't looked at the --with-stat logic, so I left it
alone.
That said, this patch removes more lines than it adds, and in particular,
the "cmd_log_wc()" loop is now a very clean:
while ((commit = get_revision(rev)) != NULL) {
log_tree_commit(rev, commit);
free(commit->buffer);
commit->buffer = NULL;
}
so it doesn't get much prettier than this. All the complexity is entirely
hidden in log-tree.c, and any code that needs to flush the log literally
just needs to do the "if (rev->logopt) show_log(...)" incantation.
I had to make the combined_diff() logic take a "struct rev_info" instead
of just a "struct diff_options", but that part is pretty clean.
This does change "git whatchanged" from using "diff-tree" as the commit
descriptor to "commit", and I changed one of the tests to reflect that new
reality. Otherwise everything still passes, and my other tests look fine
too.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-04-17 20:59:32 +02:00
|
|
|
#include "commit.h"
|
|
|
|
|
#include "revision.h"
|
2006-05-23 14:15:36 +02:00
|
|
|
#include "builtin.h"
|
2005-04-12 11:04:44 +02:00
|
|
|
|
2005-07-29 11:01:26 +02:00
|
|
|
static const char diff_files_usage[] =
|
2007-04-27 06:58:55 +02:00
|
|
|
"git-diff-files [-q] [-0/-1/2/3 |-c|--cc|--no-index] [<common diff options>] [<path>...]"
|
2005-07-13 21:52:35 +02:00
|
|
|
COMMON_DIFF_OPTIONS_HELP;
|
2005-04-17 06:29:45 +02:00
|
|
|
|
2006-07-29 07:44:25 +02:00
|
|
|
int cmd_diff_files(int argc, const char **argv, const char *prefix)
|
2005-04-08 00:13:13 +02:00
|
|
|
{
|
2006-04-22 08:57:45 +02:00
|
|
|
struct rev_info rev;
|
2007-02-22 21:50:10 +01:00
|
|
|
int nongit = 0;
|
2007-03-14 01:17:04 +01:00
|
|
|
int result;
|
2005-04-08 00:13:13 +02:00
|
|
|
|
2007-02-22 21:50:10 +01:00
|
|
|
prefix = setup_git_directory_gently(&nongit);
|
2006-07-29 07:44:25 +02:00
|
|
|
init_revisions(&rev, prefix);
|
2006-07-28 07:55:44 +02:00
|
|
|
git_config(git_default_config); /* no "diff" UI options */
|
2006-04-22 08:57:45 +02:00
|
|
|
rev.abbrev = 0;
|
|
|
|
|
|
2007-02-25 23:35:27 +01:00
|
|
|
if (!setup_diff_no_index(&rev, argc, argv, nongit, prefix))
|
|
|
|
|
argc = 0;
|
|
|
|
|
else
|
|
|
|
|
argc = setup_revisions(argc, argv, &rev, NULL);
|
2006-06-24 19:24:14 +02:00
|
|
|
if (!rev.diffopt.output_format)
|
|
|
|
|
rev.diffopt.output_format = DIFF_FORMAT_RAW;
|
2007-03-14 01:17:04 +01:00
|
|
|
result = run_diff_files_cmd(&rev, argc, argv);
|
|
|
|
|
return rev.diffopt.exit_with_status ? rev.diffopt.has_changes: result;
|
2005-04-08 00:13:13 +02:00
|
|
|
}
|