2006-03-05 12:13:34 +01:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
2007-07-03 07:52:14 +02:00
|
|
|
test_description='git blame'
|
2006-03-05 12:13:34 +01:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
|
|
PROG='git blame -c'
|
2008-08-08 11:26:28 +02:00
|
|
|
. "$TEST_DIRECTORY"/annotate-tests.sh
|
2006-03-05 12:13:34 +01:00
|
|
|
|
blame: fix segfault on untracked files
Since 3b75ee9 ("blame: allow to blame paths freshly added to the index",
2016-07-16) git blame also looks at the index to determine if there is a
file that was freshly added to the index.
cache_name_pos returns -pos - 1 in case there is no match is found, or
if the name matches, but the entry has a stage other than 0. As git
blame should work for unmerged files, it uses strcmp to determine
whether the name of the returned position matches, in which case the
file exists, but is merely unmerged, or if the file actually doesn't
exist in the index.
If the repository is empty, or if the file would lexicographically be
sorted as the last file in the repository, -cache_name_pos - 1 is
outside of the length of the active_cache array, causing git blame to
segfault. Guard against that, and die() normally to restore the old
behaviour.
Reported-by: Simon Ruderich <simon@ruderich.org>
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-08-27 22:01:50 +02:00
|
|
|
test_expect_success 'blame untracked file in empty repo' '
|
|
|
|
|
>untracked &&
|
|
|
|
|
test_must_fail git blame untracked
|
|
|
|
|
'
|
|
|
|
|
|
2010-10-16 08:57:51 +02:00
|
|
|
PROG='git blame -c -e'
|
2013-07-17 23:25:28 +02:00
|
|
|
test_expect_success 'blame --show-email' '
|
|
|
|
|
check_count \
|
|
|
|
|
"<A@test.git>" 1 \
|
|
|
|
|
"<B@test.git>" 1 \
|
|
|
|
|
"<B1@test.git>" 1 \
|
|
|
|
|
"<B2@test.git>" 1 \
|
|
|
|
|
"<author@example.com>" 1 \
|
|
|
|
|
"<C@test.git>" 1 \
|
|
|
|
|
"<D@test.git>" 1 \
|
|
|
|
|
"<E at test dot git>" 1
|
2010-10-16 08:57:51 +02:00
|
|
|
'
|
|
|
|
|
|
2015-05-31 21:27:37 +02:00
|
|
|
test_expect_success 'setup showEmail tests' '
|
|
|
|
|
echo "bin: test number 1" >one &&
|
|
|
|
|
git add one &&
|
|
|
|
|
GIT_AUTHOR_NAME=name1 \
|
|
|
|
|
GIT_AUTHOR_EMAIL=email1@test.git \
|
|
|
|
|
git commit -m First --date="2010-01-01 01:00:00" &&
|
|
|
|
|
cat >expected_n <<-\EOF &&
|
|
|
|
|
(name1 2010-01-01 01:00:00 +0000 1) bin: test number 1
|
|
|
|
|
EOF
|
|
|
|
|
cat >expected_e <<-\EOF
|
|
|
|
|
(<email1@test.git> 2010-01-01 01:00:00 +0000 1) bin: test number 1
|
|
|
|
|
EOF
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
find_blame () {
|
|
|
|
|
sed -e 's/^[^(]*//'
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame with no options and no config' '
|
|
|
|
|
git blame one >blame &&
|
|
|
|
|
find_blame <blame >result &&
|
|
|
|
|
test_cmp expected_n result
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame with showemail options' '
|
|
|
|
|
git blame --show-email one >blame1 &&
|
|
|
|
|
find_blame <blame1 >result &&
|
|
|
|
|
test_cmp expected_e result &&
|
|
|
|
|
git blame -e one >blame2 &&
|
|
|
|
|
find_blame <blame2 >result &&
|
|
|
|
|
test_cmp expected_e result &&
|
|
|
|
|
git blame --no-show-email one >blame3 &&
|
|
|
|
|
find_blame <blame3 >result &&
|
|
|
|
|
test_cmp expected_n result
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame with showEmail config false' '
|
|
|
|
|
git config blame.showEmail false &&
|
|
|
|
|
git blame one >blame1 &&
|
|
|
|
|
find_blame <blame1 >result &&
|
|
|
|
|
test_cmp expected_n result &&
|
|
|
|
|
git blame --show-email one >blame2 &&
|
|
|
|
|
find_blame <blame2 >result &&
|
|
|
|
|
test_cmp expected_e result &&
|
|
|
|
|
git blame -e one >blame3 &&
|
|
|
|
|
find_blame <blame3 >result &&
|
|
|
|
|
test_cmp expected_e result &&
|
|
|
|
|
git blame --no-show-email one >blame4 &&
|
|
|
|
|
find_blame <blame4 >result &&
|
|
|
|
|
test_cmp expected_n result
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame with showEmail config true' '
|
|
|
|
|
git config blame.showEmail true &&
|
|
|
|
|
git blame one >blame1 &&
|
|
|
|
|
find_blame <blame1 >result &&
|
|
|
|
|
test_cmp expected_e result &&
|
|
|
|
|
git blame --no-show-email one >blame2 &&
|
|
|
|
|
find_blame <blame2 >result &&
|
|
|
|
|
test_cmp expected_n result
|
|
|
|
|
'
|
|
|
|
|
|
blame: fix alignment with --abbrev=40
The blame command internally adds 1 to any requested sha1
abbreviation length, and then subtracts it when outputting a
boundary commit. This lets regular and boundary sha1s line
up visually, but it misses one corner case.
When the requested length is 40, we bump the value to 41.
But since we only have 40 characters, that's all we can show
(fortunately the truncation is done by a printf precision
field, so it never tries to read past the end of the
buffer). So a normal sha1 shows 40 hex characters, and a
boundary sha1 shows "^" plus 40 hex characters. The result
is misaligned.
The "-l" option to show long sha1s gets around this by
skipping the "abbrev" variable entirely and just always
using GIT_SHA1_HEXSZ. This avoids the "+1" issue, but it
does mean that boundary commits only have 39 characters
printed. This is somewhat odd, but it does look good
visually: the results are aligned and left-justified. The
alternative would be to allocate an extra column that would
contain either an extra space or the "^" boundary marker.
As this is by definition the human-readable view, it's
probably not that big a deal either way (and of course
--porcelain, etc, correctly produce correct 40-hex sha1s).
But for consistency, this patch teaches --abbrev=40 to
produce the same output as "-l" (always left-aligned, with
40-hex for normal sha1s, and "^" plus 39-hex for
boundaries).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-01-06 05:17:40 +01:00
|
|
|
test_expect_success 'set up abbrev tests' '
|
|
|
|
|
test_commit abbrev &&
|
|
|
|
|
sha1=$(git rev-parse --verify HEAD) &&
|
|
|
|
|
check_abbrev () {
|
|
|
|
|
expect=$1; shift
|
|
|
|
|
echo $sha1 | cut -c 1-$expect >expect &&
|
|
|
|
|
git blame "$@" abbrev.t >actual &&
|
|
|
|
|
perl -lne "/[0-9a-f]+/ and print \$&" <actual >actual.sha &&
|
|
|
|
|
test_cmp expect actual.sha
|
|
|
|
|
}
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame --abbrev=<n> works' '
|
|
|
|
|
# non-boundary commits get +1 for alignment
|
|
|
|
|
check_abbrev 31 --abbrev=30 HEAD &&
|
|
|
|
|
check_abbrev 30 --abbrev=30 ^HEAD
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame -l aligns regular and boundary commits' '
|
|
|
|
|
check_abbrev 40 -l HEAD &&
|
|
|
|
|
check_abbrev 39 -l ^HEAD
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'blame --abbrev=40 behaves like -l' '
|
|
|
|
|
check_abbrev 40 --abbrev=40 HEAD &&
|
|
|
|
|
check_abbrev 39 --abbrev=40 ^HEAD
|
|
|
|
|
'
|
|
|
|
|
|
2017-01-06 05:18:08 +01:00
|
|
|
test_expect_success '--no-abbrev works like --abbrev=40' '
|
|
|
|
|
check_abbrev 40 --no-abbrev
|
|
|
|
|
'
|
|
|
|
|
|
2006-03-05 12:13:34 +01:00
|
|
|
test_done
|