mirrors/git - Incest Forge: Beyond sex. We incest.

mirrors/git

mirror of https://github.com/git/git.git synced 2024-11-06 01:03:02 +01:00

27 lines

218 B

Text

Raw Normal View History

remove unnecessary NULL check before free(3) free(3) handles NULL pointers just fine. Add a semantic patch for removing unnecessary NULL checks before calling this function, and apply it on the code base. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2016-10-08 16:14:57 +02:00			`@@`
			`expression E;`
			`@@`
			`- if (E)`
			`free(E);`
cocci: detect useless free(3) calls Add a semantic patch for removing checks that cause free(3) to only be called with a NULL pointer, as that must be a programming mistake. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-02-11 14:58:44 +01:00
			`@@`
			`expression E;`
			`@@`
			`- if (!E)`
			`free(E);`
coccinelle: add a rule to make "type" code use FREE_AND_NULL() Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-06-16 01:15:45 +02:00
			`@@`
			`type T;`
			`T *ptr;`
			`@@`
			`- free(ptr);`
			`- ptr = NULL;`
			`+ FREE_AND_NULL(ptr);`
coccinelle: add a rule to make "expression" code use FREE_AND_NULL() A follow-up to the existing "type" rule added in an earlier change. This catches some occurrences that are missed by the previous rule. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-06-16 01:15:47 +02:00
			`@@`
			`expression E;`
			`@@`
			`- free(E);`
			`- E = NULL;`
			`+ FREE_AND_NULL(E);`