mirror of
https://github.com/git/git.git
synced 2024-10-30 05:47:53 +01:00
parse_cmd_verify(): copy old_sha1 instead of evaluating <oldvalue> twice
Aside from avoiding a tiny bit of work, this makes it transparently obvious that old_sha1 and new_sha1 are identical. It is arguably a bit silly to have to set new_sha1 in order to verify old_sha1, but that is a problem for another day. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
e23d84350a
commit
2f57736002
1 changed files with 1 additions and 1 deletions
|
@ -249,7 +249,7 @@ static const char *parse_cmd_verify(struct strbuf *input, const char *next)
|
|||
|
||||
if (!parse_next_arg(input, &next, &value)) {
|
||||
update_store_old_sha1(update, value.buf);
|
||||
update_store_new_sha1(update, value.buf);
|
||||
hashcpy(update->new_sha1, update->old_sha1);
|
||||
} else if (!line_termination)
|
||||
die("verify %s missing [<oldvalue>] NUL", ref.buf);
|
||||
|
||||
|
|
Loading…
Reference in a new issue