mirrors/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-10-28 12:59:41 +01:00
Code Activity

parse-options: mark unused "opt" parameter in callbacks

Browse source 
The previous commit argued that parse-options callbacks should try to
use opt->value rather than touching globals directly. In some cases,
however, that's awkward to do. Some callbacks touch multiple variables,
or may even just call into an abstracted function that does so.

In some of these cases we _could_ convert them by stuffing the multiple
variables into a single struct and passing the struct pointer through
opt->value. But that may make other parts of the code less readable,
as the struct relationship has to be mentioned everywhere.

Let's just accept that these cases are special and leave them as-is. But
we do need to mark their "opt" parameters to satisfy -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2023-08-31 17:21:28 -04:00 committed by Junio C Hamano
parent 66e3309294
commit 34bf44f2d5
6 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
builtin/gc.c
View file

@ -1403,7 +1403,7 @@ static void initialize_task_config(int schedule)
strbuf_release(&config_name);
}
static int task_option_parse(const struct option *opt,
static int task_option_parse(const struct option *opt UNUSED,
const char *arg, int unset)
{
int i, num_selected = 0;

10
builtin/log.c
View file

@ -118,8 +118,8 @@ static struct string_list decorate_refs_exclude = STRING_LIST_INIT_NODUP;
static struct string_list decorate_refs_exclude_config = STRING_LIST_INIT_NODUP;
static struct string_list decorate_refs_include = STRING_LIST_INIT_NODUP;
static int clear_decorations_callback(const struct option *opt,
const char *arg, int unset)
static int clear_decorations_callback(const struct option *opt UNUSED,
const char *arg, int unset)
{
string_list_clear(&decorate_refs_include, 0);
string_list_clear(&decorate_refs_exclude, 0);
@ -127,7 +127,8 @@ static int clear_decorations_callback(const struct option *opt,
return 0;
}
static int decorate_callback(const struct option *opt, const char *arg, int unset)
static int decorate_callback(const struct option *opt UNUSED, const char *arg,
int unset)
{
if (unset)
decoration_style = 0;
@ -1555,7 +1556,8 @@ static int inline_callback(const struct option *opt, const char *arg, int unset)
return 0;
}
static int header_callback(const struct option *opt, const char *arg, int unset)
static int header_callback(const struct option *opt UNUSED, const char *arg,
int unset)
{
if (unset) {
string_list_clear(&extra_hdr, 0);

2
builtin/merge.c
View file

@ -231,7 +231,7 @@ static void append_strategy(struct strategy *s)
use_strategies[use_strategies_nr++] = s;
}
static int option_parse_strategy(const struct option *opt,
static int option_parse_strategy(const struct option *opt UNUSED,
const char *name, int unset)
{
if (unset)

6
builtin/pack-objects.c
View file

@ -3739,7 +3739,7 @@ static void show_object__ma_allow_promisor(struct object *obj, const char *name,
show_object(obj, name, data);
}
static int option_parse_missing_action(const struct option *opt,
static int option_parse_missing_action(const struct option *opt UNUSED,
const char *arg, int unset)
{
assert(arg);
@ -4150,7 +4150,7 @@ static int option_parse_index_version(const struct option *opt,
return 0;
}
static int option_parse_unpack_unreachable(const struct option *opt,
static int option_parse_unpack_unreachable(const struct option *opt UNUSED,
const char *arg, int unset)
{
if (unset) {
@ -4165,7 +4165,7 @@ static int option_parse_unpack_unreachable(const struct option *opt,
return 0;
}
static int option_parse_cruft_expiration(const struct option *opt,
static int option_parse_cruft_expiration(const struct option *opt UNUSED,
const char *arg, int unset)
{
if (unset) {

2
builtin/read-tree.c
View file

@ -49,7 +49,7 @@ static const char * const read_tree_usage[] = {
NULL
};
static int index_output_cb(const struct option *opt, const char *arg,
static int index_output_cb(const struct option *opt UNUSED, const char *arg,
int unset)
{
BUG_ON_OPT_NEG(unset);

4
builtin/update-index.c
View file

@ -856,7 +856,7 @@ static int chmod_callback(const struct option *opt,
return 0;
}
static int resolve_undo_clear_callback(const struct option *opt,
static int resolve_undo_clear_callback(const struct option *opt UNUSED,
const char *arg, int unset)
{
BUG_ON_OPT_NEG(unset);
@ -890,7 +890,7 @@ static int parse_new_style_cacheinfo(const char *arg,
}
static enum parse_opt_result cacheinfo_callback(
struct parse_opt_ctx_t *ctx, const struct option *opt,
struct parse_opt_ctx_t *ctx, const struct option *opt UNUSED,
const char *arg, int unset)
{
struct object_id oid;