mirror of
https://github.com/git/git.git
synced 2024-10-31 22:37:54 +01:00
Merge branch 'kd/auto-col-with-pager-fix'
"auto" as a value for the columnar output configuration ought to judge "is the output consumed by humans?" with the same criteria as "auto" for coloured output configuration, i.e. either the standard output stream is going to tty, or a pager is in use. We forgot the latter, which has been fixed. * kd/auto-col-with-pager-fix: column: do not include pager.c column: show auto columns when pager is active
This commit is contained in:
commit
36625e219d
2 changed files with 15 additions and 1 deletions
2
column.c
2
column.c
|
@ -224,7 +224,7 @@ int finalize_colopts(unsigned int *colopts, int stdout_is_tty)
|
|||
if (stdout_is_tty < 0)
|
||||
stdout_is_tty = isatty(1);
|
||||
*colopts &= ~COL_ENABLE_MASK;
|
||||
if (stdout_is_tty)
|
||||
if (stdout_is_tty || pager_in_use())
|
||||
*colopts |= COL_ENABLED;
|
||||
}
|
||||
return 0;
|
||||
|
|
|
@ -570,4 +570,18 @@ test_expect_success 'command with underscores does not complain' '
|
|||
test_cmp expect actual
|
||||
'
|
||||
|
||||
test_expect_success TTY 'git tag with auto-columns ' '
|
||||
test_commit one &&
|
||||
test_commit two &&
|
||||
test_commit three &&
|
||||
test_commit four &&
|
||||
test_commit five &&
|
||||
cat >expect <<-\EOF &&
|
||||
initial one two three four five
|
||||
EOF
|
||||
test_terminal env PAGER="cat >actual" COLUMNS=80 \
|
||||
git -c column.ui=auto tag --sort=authordate &&
|
||||
test_cmp expect actual
|
||||
'
|
||||
|
||||
test_done
|
||||
|
|
Loading…
Reference in a new issue