mirror of
https://github.com/git/git.git
synced 2024-10-31 22:37:54 +01:00
gitweb: Use block form of map/grep in a few cases more
Use block form of 'grep' i.e. 'grep {BLOCK} LIST' rather than 'grep(EXPR, LIST)' in filter_snapshot_fmts subroutine. This makes code more readable, as expression is rather long, and statement above there is 'map' with very similar expression also in the block form. Remove unnecessary and misleading parentheses around block form 'map' arguments in quote_command subroutine. The inner "map" in format_snapshot_links was left alone, as it is not clear whether adding parentheses or changing it into block form would improve readibility and clarity of this code. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
34122b57ec
commit
68cedb1fea
1 changed files with 3 additions and 3 deletions
|
@ -458,8 +458,8 @@ sub filter_snapshot_fmts {
|
|||
@fmts = map {
|
||||
exists $known_snapshot_format_aliases{$_} ?
|
||||
$known_snapshot_format_aliases{$_} : $_} @fmts;
|
||||
@fmts = grep(exists $known_snapshot_formats{$_}, @fmts);
|
||||
|
||||
@fmts = grep {
|
||||
exists $known_snapshot_formats{$_} } @fmts;
|
||||
}
|
||||
|
||||
our $GITWEB_CONFIG = $ENV{'GITWEB_CONFIG'} || "++GITWEB_CONFIG++";
|
||||
|
@ -1838,7 +1838,7 @@ sub git_cmd {
|
|||
# Try to avoid using this function wherever possible.
|
||||
sub quote_command {
|
||||
return join(' ',
|
||||
map( { my $a = $_; $a =~ s/(['!])/'\\$1'/g; "'$a'" } @_ ));
|
||||
map { my $a = $_; $a =~ s/(['!])/'\\$1'/g; "'$a'" } @_ );
|
||||
}
|
||||
|
||||
# get HEAD ref of given project as hash
|
||||
|
|
Loading…
Reference in a new issue