mirror of
https://github.com/git/git.git
synced 2024-10-28 12:59:41 +01:00
t9001: use a more distinct fake BugID
In the test "cc list is sanitized", we feed a commit with a variety of trailers to send-email, and then check its output to see how it handled them. For most of them, we are grepping for a specific mention of the header, but there's a "BugID" header which we expect to be ignored. We confirm this by grepping for "12345", the fake BugID, and making sure it is not present. But we can be fooled by false positives! I just tracked down a flaky test failure here that was caused by matching this unrelated line in the output: <20240914090449.612345-1-author@example.com> which will change from run to run based on the time, pid, etc. Ideally we'd tighten the regex to make this more specifically, but since the point is that it _shouldn't_ be mentioned, it's hard to say what the right match would be (e.g., would there be a leading space?). Instead, let's just choose a match that is much less likely to appear. The actual content of the header isn't important, since it's supposed to be ignored. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
39bf06adf9
commit
83799f1500
1 changed files with 2 additions and 2 deletions
|
@ -1324,7 +1324,7 @@ test_expect_success $PREREQ 'cc list is sanitized' '
|
|||
Reviewed-by: Füñný Nâmé <odd_?=mail@example.com>
|
||||
Reported-by: bugger on Jira
|
||||
Reported-by: Douglas Reporter <doug@example.com> [from Jira profile]
|
||||
BugID: 12345
|
||||
BugID: 12345should-not-appear
|
||||
Co-developed-by: "C. O. Developer" <codev@example.com>
|
||||
Signed-off-by: A. U. Thor <thor.au@example.com>
|
||||
EOF
|
||||
|
@ -1337,7 +1337,7 @@ test_expect_success $PREREQ 'cc list is sanitized' '
|
|||
" <odd_?=mail@example.com>" actual-show-all-headers &&
|
||||
test_grep "^(body) Ignoring Reported-by .* bugger on Jira" actual-show-all-headers &&
|
||||
test_grep "^(body) Adding cc: Douglas Reporter <doug@example.com>" actual-show-all-headers &&
|
||||
test_grep ! "12345" actual-show-all-headers &&
|
||||
test_grep ! "12345should-not-appear" actual-show-all-headers &&
|
||||
test_grep "^(body) Adding cc: \"C. O. Developer\" <codev@example.com>" actual-show-all-headers &&
|
||||
test_grep "^(body) Adding cc: \"A. U. Thor\" <thor.au@example.com>" actual-show-all-headers
|
||||
'
|
||||
|
|
Loading…
Reference in a new issue