mirror of
https://github.com/git/git.git
synced 2024-10-28 04:49:43 +01:00
connect: clear child process before freeing in diagnostic mode
The git_connect() function has a special CONNECT_DIAG_URL mode, where we stop short of actually connecting to the other side and just print some parsing details. For URLs that require a child process (like ssh), we free() the child_process struct but forget to clear it, leaking the strings we stuffed into its "env" list. This leak is triggered many times in t5500, which uses "fetch-pack --diag-url", but we're not yet ready to mark it as leak-free. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
6f54d00439
commit
91aa673539
1 changed files with 1 additions and 0 deletions
|
@ -1485,6 +1485,7 @@ struct child_process *git_connect(int fd[2], const char *url,
|
|||
|
||||
free(hostandport);
|
||||
free(path);
|
||||
child_process_clear(conn);
|
||||
free(conn);
|
||||
strbuf_release(&cmd);
|
||||
return NULL;
|
||||
|
|
Loading…
Reference in a new issue