mirror of
https://github.com/git/git.git
synced 2024-10-28 04:49:43 +01:00
a5aecb2cdc
The lifecycle management of diff queues is somewhat confusing:
- For most of the part this can be attributed to `DIFF_QUEUE_CLEAR()`,
which does not release any memory but rather initializes the queue,
only. This is in contrast to our common naming schema, where
"clearing" means that we release underlying memory and then
re-initialize the data structure such that it is ready to use.
- A second offender is `diff_free_queue()`, which does not free the
queue structure itself. It is rather a release-style function.
Refactor the code to make things less confusing. `DIFF_QUEUE_CLEAR()` is
replaced by `DIFF_QUEUE_INIT` and `diff_queue_init()`, while
`diff_free_queue()` is replaced by `diff_queue_release()`. While on it,
adapt callsites where we call `DIFF_QUEUE_CLEAR()` with the intent to
release underlying memory to instead call `diff_queue_clear()` to fix
memory leaks.
This memory leak is exposed by t4211, but plugging it alone does not
make the whole test suite pass.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
46 lines
1 KiB
C
46 lines
1 KiB
C
/*
|
|
* Copyright (C) 2021, Google LLC.
|
|
* Based on diffcore-order.c, which is Copyright (C) 2005, Junio C Hamano
|
|
*/
|
|
#include "git-compat-util.h"
|
|
#include "gettext.h"
|
|
#include "diff.h"
|
|
#include "diffcore.h"
|
|
|
|
void diffcore_rotate(struct diff_options *opt)
|
|
{
|
|
struct diff_queue_struct *q = &diff_queued_diff;
|
|
struct diff_queue_struct outq = DIFF_QUEUE_INIT;
|
|
int rotate_to, i;
|
|
|
|
if (!q->nr)
|
|
return;
|
|
|
|
for (i = 0; i < q->nr; i++) {
|
|
int cmp = strcmp(opt->rotate_to, q->queue[i]->two->path);
|
|
if (!cmp)
|
|
break; /* exact match */
|
|
if (!opt->rotate_to_strict && cmp < 0)
|
|
break; /* q->queue[i] is now past the target pathname */
|
|
}
|
|
|
|
if (q->nr <= i) {
|
|
/* we did not find the specified path */
|
|
if (opt->rotate_to_strict)
|
|
die(_("No such path '%s' in the diff"), opt->rotate_to);
|
|
return;
|
|
}
|
|
|
|
rotate_to = i;
|
|
|
|
for (i = rotate_to; i < q->nr; i++)
|
|
diff_q(&outq, q->queue[i]);
|
|
for (i = 0; i < rotate_to; i++) {
|
|
if (opt->skip_instead_of_rotate)
|
|
diff_free_filepair(q->queue[i]);
|
|
else
|
|
diff_q(&outq, q->queue[i]);
|
|
}
|
|
free(q->queue);
|
|
*q = outq;
|
|
}
|