mirror of
https://github.com/git/git.git
synced 2024-10-28 04:49:43 +01:00
64fe1e4a8c
The `OPT_PATHSPEC_FROM_FILE()` option maps to `OPT_FILENAME()`, which we know will always allocate memory when passed. We never free the memory though, causing a memory leak. Plug it. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
101 lines
2.2 KiB
Bash
Executable file
101 lines
2.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='stash --pathspec-from-file'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_tick
|
|
|
|
test_expect_success setup '
|
|
>fileA.t &&
|
|
>fileB.t &&
|
|
>fileC.t &&
|
|
>fileD.t &&
|
|
git add fileA.t fileB.t fileC.t fileD.t &&
|
|
git commit -m "Files" &&
|
|
|
|
git tag checkpoint
|
|
'
|
|
|
|
restore_checkpoint () {
|
|
git reset --hard checkpoint
|
|
}
|
|
|
|
verify_expect () {
|
|
git stash show --name-status >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
test_expect_success 'simplest' '
|
|
restore_checkpoint &&
|
|
|
|
# More files are written to make sure that git didnt ignore
|
|
# --pathspec-from-file, stashing everything
|
|
echo A >fileA.t &&
|
|
echo B >fileB.t &&
|
|
echo C >fileC.t &&
|
|
echo D >fileD.t &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
M fileA.t
|
|
EOF
|
|
|
|
echo fileA.t | git stash push --pathspec-from-file=- &&
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success '--pathspec-file-nul' '
|
|
restore_checkpoint &&
|
|
|
|
# More files are written to make sure that git didnt ignore
|
|
# --pathspec-from-file, stashing everything
|
|
echo A >fileA.t &&
|
|
echo B >fileB.t &&
|
|
echo C >fileC.t &&
|
|
echo D >fileD.t &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
M fileA.t
|
|
M fileB.t
|
|
EOF
|
|
|
|
printf "fileA.t\0fileB.t\0" | git stash push --pathspec-from-file=- --pathspec-file-nul &&
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'only touches what was listed' '
|
|
restore_checkpoint &&
|
|
|
|
# More files are written to make sure that git didnt ignore
|
|
# --pathspec-from-file, stashing everything
|
|
echo A >fileA.t &&
|
|
echo B >fileB.t &&
|
|
echo C >fileC.t &&
|
|
echo D >fileD.t &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
M fileB.t
|
|
M fileC.t
|
|
EOF
|
|
|
|
printf "fileB.t\nfileC.t\n" | git stash push --pathspec-from-file=- &&
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'error conditions' '
|
|
restore_checkpoint &&
|
|
echo A >fileA.t &&
|
|
echo fileA.t >list &&
|
|
|
|
test_must_fail git stash push --pathspec-from-file=list --patch 2>err &&
|
|
test_grep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err &&
|
|
|
|
test_must_fail git stash push --pathspec-from-file=list -- fileA.t 2>err &&
|
|
test_grep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
|
|
|
|
test_must_fail git stash push --pathspec-file-nul 2>err &&
|
|
test_grep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err
|
|
'
|
|
|
|
test_done
|