mirror of
https://github.com/git/git.git
synced 2024-11-09 02:33:11 +01:00
f69e836fab
This fixes the remainder of the issues where the test script itself is at fault for failing when the git checkout path contains whitespace or other shell metacharacters. The majority of git svn tests used the idiom test_expect_success "title" "test script using $svnrepo" These were changed to have the test script in single-quotes: test_expect_success "title" 'test script using "$svnrepo"' which unfortunately makes the patch appear larger than it really is. One consequence of this change is that in the verbose test output the value of $svnrepo (and in some cases other variables, too) is no longer expanded, i.e. previously we saw * expecting success: test script using /path/to/git/t/trash/svnrepo but now it is: * expecting success: test script using "$svnrepo" Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
31 lines
683 B
Bash
Executable file
31 lines
683 B
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2008 Kevin Ballard
|
|
#
|
|
|
|
test_description='git-svn clone with percent escapes'
|
|
. ./lib-git-svn.sh
|
|
|
|
test_expect_success 'setup svnrepo' '
|
|
mkdir project project/trunk project/branches project/tags &&
|
|
echo foo > project/trunk/foo &&
|
|
svn import -m "$test_description" project "$svnrepo/pr ject" &&
|
|
rm -rf project &&
|
|
start_httpd
|
|
'
|
|
|
|
if test "$SVN_HTTPD_PORT" = ""
|
|
then
|
|
test_expect_failure 'test clone with percent escapes - needs SVN_HTTPD_PORT set' 'false'
|
|
else
|
|
test_expect_success 'test clone with percent escapes' '
|
|
git svn clone "$svnrepo/pr%20ject" clone &&
|
|
cd clone &&
|
|
git rev-parse refs/remotes/git-svn &&
|
|
cd ..
|
|
'
|
|
fi
|
|
|
|
stop_httpd
|
|
|
|
test_done
|