mirror of
https://github.com/git/git.git
synced 2024-11-13 20:53:02 +01:00
41ac414ea2
Originally, test_expect_failure was designed to be the opposite
of test_expect_success, but this was a bad decision. Most tests
run a series of commands that leads to the single command that
needs to be tested, like this:
test_expect_{success,failure} 'test title' '
setup1 &&
setup2 &&
setup3 &&
what is to be tested
'
And expecting a failure exit from the whole sequence misses the
point of writing tests. Your setup$N that are supposed to
succeed may have failed without even reaching what you are
trying to test. The only valid use of test_expect_failure is to
check a trivial single command that is expected to fail, which
is a minority in tests of Porcelain-ish commands.
This large-ish patch rewrites all uses of test_expect_failure to
use test_expect_success and rewrites the condition of what is
tested, like this:
test_expect_success 'test title' '
setup1 &&
setup2 &&
setup3 &&
! this command should fail
'
test_expect_failure is redefined to serve as a reminder that
that test *should* succeed but due to a known breakage in git it
currently does not pass. So if git-foo command should create a
file 'bar' but you discovered a bug that it doesn't, you can
write a test like this:
test_expect_failure 'git-foo should create bar' '
rm -f bar &&
git foo &&
test -f bar
'
This construct acts similar to test_expect_success, but instead
of reporting "ok/FAIL" like test_expect_success does, the
outcome is reported as "FIXED/still broken".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
82 lines
1.8 KiB
Bash
Executable file
82 lines
1.8 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 David Symonds
|
|
|
|
test_description='git checkout from subdirectories'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
echo "base" > file0 &&
|
|
git add file0 &&
|
|
mkdir dir1 &&
|
|
echo "hello" > dir1/file1 &&
|
|
git add dir1/file1 &&
|
|
mkdir dir2 &&
|
|
echo "bonjour" > dir2/file2 &&
|
|
git add dir2/file2 &&
|
|
test_tick &&
|
|
git commit -m "populate tree"
|
|
|
|
'
|
|
|
|
test_expect_success 'remove and restore with relative path' '
|
|
|
|
(
|
|
cd dir1 &&
|
|
rm ../file0 &&
|
|
git checkout HEAD -- ../file0 &&
|
|
test "base" = "$(cat ../file0)" &&
|
|
rm ../dir2/file2 &&
|
|
git checkout HEAD -- ../dir2/file2 &&
|
|
test "bonjour" = "$(cat ../dir2/file2)" &&
|
|
rm ../file0 ./file1 &&
|
|
git checkout HEAD -- .. &&
|
|
test "base" = "$(cat ../file0)" &&
|
|
test "hello" = "$(cat file1)"
|
|
)
|
|
|
|
'
|
|
|
|
test_expect_success 'checkout with empty prefix' '
|
|
|
|
rm file0 &&
|
|
git checkout HEAD -- file0 &&
|
|
test "base" = "$(cat file0)"
|
|
|
|
'
|
|
|
|
test_expect_success 'checkout with simple prefix' '
|
|
|
|
rm dir1/file1 &&
|
|
git checkout HEAD -- dir1 &&
|
|
test "hello" = "$(cat dir1/file1)" &&
|
|
rm dir1/file1 &&
|
|
git checkout HEAD -- dir1/file1 &&
|
|
test "hello" = "$(cat dir1/file1)"
|
|
|
|
'
|
|
|
|
# This is not expected to work as ls-files was not designed
|
|
# to deal with such. Enable it when ls-files is updated.
|
|
: test_expect_success 'checkout with complex relative path' '
|
|
|
|
rm file1 &&
|
|
git checkout HEAD -- ../dir1/../dir1/file1 && test -f ./file1
|
|
|
|
'
|
|
|
|
test_expect_success 'relative path outside tree should fail' \
|
|
'! git checkout HEAD -- ../../Makefile'
|
|
|
|
test_expect_success 'incorrect relative path to file should fail (1)' \
|
|
'! git checkout HEAD -- ../file0'
|
|
|
|
test_expect_success 'incorrect relative path should fail (2)' \
|
|
'( cd dir1 && ! git checkout HEAD -- ./file0 )'
|
|
|
|
test_expect_success 'incorrect relative path should fail (3)' \
|
|
'( cd dir1 && ! git checkout HEAD -- ../../file0 )'
|
|
|
|
test_done
|