mirror of
https://github.com/git/git.git
synced 2024-10-30 05:47:53 +01:00
400caafb2b
On AIX, access(X_OK) may succeed when run as root even if the execution isn't possible. This behavior is allowed by POSIX which says: ... for a process with appropriate privileges, an implementation may indicate success for X_OK even if execute permission is not granted to any user. It can lead hook programs to have their execution refused: git commit -m content fatal: cannot exec '.git/hooks/pre-commit': Permission denied Add NEED_ACCESS_ROOT_HANDLER in order to use an access helper function. It checks with stat if any executable flags is set when the current user is root. Signed-off-by: Clément Chigot <clement.chigot@atos.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
31 lines
669 B
C
31 lines
669 B
C
#define COMPAT_CODE_ACCESS
|
|
#include "../git-compat-util.h"
|
|
|
|
/* Do the same thing access(2) does, but use the effective uid,
|
|
* and don't make the mistake of telling root that any file is
|
|
* executable. This version uses stat(2).
|
|
*/
|
|
int git_access(const char *path, int mode)
|
|
{
|
|
struct stat st;
|
|
|
|
/* do not interfere a normal user */
|
|
if (geteuid())
|
|
return access(path, mode);
|
|
|
|
if (stat(path, &st) < 0)
|
|
return -1;
|
|
|
|
/* Root can read or write any file. */
|
|
if (!(mode & X_OK))
|
|
return 0;
|
|
|
|
/* Root can execute any file that has any one of the execute
|
|
* bits set.
|
|
*/
|
|
if (st.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH))
|
|
return 0;
|
|
|
|
errno = EACCES;
|
|
return -1;
|
|
}
|