mirror of
https://github.com/git/git.git
synced 2024-11-12 20:23:02 +01:00
2856cbf0ae
When stderr does not point to a tty, we typically suppress "we are now in this phase" progress reporting (e.g., we ask the server not to send us "counting objects" and the like). The new "checking connectivity" message is in the same vein, and should be suppressed. Since clone relies on the transport code to make the decision, we can simply sneak a peek at the "progress" field of the transport struct. That properly takes into account both the verbosity and progress options we were given, as well as the result of isatty(). Note that we do not set up that progress flag for a local clone, as we do not fetch using the transport at all. That's acceptable here, though, because we also do not perform a connectivity check in that case. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
38 lines
716 B
Bash
Executable file
38 lines
716 B
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='basic clone options'
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
mkdir parent &&
|
|
(cd parent && git init &&
|
|
echo one >file && git add file &&
|
|
git commit -m one)
|
|
|
|
'
|
|
|
|
test_expect_success 'clone -o' '
|
|
|
|
git clone -o foo parent clone-o &&
|
|
(cd clone-o && git rev-parse --verify refs/remotes/foo/master)
|
|
|
|
'
|
|
|
|
test_expect_success 'redirected clone does not show progress' '
|
|
|
|
git clone "file://$(pwd)/parent" clone-redirected >out 2>err &&
|
|
! grep % err &&
|
|
test_i18ngrep ! "Checking connectivity" err
|
|
|
|
'
|
|
|
|
test_expect_success 'redirected clone -v does show progress' '
|
|
|
|
git clone --progress "file://$(pwd)/parent" clone-redirected-progress \
|
|
>out 2>err &&
|
|
grep % err
|
|
|
|
'
|
|
|
|
test_done
|