Jeff King 1ab03a57e1 shortlog: skip format/parse roundtrip for internal traversal ... The original git-shortlog command parsed the output of git-log, and the logic went something like this: 1. Read stdin looking for "author" lines. 2. Parse the identity into its name/email bits. 3. Apply mailmap to the name/email. 4. Reformat the identity into a single buffer that is our "key" for grouping entries (either a name by default, or "name <email>" if --email was given). The first part happens in read_from_stdin(), and the other three steps are part of insert_one_record(). When we do an internal traversal, we just swap out the stdin read in step 1 for reading the commit objects ourselves. Prior to 2db6b83d18 (shortlog: replace hand-parsing of author with pretty-printer, 2016-01-18), that made sense; we still had to parse the ident in the commit message. But after that commit, we use pretty.c's "%an <%ae>" to get the author ident (for simplicity). Which means that the pretty printer is doing a parse/format under the hood, and then we parse the result, apply the mailmap, and format the result again. Instead, we can just ask pretty.c to do all of those steps for us (including the mailmap via "%aN <%aE>", and not formatting the address when --email is missing). And then we can push steps 2-4 into read_from_stdin(). This speeds up "git shortlog -ns" on linux.git by about 3%, and eliminates a leak in insert_one_record() of the namemailbuf strbuf. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2017-09-09 01:57:03 +09:00
..
add.c	Merge branch 'jk/warn-add-gitlink'	2017-06-24 14:28:41 -07:00
am.c	Merge branch 'ab/free-and-null'	2017-06-24 14:28:41 -07:00
annotate.c
apply.c
archive.c
bisect--helper.c
blame.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
branch.c	ref-filter: consult want_color() before emitting colors	2017-07-13 12:42:51 -07:00
bundle.c	bundle: use prefix_filename with bundle path	2017-03-21 11:18:41 -07:00
cat-file.c	Merge branch 'jt/unify-object-info'	2017-07-05 13:32:57 -07:00
check-attr.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
check-ignore.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
check-mailmap.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
check-ref-format.c
checkout-index.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
checkout.c	Merge branch 'ls/filter-process-delayed' into jt/subprocess-handshake	2017-07-26 12:56:19 -07:00
clean.c	color: check color.ui in git_default_config()	2017-07-13 12:42:51 -07:00
clone.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
column.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
commit-tree.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
commit.c	Merge branch 'ks/commit-abort-on-empty-message-fix' into maint	2017-08-23 14:33:44 -07:00
config.c	Merge branch 'ab/free-and-null'	2017-06-24 14:28:41 -07:00
count-objects.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
credential.c	credential: handle invalid arguments earlier	2017-05-30 14:45:03 +09:00
describe.c	Merge branch 'sb/hashmap-customize-comparison'	2017-07-13 16:14:54 -07:00
diff-files.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
diff-index.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
diff-tree.c	Merge branch 'jc/diff-tree-stale-comment' into maint	2017-06-24 15:29:31 -07:00
diff.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
difftool.c	hashmap.h: compare function has access to a data field	2017-06-30 12:49:28 -07:00
fast-export.c	hashmap.h: compare function has access to a data field	2017-06-30 12:49:28 -07:00
fetch-pack.c	Rename sha1_array to oid_array	2017-03-31 08:33:56 -07:00
fetch.c	Merge branch 'sb/pull-rebase-submodule'	2017-07-13 16:14:54 -07:00
fmt-merge-msg.c	Merge branch 'dc/fmt-merge-msg-microcleanup' into maint	2017-08-23 14:33:52 -07:00
for-each-ref.c	for-each-ref: load config earlier	2017-07-13 12:42:51 -07:00
fsck.c	fsck: cleanup unused variable	2017-07-26 11:36:14 -07:00
gc.c	Merge branch 'jk/gc-pre-detach-under-hook'	2017-07-18 12:48:10 -07:00
get-tar-commit-id.c
grep.c	Merge branch 'jk/ref-filter-colors' into maint	2017-08-23 14:33:42 -07:00
hash-object.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
help.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
index-pack.c	Merge branch 'jt/unify-object-info'	2017-07-05 13:32:57 -07:00
init-db.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
interpret-trailers.c
log.c	Merge branch 'jk/reflog-walk' into maint	2017-08-23 14:33:44 -07:00
ls-files.c	ls-files: don't try to prune an empty index	2017-07-17 14:55:21 -07:00
ls-remote.c	wildmatch: remove unused wildopts parameter	2017-06-23 18:27:07 -07:00
ls-tree.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
mailinfo.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
mailsplit.c	mailinfo & mailsplit: check for EOF while parsing	2017-05-08 12:18:19 +09:00
merge-base.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
merge-file.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
merge-index.c	Convert GIT_SHA1_HEXSZ used for allocation to GIT_MAX_HEXSZ	2017-03-26 22:08:21 -07:00
merge-ours.c
merge-recursive.c
merge-tree.c	Convert lookup_blob to struct object_id	2017-05-08 15:12:57 +09:00
merge.c	use MOVE_ARRAY	2017-07-17 14:54:56 -07:00
mktag.c
mktree.c	mktree: plug memory leaks reported by Coverity	2017-05-08 12:18:19 +09:00
mv.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
name-rev.c	Merge branch 'ab/wildmatch'	2017-07-10 13:42:51 -07:00
notes.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
pack-objects.c	Merge branch 'rs/pack-objects-pbase-cleanup' into maint	2017-08-23 14:33:48 -07:00
pack-redundant.c	pack-redundant: plug memory leak	2017-05-08 12:18:19 +09:00
pack-refs.c	refs: delete pack_refs() in favor of refs_pack_refs()	2017-04-14 03:53:25 -07:00
patch-id.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
prune-packed.c	sha1_file: guard against invalid loose subdirectory numbers	2017-06-24 11:09:52 -07:00
prune.c	Merge branch 'rs/sha1-name-readdir-optim'	2017-07-05 13:32:56 -07:00
pull.c	Merge branch 'sb/pull-rebase-submodule'	2017-07-13 16:14:54 -07:00
push.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
read-tree.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
rebase--helper.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
receive-pack.c	Merge branch 'rs/use-div-round-up'	2017-07-12 15:18:23 -07:00
reflog.c	Merge branch 'ab/wildmatch'	2017-07-10 13:42:51 -07:00
remote-ext.c	remote-{ext,fd}: print usage message on invalid arguments	2017-05-30 14:45:04 +09:00
remote-fd.c	remote-{ext,fd}: print usage message on invalid arguments	2017-05-30 14:45:04 +09:00
remote.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
repack.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
replace.c	Merge branch 'ab/wildmatch'	2017-07-10 13:42:51 -07:00
rerere.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
reset.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
rev-list.c	Merge branch 'jk/reflog-walk' into maint	2017-08-23 14:33:44 -07:00
rev-parse.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
revert.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
rm.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
send-pack.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
shortlog.c	shortlog: skip format/parse roundtrip for internal traversal	2017-09-09 01:57:03 +09:00
show-branch.c	color: check color.ui in git_default_config()	2017-07-13 12:42:51 -07:00
show-ref.c	show-ref: remove a stale comment	2017-01-23 18:51:56 -08:00
stripspace.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
submodule--helper.c	Merge branch 'js/run-process-parallel-api-fix' into maint	2017-08-23 14:33:49 -07:00
symbolic-ref.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
tag.c	ref-filter: provide a function for parsing sort options	2017-07-13 12:42:51 -07:00
unpack-file.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
unpack-objects.c	Merge branch 'ab/free-and-null'	2017-06-24 14:28:41 -07:00
update-index.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
update-ref.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
update-server-info.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
upload-archive.c	upload-archive: handle "-h" option early	2017-05-30 14:45:04 +09:00
var.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
verify-commit.c	Merge branch 'bw/config-h'	2017-06-24 14:28:41 -07:00
verify-pack.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00
verify-tag.c	ref-filter: abstract ref format into its own struct	2017-07-13 12:42:50 -07:00
worktree.c	Merge branch 'ab/free-and-null'	2017-06-24 14:28:41 -07:00
write-tree.c	config: don't include config.h by default	2017-06-15 12:56:22 -07:00