mirror of
https://github.com/git/git.git
synced 2024-11-15 13:43:45 +01:00
17bf4ff3cd
Currently, when no (valid) upstream is configured for a branch, you get an error like: $ git show @{u} error: No upstream configured for branch 'upstream-error' error: No upstream configured for branch 'upstream-error' fatal: ambiguous argument '@{u}': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' The "error: " line actually appears twice, and the rest of the error message is useless. In sha1_name.c:interpret_branch_name(), there is really no point in processing further if @{u} couldn't be resolved, and we might as well die() instead of returning an error(). After making this change, you get: $ git show @{u} fatal: No upstream configured for branch 'upstream-error' Also tweak a few tests in t1507 to expect this output. This only turns error() that may be called after we know we are dealing with an @{upstream} marker into die(), without touching silent error returns "return -1" from the function. Any caller that wants to handle an error condition itself will not be hurt by this change, unless they want to see the message from error() and then exit silently without giving its own message, which needs to be fixed anyway. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
213 lines
5.4 KiB
Bash
Executable file
213 lines
5.4 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test <branch>@{upstream} syntax'
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
test_commit 1 &&
|
|
git checkout -b side &&
|
|
test_commit 2 &&
|
|
git checkout master &&
|
|
git clone . clone &&
|
|
test_commit 3 &&
|
|
(cd clone &&
|
|
test_commit 4 &&
|
|
git branch --track my-side origin/side &&
|
|
git branch --track local-master master &&
|
|
git remote add -t master master-only .. &&
|
|
git fetch master-only &&
|
|
git branch bad-upstream &&
|
|
git config branch.bad-upstream.remote master-only &&
|
|
git config branch.bad-upstream.merge refs/heads/side
|
|
)
|
|
'
|
|
|
|
sq="'"
|
|
|
|
full_name () {
|
|
(cd clone &&
|
|
git rev-parse --symbolic-full-name "$@")
|
|
}
|
|
|
|
commit_subject () {
|
|
(cd clone &&
|
|
git show -s --pretty=format:%s "$@")
|
|
}
|
|
|
|
error_message () {
|
|
(cd clone &&
|
|
test_must_fail git rev-parse --verify "$@")
|
|
}
|
|
|
|
test_expect_success '@{upstream} resolves to correct full name' '
|
|
test refs/remotes/origin/master = "$(full_name @{upstream})"
|
|
'
|
|
|
|
test_expect_success '@{u} resolves to correct full name' '
|
|
test refs/remotes/origin/master = "$(full_name @{u})"
|
|
'
|
|
|
|
test_expect_success 'my-side@{upstream} resolves to correct full name' '
|
|
test refs/remotes/origin/side = "$(full_name my-side@{u})"
|
|
'
|
|
|
|
test_expect_success 'refs/heads/my-side@{upstream} does not resolve to my-side{upstream}' '
|
|
test_must_fail full_name refs/heads/my-side@{upstream}
|
|
'
|
|
|
|
test_expect_success 'my-side@{u} resolves to correct commit' '
|
|
git checkout side &&
|
|
test_commit 5 &&
|
|
(cd clone && git fetch) &&
|
|
test 2 = "$(commit_subject my-side)" &&
|
|
test 5 = "$(commit_subject my-side@{u})"
|
|
'
|
|
|
|
test_expect_success 'not-tracking@{u} fails' '
|
|
test_must_fail full_name non-tracking@{u} &&
|
|
(cd clone && git checkout --no-track -b non-tracking) &&
|
|
test_must_fail full_name non-tracking@{u}
|
|
'
|
|
|
|
test_expect_success '<branch>@{u}@{1} resolves correctly' '
|
|
test_commit 6 &&
|
|
(cd clone && git fetch) &&
|
|
test 5 = $(commit_subject my-side@{u}@{1})
|
|
'
|
|
|
|
test_expect_success '@{u} without specifying branch fails on a detached HEAD' '
|
|
git checkout HEAD^0 &&
|
|
test_must_fail git rev-parse @{u}
|
|
'
|
|
|
|
test_expect_success 'checkout -b new my-side@{u} forks from the same' '
|
|
(
|
|
cd clone &&
|
|
git checkout -b new my-side@{u} &&
|
|
git rev-parse --symbolic-full-name my-side@{u} >expect &&
|
|
git rev-parse --symbolic-full-name new@{u} >actual &&
|
|
test_cmp expect actual
|
|
)
|
|
'
|
|
|
|
test_expect_success 'merge my-side@{u} records the correct name' '
|
|
(
|
|
cd clone || exit
|
|
git checkout master || exit
|
|
git branch -D new ;# can fail but is ok
|
|
git branch -t new my-side@{u} &&
|
|
git merge -s ours new@{u} &&
|
|
git show -s --pretty=format:%s >actual &&
|
|
echo "Merge remote-tracking branch ${sq}origin/side${sq}" >expect &&
|
|
test_cmp expect actual
|
|
)
|
|
'
|
|
|
|
test_expect_success 'branch -d other@{u}' '
|
|
git checkout -t -b other master &&
|
|
git branch -d @{u} &&
|
|
git for-each-ref refs/heads/master >actual &&
|
|
>expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'checkout other@{u}' '
|
|
git branch -f master HEAD &&
|
|
git checkout -t -b another master &&
|
|
git checkout @{u} &&
|
|
git symbolic-ref HEAD >actual &&
|
|
echo refs/heads/master >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'branch@{u} works when tracking a local branch' '
|
|
test refs/heads/master = "$(full_name local-master@{u})"
|
|
'
|
|
|
|
test_expect_success 'branch@{u} error message when no upstream' '
|
|
cat >expect <<-EOF &&
|
|
fatal: No upstream configured for branch ${sq}non-tracking${sq}
|
|
EOF
|
|
error_message non-tracking@{u} 2>actual &&
|
|
test_i18ncmp expect actual
|
|
'
|
|
|
|
test_expect_success '@{u} error message when no upstream' '
|
|
cat >expect <<-EOF &&
|
|
fatal: No upstream configured for branch ${sq}master${sq}
|
|
EOF
|
|
test_must_fail git rev-parse --verify @{u} 2>actual &&
|
|
test_i18ncmp expect actual
|
|
'
|
|
|
|
test_expect_success 'branch@{u} error message with misspelt branch' '
|
|
cat >expect <<-EOF &&
|
|
fatal: No such branch: ${sq}no-such-branch${sq}
|
|
EOF
|
|
error_message no-such-branch@{u} 2>actual &&
|
|
test_i18ncmp expect actual
|
|
'
|
|
|
|
test_expect_success '@{u} error message when not on a branch' '
|
|
cat >expect <<-EOF &&
|
|
fatal: HEAD does not point to a branch
|
|
EOF
|
|
git checkout HEAD^0 &&
|
|
test_must_fail git rev-parse --verify @{u} 2>actual &&
|
|
test_i18ncmp expect actual
|
|
'
|
|
|
|
test_expect_success 'branch@{u} error message if upstream branch not fetched' '
|
|
cat >expect <<-EOF &&
|
|
fatal: Upstream branch ${sq}refs/heads/side${sq} not stored as a remote-tracking branch
|
|
EOF
|
|
error_message bad-upstream@{u} 2>actual &&
|
|
test_i18ncmp expect actual
|
|
'
|
|
|
|
test_expect_success 'pull works when tracking a local branch' '
|
|
(
|
|
cd clone &&
|
|
git checkout local-master &&
|
|
git pull
|
|
)
|
|
'
|
|
|
|
# makes sense if the previous one succeeded
|
|
test_expect_success '@{u} works when tracking a local branch' '
|
|
test refs/heads/master = "$(full_name @{u})"
|
|
'
|
|
|
|
cat >expect <<EOF
|
|
commit 8f489d01d0cc65c3b0f09504ec50b5ed02a70bd5
|
|
Reflog: master@{0} (C O Mitter <committer@example.com>)
|
|
Reflog message: branch: Created from HEAD
|
|
Author: A U Thor <author@example.com>
|
|
Date: Thu Apr 7 15:15:13 2005 -0700
|
|
|
|
3
|
|
EOF
|
|
test_expect_success 'log -g other@{u}' '
|
|
git log -1 -g other@{u} >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<EOF
|
|
commit 8f489d01d0cc65c3b0f09504ec50b5ed02a70bd5
|
|
Reflog: master@{Thu Apr 7 15:17:13 2005 -0700} (C O Mitter <committer@example.com>)
|
|
Reflog message: branch: Created from HEAD
|
|
Author: A U Thor <author@example.com>
|
|
Date: Thu Apr 7 15:15:13 2005 -0700
|
|
|
|
3
|
|
EOF
|
|
|
|
test_expect_success 'log -g other@{u}@{now}' '
|
|
git log -1 -g other@{u}@{now} >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|