mirror of
https://github.com/git/git.git
synced 2024-10-28 12:59:41 +01:00
4119fc08e2
Users can pass patterns to git-ls-remote(1), which allows them to filter the list of printed references. We assemble those patterns into an array and prefix them with "*/", but never free either the array nor the allocated strings. Refactor the code to use a `struct strvec` instead of manually tracking the strings in an array. Like this, we can easily use `strvec_clear()` to release both the vector and the contained string for us, plugging the leak. Helped-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
43 lines
1.1 KiB
Bash
Executable file
43 lines
1.1 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='avoiding conflicting update through symref aliasing'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
test_commit one &&
|
|
git clone . src &&
|
|
git clone src dst1 &&
|
|
git clone src dst2 &&
|
|
test_commit two &&
|
|
( cd src && git pull )
|
|
'
|
|
|
|
test_expect_success 'push' '
|
|
(
|
|
cd src &&
|
|
git push ../dst1 "refs/remotes/*:refs/remotes/*"
|
|
) &&
|
|
git ls-remote src "refs/remotes/*" >expect &&
|
|
git ls-remote dst1 "refs/remotes/*" >actual &&
|
|
test_cmp expect actual &&
|
|
( cd src && git symbolic-ref refs/remotes/origin/HEAD ) >expect &&
|
|
( cd dst1 && git symbolic-ref refs/remotes/origin/HEAD ) >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'fetch' '
|
|
(
|
|
cd dst2 &&
|
|
git fetch ../src "refs/remotes/*:refs/remotes/*"
|
|
) &&
|
|
git ls-remote src "refs/remotes/*" >expect &&
|
|
git ls-remote dst2 "refs/remotes/*" >actual &&
|
|
test_cmp expect actual &&
|
|
( cd src && git symbolic-ref refs/remotes/origin/HEAD ) >expect &&
|
|
( cd dst2 && git symbolic-ref refs/remotes/origin/HEAD ) >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|