mirror of
https://github.com/git/git.git
synced 2024-11-19 15:34:51 +01:00
f69e836fab
This fixes the remainder of the issues where the test script itself is at fault for failing when the git checkout path contains whitespace or other shell metacharacters. The majority of git svn tests used the idiom test_expect_success "title" "test script using $svnrepo" These were changed to have the test script in single-quotes: test_expect_success "title" 'test script using "$svnrepo"' which unfortunately makes the patch appear larger than it really is. One consequence of this change is that in the verbose test output the value of $svnrepo (and in some cases other variables, too) is no longer expanded, i.e. previously we saw * expecting success: test script using /path/to/git/t/trash/svnrepo but now it is: * expecting success: test script using "$svnrepo" Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
40 lines
1 KiB
Bash
Executable file
40 lines
1 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 Eric Wong
|
|
#
|
|
|
|
# Don't run this test by default unless the user really wants it
|
|
# I don't like the idea of taking a port and possibly leaving a
|
|
# daemon running on a users system if the test fails.
|
|
# Not all git users will need to interact with SVN.
|
|
test -z "$SVNSERVE_PORT" && exit 0
|
|
|
|
test_description='git-svn dcommit new files over svn:// test'
|
|
|
|
. ./lib-git-svn.sh
|
|
|
|
start_svnserve () {
|
|
svnserve --listen-port $SVNSERVE_PORT \
|
|
--root "$rawsvnrepo" \
|
|
--listen-once \
|
|
--listen-host 127.0.0.1 &
|
|
}
|
|
|
|
test_expect_success 'start tracking an empty repo' '
|
|
svn mkdir -m "empty dir" "$svnrepo"/empty-dir &&
|
|
echo anon-access = write >> "$rawsvnrepo"/conf/svnserve.conf &&
|
|
start_svnserve &&
|
|
git svn init svn://127.0.0.1:$SVNSERVE_PORT &&
|
|
git svn fetch
|
|
'
|
|
|
|
test_expect_success 'create files in new directory with dcommit' "
|
|
mkdir git-new-dir &&
|
|
echo hello > git-new-dir/world &&
|
|
git update-index --add git-new-dir/world &&
|
|
git commit -m hello &&
|
|
start_svnserve &&
|
|
git svn dcommit
|
|
"
|
|
|
|
test_done
|