mirror of
https://github.com/git/git.git
synced 2024-11-01 06:47:52 +01:00
1c5e94f459
Using 'test_must_be_empty' is shorter and more idiomatic than
>empty &&
test_cmp empty out
as it saves the creation of an empty file. Furthermore, sometimes the
expected empty file doesn't have such a descriptive name like 'empty',
and its creation is far away from the place where it's finally used
for comparison (e.g. in 't7600-merge.sh', where two expected empty
files are created in the 'setup' test, but are used only about 500
lines later).
These cases were found by instrumenting 'test_cmp' to error out the
test script when it's used to compare empty files, and then converted
manually.
Note that even after this patch there still remain a lot of cases
where we use 'test_cmp' to check empty files:
- Sometimes the expected output is not hard-coded in the test, but
'test_cmp' is used to ensure that two similar git commands produce
the same output, and that output happens to be empty, e.g. the
test 'submodule update --merge - ignores --merge for new
submodules' in 't7406-submodule-update.sh'.
- Repetitive common tasks, including preparing the expected results
and running 'test_cmp', are often extracted into a helper
function, and some of this helper's callsites expect no output.
- For the same reason as above, the whole 'test_expect_success'
block is within a helper function, e.g. in 't3070-wildmatch.sh'.
- Or 'test_cmp' is invoked in a loop, e.g. the test 'cvs update
(-p)' in 't9400-git-cvsserver-server.sh'.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
54 lines
1.2 KiB
Bash
Executable file
54 lines
1.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='basic ls-files tests
|
|
|
|
This test runs git ls-files with various unusual or malformed
|
|
command-line arguments.
|
|
'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'ls-files in empty repository' '
|
|
git ls-files >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'ls-files with nonexistent path' '
|
|
git ls-files doesnotexist >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'ls-files with nonsense option' '
|
|
test_expect_code 129 git ls-files --nonsense 2>actual &&
|
|
test_i18ngrep "[Uu]sage: git ls-files" actual
|
|
'
|
|
|
|
test_expect_success 'ls-files -h in corrupt repository' '
|
|
mkdir broken &&
|
|
(
|
|
cd broken &&
|
|
git init &&
|
|
>.git/index &&
|
|
test_expect_code 129 git ls-files -h >usage 2>&1
|
|
) &&
|
|
test_i18ngrep "[Uu]sage: git ls-files " broken/usage
|
|
'
|
|
|
|
test_expect_success SYMLINKS 'ls-files with absolute paths to symlinks' '
|
|
mkdir subs &&
|
|
ln -s nosuch link &&
|
|
ln -s ../nosuch subs/link &&
|
|
git add link subs/link &&
|
|
git ls-files -s link subs/link >expect &&
|
|
git ls-files -s "$(pwd)/link" "$(pwd)/subs/link" >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
(
|
|
cd subs &&
|
|
git ls-files -s link >../expect &&
|
|
git ls-files -s "$(pwd)/link" >../actual
|
|
) &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|