mirror of
https://github.com/git/git.git
synced 2024-10-30 05:47:53 +01:00
4828ce9871
We can't create a pack revindex if we haven't actually looked at the index. Normally we would never get as far as creating a revindex without having already been looking in the pack, so this code never bothered to double-check that pack->index_data had been loaded. But with the new multi-pack-index feature, many code paths might not load the individual pack .idx at all (they'd find objects via the midx and then open the .pack, but not its index). This can't yet be triggered in practice, because a bug in the midx code means we accidentally open up the individual .idx files anyway. But in preparation for fixing that, let's have the revindex code check that everything it needs has been loaded. In most cases this will just be a quick noop. But note that this does introduce a possibility of error (if we have to open the index and it's corrupt), so load_pack_revindex() now returns a result code, and callers need to handle the error. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
16 lines
322 B
C
16 lines
322 B
C
#ifndef PACK_REVINDEX_H
|
|
#define PACK_REVINDEX_H
|
|
|
|
struct packed_git;
|
|
|
|
struct revindex_entry {
|
|
off_t offset;
|
|
unsigned int nr;
|
|
};
|
|
|
|
int load_pack_revindex(struct packed_git *p);
|
|
int find_revindex_position(struct packed_git *p, off_t ofs);
|
|
|
|
struct revindex_entry *find_pack_revindex(struct packed_git *p, off_t ofs);
|
|
|
|
#endif
|