mirror of
https://github.com/git/git.git
synced 2024-11-14 21:23:03 +01:00
b09d8552bd
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
34 lines
590 B
Bash
Executable file
34 lines
590 B
Bash
Executable file
#!/bin/sh
|
|
|
|
{
|
|
cat <<\EOF
|
|
sayIt:
|
|
$(foreach b,$(BUILT_INS),echo XXX $b YYY;)
|
|
EOF
|
|
cat Makefile
|
|
} |
|
|
make -f - sayIt 2>/dev/null |
|
|
sed -n -e 's/.*XXX \(.*\) YYY.*/\1/p' |
|
|
sort |
|
|
{
|
|
bad=0
|
|
while read builtin
|
|
do
|
|
base=$(expr "$builtin" : 'git-\(.*\)')
|
|
x=$(sed -ne 's/.*{ "'$base'", \(cmd_[^, ]*\).*/'$base' \1/p' git.c)
|
|
if test -z "$x"
|
|
then
|
|
echo "$base is builtin but not listed in git.c command list"
|
|
bad=1
|
|
fi
|
|
for sfx in sh perl py
|
|
do
|
|
if test -f "$builtin.$sfx"
|
|
then
|
|
echo "$base is builtin but $builtin.$sfx still exists"
|
|
bad=1
|
|
fi
|
|
done
|
|
done
|
|
exit $bad
|
|
}
|