mirror of
https://github.com/git/git.git
synced 2024-10-30 13:57:54 +01:00
a902618792
Since86ac751(Allow cloning an empty repository, 2009-01-23), doing: git clone does-not-exist has created does-not-exist as an empty repository. This was an unintentional side effect of86ac751. Even weirder, doing: git clone does-not-exist new-dir _does_ fail, making this "feature" (if you want to consider it such) broken. Let's detect this situation and explicitly die. It's almost certainly not what the user intended. This patch also adds two tests. One for the missing path case, and one to confirm that a similar case, cloning a non-repository directory, fails. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
160 lines
3.4 KiB
Bash
Executable file
160 lines
3.4 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test local clone'
|
|
. ./test-lib.sh
|
|
|
|
D=`pwd`
|
|
|
|
test_expect_success 'preparing origin repository' '
|
|
: >file && git add . && git commit -m1 &&
|
|
git clone --bare . a.git &&
|
|
git clone --bare . x &&
|
|
test "$(GIT_CONFIG=a.git/config git config --bool core.bare)" = true &&
|
|
test "$(GIT_CONFIG=x/config git config --bool core.bare)" = true &&
|
|
git bundle create b1.bundle --all &&
|
|
git bundle create b2.bundle master &&
|
|
mkdir dir &&
|
|
cp b1.bundle dir/b3 &&
|
|
cp b1.bundle b4
|
|
'
|
|
|
|
test_expect_success 'local clone without .git suffix' '
|
|
cd "$D" &&
|
|
git clone -l -s a b &&
|
|
cd b &&
|
|
test "$(GIT_CONFIG=.git/config git config --bool core.bare)" = false &&
|
|
git fetch
|
|
'
|
|
|
|
test_expect_success 'local clone with .git suffix' '
|
|
cd "$D" &&
|
|
git clone -l -s a.git c &&
|
|
cd c &&
|
|
git fetch
|
|
'
|
|
|
|
test_expect_success 'local clone from x' '
|
|
cd "$D" &&
|
|
git clone -l -s x y &&
|
|
cd y &&
|
|
git fetch
|
|
'
|
|
|
|
test_expect_success 'local clone from x.git that does not exist' '
|
|
cd "$D" &&
|
|
if git clone -l -s x.git z
|
|
then
|
|
echo "Oops, should have failed"
|
|
false
|
|
else
|
|
echo happy
|
|
fi
|
|
'
|
|
|
|
test_expect_success 'With -no-hardlinks, local will make a copy' '
|
|
cd "$D" &&
|
|
git clone --bare --no-hardlinks x w &&
|
|
cd w &&
|
|
linked=$(find objects -type f ! -links 1 | wc -l) &&
|
|
test 0 = $linked
|
|
'
|
|
|
|
test_expect_success 'Even without -l, local will make a hardlink' '
|
|
cd "$D" &&
|
|
rm -fr w &&
|
|
git clone -l --bare x w &&
|
|
cd w &&
|
|
copied=$(find objects -type f -links 1 | wc -l) &&
|
|
test 0 = $copied
|
|
'
|
|
|
|
test_expect_success 'local clone of repo with nonexistent ref in HEAD' '
|
|
cd "$D" &&
|
|
echo "ref: refs/heads/nonexistent" > a.git/HEAD &&
|
|
git clone a d &&
|
|
cd d &&
|
|
git fetch &&
|
|
test ! -e .git/refs/remotes/origin/HEAD'
|
|
|
|
test_expect_success 'bundle clone without .bundle suffix' '
|
|
cd "$D" &&
|
|
git clone dir/b3 &&
|
|
cd b3 &&
|
|
git fetch
|
|
'
|
|
|
|
test_expect_success 'bundle clone with .bundle suffix' '
|
|
cd "$D" &&
|
|
git clone b1.bundle &&
|
|
cd b1 &&
|
|
git fetch
|
|
'
|
|
|
|
test_expect_success 'bundle clone from b4' '
|
|
cd "$D" &&
|
|
git clone b4 bdl &&
|
|
cd bdl &&
|
|
git fetch
|
|
'
|
|
|
|
test_expect_success 'bundle clone from b4.bundle that does not exist' '
|
|
cd "$D" &&
|
|
if git clone b4.bundle bb
|
|
then
|
|
echo "Oops, should have failed"
|
|
false
|
|
else
|
|
echo happy
|
|
fi
|
|
'
|
|
|
|
test_expect_success 'bundle clone with nonexistent HEAD' '
|
|
cd "$D" &&
|
|
git clone b2.bundle b2 &&
|
|
cd b2 &&
|
|
git fetch &&
|
|
test ! -e .git/refs/heads/master
|
|
'
|
|
|
|
test_expect_success 'clone empty repository' '
|
|
cd "$D" &&
|
|
mkdir empty &&
|
|
(cd empty &&
|
|
git init &&
|
|
git config receive.denyCurrentBranch warn) &&
|
|
git clone empty empty-clone &&
|
|
test_tick &&
|
|
(cd empty-clone
|
|
echo "content" >> foo &&
|
|
git add foo &&
|
|
git commit -m "Initial commit" &&
|
|
git push origin master &&
|
|
expected=$(git rev-parse master) &&
|
|
actual=$(git --git-dir=../empty/.git rev-parse master) &&
|
|
test $actual = $expected)
|
|
'
|
|
|
|
test_expect_success 'clone empty repository, and then push should not segfault.' '
|
|
cd "$D" &&
|
|
rm -fr empty/ empty-clone/ &&
|
|
mkdir empty &&
|
|
(cd empty && git init) &&
|
|
git clone empty empty-clone &&
|
|
(cd empty-clone &&
|
|
test_must_fail git push)
|
|
'
|
|
|
|
test_expect_success 'cloning non-existent directory fails' '
|
|
cd "$D" &&
|
|
rm -rf does-not-exist &&
|
|
test_must_fail git clone does-not-exist
|
|
'
|
|
|
|
test_expect_success 'cloning non-git directory fails' '
|
|
cd "$D" &&
|
|
rm -rf not-a-git-repo not-a-git-repo-clone &&
|
|
mkdir not-a-git-repo &&
|
|
test_must_fail git clone not-a-git-repo not-a-git-repo-clone
|
|
'
|
|
|
|
test_done
|