mirror of
https://github.com/git/git.git
synced 2024-11-16 22:14:53 +01:00
6de040df56
git-p4 used to simply pass strings into system() and popen(), and relied on the shell doing the necessary expansion. This though meant that shell metacharacters in file names would be corrupted - for example files with $ or space in them. Switch to using subprocess.Popen() and friends, and pass in explicit arrays in the places where it matters. This then avoids needing shell expansion. Add trivial helper functions for some common perforce operations. Add test case. [pw: test cleanup] Signed-off-by: Luke Diamand <luke@diamand.org> Signed-off-by: Pete Wyckoff <pw@padd.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
64 lines
1.2 KiB
Bash
Executable file
64 lines
1.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git-p4 transparency to shell metachars in filenames'
|
|
|
|
. ./lib-git-p4.sh
|
|
|
|
test_expect_success 'start p4d' '
|
|
start_p4d
|
|
'
|
|
|
|
test_expect_success 'init depot' '
|
|
(
|
|
cd "$cli" &&
|
|
echo file1 >file1 &&
|
|
p4 add file1 &&
|
|
p4 submit -d "file1"
|
|
)
|
|
'
|
|
|
|
test_expect_success 'shell metachars in filenames' '
|
|
"$GITP4" clone --dest="$git" //depot &&
|
|
test_when_finished cleanup_git &&
|
|
(
|
|
cd "$git" &&
|
|
git config git-p4.skipSubmitEditCheck true &&
|
|
echo f1 >foo\$bar &&
|
|
git add foo\$bar &&
|
|
echo f2 >"file with spaces" &&
|
|
git add "file with spaces" &&
|
|
git commit -m "add files" &&
|
|
P4EDITOR=touch "$GITP4" submit
|
|
) &&
|
|
(
|
|
cd "$cli" &&
|
|
p4 sync ... &&
|
|
test -e "file with spaces" &&
|
|
test -e "foo\$bar"
|
|
)
|
|
'
|
|
|
|
test_expect_success 'deleting with shell metachars' '
|
|
"$GITP4" clone --dest="$git" //depot &&
|
|
test_when_finished cleanup_git &&
|
|
(
|
|
cd "$git" &&
|
|
git config git-p4.skipSubmitEditCheck true &&
|
|
git rm foo\$bar &&
|
|
git rm file\ with\ spaces &&
|
|
git commit -m "remove files" &&
|
|
P4EDITOR=touch "$GITP4" submit
|
|
) &&
|
|
(
|
|
cd "$cli" &&
|
|
p4 sync ... &&
|
|
test ! -e "file with spaces" &&
|
|
test ! -e foo\$bar
|
|
)
|
|
'
|
|
|
|
test_expect_success 'kill p4d' '
|
|
kill_p4d
|
|
'
|
|
|
|
test_done
|