mirror of
https://github.com/git/git.git
synced 2024-11-14 13:13:01 +01:00
41ac414ea2
Originally, test_expect_failure was designed to be the opposite
of test_expect_success, but this was a bad decision. Most tests
run a series of commands that leads to the single command that
needs to be tested, like this:
test_expect_{success,failure} 'test title' '
setup1 &&
setup2 &&
setup3 &&
what is to be tested
'
And expecting a failure exit from the whole sequence misses the
point of writing tests. Your setup$N that are supposed to
succeed may have failed without even reaching what you are
trying to test. The only valid use of test_expect_failure is to
check a trivial single command that is expected to fail, which
is a minority in tests of Porcelain-ish commands.
This large-ish patch rewrites all uses of test_expect_failure to
use test_expect_success and rewrites the condition of what is
tested, like this:
test_expect_success 'test title' '
setup1 &&
setup2 &&
setup3 &&
! this command should fail
'
test_expect_failure is redefined to serve as a reminder that
that test *should* succeed but due to a known breakage in git it
currently does not pass. So if git-foo command should create a
file 'bar' but you discovered a bug that it doesn't, you can
write a test like this:
test_expect_failure 'git-foo should create bar' '
rm -f bar &&
git foo &&
test -f bar
'
This construct acts similar to test_expect_success, but instead
of reporting "ok/FAIL" like test_expect_success does, the
outcome is reported as "FIXED/still broken".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
33 lines
742 B
Bash
Executable file
33 lines
742 B
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2005 Junio C Hamano
|
|
#
|
|
|
|
test_description='git checkout-index -u test.
|
|
|
|
With -u flag, git checkout-index internally runs the equivalent of
|
|
git update-index --refresh on the checked out entry.'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success \
|
|
'preparation' '
|
|
echo frotz >path0 &&
|
|
git update-index --add path0 &&
|
|
t=$(git write-tree)'
|
|
|
|
test_expect_success \
|
|
'without -u, git checkout-index smudges stat information.' '
|
|
rm -f path0 &&
|
|
git read-tree $t &&
|
|
git checkout-index -f -a &&
|
|
! git diff-files | diff - /dev/null'
|
|
|
|
test_expect_success \
|
|
'with -u, git checkout-index picks up stat information from new files.' '
|
|
rm -f path0 &&
|
|
git read-tree $t &&
|
|
git checkout-index -u -f -a &&
|
|
git diff-files | diff - /dev/null'
|
|
|
|
test_done
|