mirror of
https://github.com/git/git.git
synced 2024-10-30 05:47:53 +01:00
b6c4380d6e
When we allocate the test_entry flex-struct, we have to add up all of the elements that go into the flex array. If these were to overflow a size_t, this would allocate a too-small buffer, which we would then overflow in our memcpy steps. Since this is just a test-helper, it probably doesn't matter in practice, but we should model the correct technique by using the st_add() macros. Unfortunately, we cannot use the FLEX_ALLOC() macros here, because we are stuffing two different buffers into a single flex array. While we're here, let's also swap out "malloc" for our error-checking "xmalloc", and use the preferred "sizeof(*var)" instead of "sizeof(type)". Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| test-chmtime.c | ||
| test-config.c | ||
| test-ctype.c | ||
| test-date.c | ||
| test-delta.c | ||
| test-dump-cache-tree.c | ||
| test-dump-split-index.c | ||
| test-dump-untracked-cache.c | ||
| test-fake-ssh.c | ||
| test-genrandom.c | ||
| test-hashmap.c | ||
| test-index-version.c | ||
| test-lazy-init-name-hash.c | ||
| test-line-buffer.c | ||
| test-match-trees.c | ||
| test-mergesort.c | ||
| test-mktemp.c | ||
| test-online-cpus.c | ||
| test-parse-options.c | ||
| test-path-utils.c | ||
| test-prio-queue.c | ||
| test-read-cache.c | ||
| test-ref-store.c | ||
| test-regex.c | ||
| test-revision-walking.c | ||
| test-run-command.c | ||
| test-scrap-cache-tree.c | ||
| test-sha1-array.c | ||
| test-sha1.c | ||
| test-sha1.sh | ||
| test-sigchain.c | ||
| test-strcmp-offset.c | ||
| test-string-list.c | ||
| test-submodule-config.c | ||
| test-subprocess.c | ||
| test-svn-fe.c | ||
| test-urlmatch-normalization.c | ||
| test-wildmatch.c | ||
| test-write-cache.c | ||