mirror of
https://github.com/git/git.git
synced 2024-11-16 06:03:44 +01:00
fe191fcaa5
git-svn by default puts its Subversion-tracking refs directly in refs/remotes/*. This runs counter to Git's convention of using refs/remotes/$remote/* for storing remote-tracking branches. Furthermore, combining git-svn with regular git remotes run the risk of clobbering refs under refs/remotes (e.g. if you have a git remote called "tags" with a "v1" branch, it will overlap with the git-svn's tracking branch for the "v1" tag from Subversion. Even though the git-svn refs stored in refs/remotes/* are not "proper" remote-tracking branches (since they are not covered by a proper git remote's refspec), they clearly represent a similar concept, and would benefit from following the same convention. For example, if git-svn tracks Subversion branch "foo" at refs/remotes/foo, and you create a local branch refs/heads/foo to add some commits to be pushed back to Subversion (using "git svn dcommit), then it is clearly unhelpful of Git to throw warning: refname 'foo' is ambiguous. every time you checkout, rebase, or otherwise interact with the branch. The existing workaround for this is to supply the --prefix=quux/ to git svn init/clone, so that git-svn's tracking branches end up in refs/remotes/quux/* instead of refs/remotes/*. However, encouraging users to specify --prefix to work around a design flaw in git-svn is suboptimal, and not a long term solution to the problem. Instead, git-svn should default to use a non-empty prefix that saves unsuspecting users from the inconveniences described above. This patch will only affect newly created git-svn setups, as the --prefix option only applies to git svn init (and git svn clone). Existing git-svn setups will continue with their existing (lack of) prefix. Also, if anyone somehow prefers git-svn's old layout, they can recreate that by explicitly passing an empty prefix (--prefix "") on the git svn init/clone command line. The patch changes the default value for --prefix from "" to "origin/", updates the git-svn manual page, and fixes the fallout in the git-svn testcases. (Note that this patch might be easier to review using the --word-diff and --word-diff-regex=. diff options.) [ew: squashed description of <= 1.9 behavior into manpage] Suggested-by: Thomas Ferris Nicolaisen <tfnico@gmail.com> Signed-off-by: Johan Herland <johan@herland.net> Signed-off-by: Eric Wong <normalperson@yhbt.net>
122 lines
3.1 KiB
Bash
Executable file
122 lines
3.1 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 Eric Wong
|
|
#
|
|
|
|
test_description='git svn init/clone tests'
|
|
|
|
. ./lib-git-svn.sh
|
|
|
|
# setup, run inside tmp so we don't have any conflicts with $svnrepo
|
|
set -e
|
|
rm -r .git
|
|
mkdir tmp
|
|
cd tmp
|
|
|
|
test_expect_success 'setup svnrepo' '
|
|
mkdir project project/trunk project/branches project/tags &&
|
|
echo foo > project/trunk/foo &&
|
|
svn_cmd import -m "$test_description" project "$svnrepo"/project &&
|
|
rm -rf project
|
|
'
|
|
|
|
test_expect_success 'basic clone' '
|
|
test ! -d trunk &&
|
|
git svn clone "$svnrepo"/project/trunk &&
|
|
test -d trunk/.git/svn &&
|
|
test -e trunk/foo &&
|
|
rm -rf trunk
|
|
'
|
|
|
|
test_expect_success 'clone to target directory' '
|
|
test ! -d target &&
|
|
git svn clone "$svnrepo"/project/trunk target &&
|
|
test -d target/.git/svn &&
|
|
test -e target/foo &&
|
|
rm -rf target
|
|
'
|
|
|
|
test_expect_success 'clone with --stdlayout' '
|
|
test ! -d project &&
|
|
git svn clone -s "$svnrepo"/project &&
|
|
test -d project/.git/svn &&
|
|
test -e project/foo &&
|
|
rm -rf project
|
|
'
|
|
|
|
test_expect_success 'clone to target directory with --stdlayout' '
|
|
test ! -d target &&
|
|
git svn clone -s "$svnrepo"/project target &&
|
|
test -d target/.git/svn &&
|
|
test -e target/foo &&
|
|
rm -rf target
|
|
'
|
|
|
|
test_expect_success 'init without -s/-T/-b/-t does not warn' '
|
|
test ! -d trunk &&
|
|
git svn init "$svnrepo"/project/trunk trunk 2>warning &&
|
|
test_must_fail grep -q prefix warning &&
|
|
rm -rf trunk &&
|
|
rm -f warning
|
|
'
|
|
|
|
test_expect_success 'clone without -s/-T/-b/-t does not warn' '
|
|
test ! -d trunk &&
|
|
git svn clone "$svnrepo"/project/trunk 2>warning &&
|
|
test_must_fail grep -q prefix warning &&
|
|
rm -rf trunk &&
|
|
rm -f warning
|
|
'
|
|
|
|
test_svn_configured_prefix () {
|
|
prefix=$1 &&
|
|
cat >expect <<EOF &&
|
|
project/trunk:refs/remotes/${prefix}trunk
|
|
project/branches/*:refs/remotes/${prefix}*
|
|
project/tags/*:refs/remotes/${prefix}tags/*
|
|
EOF
|
|
test ! -f actual &&
|
|
git --git-dir=project/.git config svn-remote.svn.fetch >>actual &&
|
|
git --git-dir=project/.git config svn-remote.svn.branches >>actual &&
|
|
git --git-dir=project/.git config svn-remote.svn.tags >>actual &&
|
|
test_cmp expect actual &&
|
|
rm -f expect actual
|
|
}
|
|
|
|
test_expect_success 'init with -s/-T/-b/-t assumes --prefix=origin/' '
|
|
test ! -d project &&
|
|
git svn init -s "$svnrepo"/project project 2>warning &&
|
|
test_must_fail grep -q prefix warning &&
|
|
test_svn_configured_prefix "origin/" &&
|
|
rm -rf project &&
|
|
rm -f warning
|
|
'
|
|
|
|
test_expect_success 'clone with -s/-T/-b/-t assumes --prefix=origin/' '
|
|
test ! -d project &&
|
|
git svn clone -s "$svnrepo"/project 2>warning &&
|
|
test_must_fail grep -q prefix warning &&
|
|
test_svn_configured_prefix "origin/" &&
|
|
rm -rf project &&
|
|
rm -f warning
|
|
'
|
|
|
|
test_expect_success 'init with -s/-T/-b/-t and --prefix="" still works' '
|
|
test ! -d project &&
|
|
git svn init -s "$svnrepo"/project project --prefix="" 2>warning &&
|
|
test_must_fail grep -q prefix warning &&
|
|
test_svn_configured_prefix "" &&
|
|
rm -rf project &&
|
|
rm -f warning
|
|
'
|
|
|
|
test_expect_success 'clone with -s/-T/-b/-t and --prefix="" still works' '
|
|
test ! -d project &&
|
|
git svn clone -s "$svnrepo"/project --prefix="" 2>warning &&
|
|
test_must_fail grep -q prefix warning &&
|
|
test_svn_configured_prefix "" &&
|
|
rm -rf project &&
|
|
rm -f warning
|
|
'
|
|
|
|
test_done
|