Jeff King be5c9fb904 logmsg_reencode: lazily load missing commit buffers ... Usually a commit that makes it to logmsg_reencode will have been parsed, and the commit->buffer struct member will be valid. However, some code paths will free commit buffers after having used them (for example, the log traversal machinery will do so to keep memory usage down). Most of the time this is fine; log should only show a commit once, and then exits. However, there are some code paths where this does not work. At least two are known: 1. A commit may be shown as part of a regular ref, and then it may be shown again as part of a submodule diff (e.g., if a repo contains refs to both the superproject and subproject). 2. A notes-cache commit may be shown during "log --all", and then later used to access a textconv cache during a diff. Lazily loading in logmsg_reencode does not necessarily catch all such cases, but it should catch most of them. Users of the commit buffer tend to be either parsing for structure (in which they will call parse_commit, and either we will already have parsed, or we will load commit->buffer lazily there), or outputting (either to the user, or fetching a part of the commit message via format_commit_message). In the latter case, we should always be using logmsg_reencode anyway (and typically we do so via the pretty-print machinery). If there are any cases that this misses, we can fix them up to use logmsg_reencode (or handle them on a case-by-case basis if that is inappropriate). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2013-01-26 13:28:22 -08:00
..
add.c	Merge branch 'as/check-ignore'	2013-01-23 21:19:10 -08:00
annotate.c
apply.c	Merge branch 'jc/apply-trailing-blank-removal'	2013-01-06 22:10:23 -08:00
archive.c	Reduce translations by using same terminologies	2012-08-22 12:02:28 -07:00
bisect--helper.c	i18n: bisect--helper: mark parseopt strings for translation	2012-08-20 12:23:15 -07:00
blame.c	logmsg_reencode: lazily load missing commit buffers	2013-01-26 13:28:22 -08:00
branch.c	Merge branch 'nd/maint-branch-desc-doc'	2013-01-09 08:27:09 -08:00
bundle.c
cat-file.c	Merge branch 'maint-1.7.11' into maint	2012-09-10 15:31:06 -07:00
check-attr.c	Merge branch 'maint'	2012-09-17 15:59:34 -07:00
check-ignore.c	add git-check-ignore sub-command	2013-01-06 14:26:38 -08:00
check-ref-format.c
checkout-index.c	Use imperative form in help usage to describe an action	2012-08-22 12:02:28 -07:00
checkout.c	checkout: print a message when switching unborn branches	2012-11-15 17:36:26 -08:00
clean.c	Merge branch 'as/check-ignore'	2013-01-23 21:19:10 -08:00
clone.c	Merge branch 'nd/clone-no-separate-git-dir-with-bare'	2013-01-21 20:15:08 -08:00
column.c	i18n: column: mark parseopt strings for translation	2012-08-20 12:23:16 -07:00
commit-tree.c	Merge branch 'kk/maint-commit-tree'	2012-07-23 20:55:54 -07:00
commit.c	logmsg_reencode: never return NULL	2013-01-26 13:28:21 -08:00
config.c	Merge branch 'cn/config-missing-path' into maint	2012-11-25 18:35:46 -08:00
count-objects.c	i18n: count-objects: mark parseopt strings for translation	2012-08-20 12:23:16 -07:00
credential.c
describe.c	Merge branch 'jk/peel-ref'	2012-10-25 06:42:27 -04:00
diff-files.c
diff-index.c	update-index/diff-index: use core.preloadindex to improve performance	2012-11-02 11:38:29 -04:00
diff-tree.c
diff.c	Merge branch 'kb/preload-index-more'	2012-11-20 10:32:10 -08:00
fast-export.c	fast-export: make sure updated refs get updated	2012-12-03 09:57:16 -08:00
fetch-pack.c	fetch-pack: move core code to libgit.a	2012-10-29 03:40:29 -04:00
fetch.c	Merge branch 'dj/fetch-all-tags' into maint	2012-09-24 12:39:21 -07:00
fmt-merge-msg.c	Merge branch 'jc/maint-fmt-merge-msg-no-edit-lose-credit'	2013-01-10 13:46:29 -08:00
for-each-ref.c	Merge branch 'nd/i18n-parseopt-help'	2012-09-07 11:09:09 -07:00
fsck.c	i18n: fsck: mark parseopt strings for translation	2012-08-20 12:23:17 -07:00
gc.c	silence git gc --auto --quiet output	2012-09-27 17:57:26 -07:00
grep.c	Merge branch 'nd/grep-true-path' into maint	2012-11-18 19:32:30 -08:00
hash-object.c	i18n: hash-object: mark parseopt strings for translation	2012-08-20 12:23:17 -07:00
help.c	i18n: help: mark parseopt strings for translation	2012-08-20 12:23:17 -07:00
index-pack.c	i18n: mark more index-pack strings for translation	2012-08-31 13:05:05 -07:00
init-db.c	i18n: init-db: mark parseopt strings for translation	2012-08-20 12:23:17 -07:00
log.c	Merge branch 'ap/log-mailmap'	2013-01-20 17:06:53 -08:00
ls-files.c	Merge branch 'as/check-ignore'	2013-01-23 21:19:10 -08:00
ls-remote.c	ls-remote: document the '--get-url' option	2012-09-07 10:58:35 -07:00
ls-tree.c	pathspec: save the non-wildcard length part	2012-11-19 13:08:28 -08:00
mailinfo.c	Merge branch 'jc/same-encoding' into maint	2012-12-07 14:10:56 -08:00
mailsplit.c
merge-base.c	Merge branch 'jc/merge-bases'	2012-09-11 11:36:05 -07:00
merge-file.c	i18n: merge-file: mark parseopt strings for translation	2012-08-20 12:23:18 -07:00
merge-index.c	Which merge_file() function do you mean?	2012-12-09 23:05:27 -08:00
merge-ours.c
merge-recursive.c
merge-tree.c	merge-tree: fix d/f conflicts	2012-12-26 14:46:15 -08:00
merge.c	Merge branch 'jc/maint-fmt-merge-msg-no-edit-lose-credit'	2013-01-10 13:46:29 -08:00
mktag.c
mktree.c	i18n: mktree: mark parseopt strings for translation	2012-08-20 12:23:18 -07:00
mv.c	i18n: mv: mark parseopt strings for translation	2012-08-20 12:23:18 -07:00
name-rev.c	i18n: name-rev: mark parseopt strings for translation	2012-08-20 12:23:18 -07:00
notes.c	builtin/notes.c: mark file-scope private symbols as static	2012-09-15 22:58:20 -07:00
pack-objects.c	Merge branch 'jk/peel-ref'	2012-10-25 06:42:27 -04:00
pack-redundant.c	Fix sizeof usage in get_permutations	2012-12-13 11:13:44 -08:00
pack-refs.c	i18n: pack-refs: mark parseopt strings for translation	2012-08-20 12:23:19 -07:00
patch-id.c
prune-packed.c	i18n: prune-packed: mark parseopt strings for translation	2012-08-20 12:23:19 -07:00
prune.c	Merge branch 'rj/path-cleanup'	2012-09-14 11:53:53 -07:00
push.c	push: Add support for pre-push hooks	2013-01-18 11:13:22 -08:00
read-tree.c	i18n: read-tree: mark parseopt strings for translation	2012-08-20 12:23:19 -07:00
receive-pack.c	hooks: Add function to check if a hook exists	2013-01-14 09:25:40 -08:00
reflog.c
remote-ext.c
remote-fd.c
remote.c	Fix typo in remote set-head usage	2012-11-26 13:27:45 -08:00
replace.c	replace: parse revision argument for -d	2012-11-13 08:34:14 -05:00
rerere.c	i18n: rerere: mark parseopt strings for translation	2012-08-20 12:23:19 -07:00
reset.c	reset: update documentation to require only tree-ish with paths	2013-01-16 12:50:23 -08:00
rev-list.c	Move print_commit_list to libgit.a	2012-10-29 03:08:30 -04:00
rev-parse.c	Merge branch 'maint-1.7.11' into maint	2012-09-12 14:08:05 -07:00
revert.c	Merge branch 'mz/cherry-pick-cmdline-order'	2012-09-10 15:42:55 -07:00
rm.c	Merge branch 'jl/submodule-rm'	2012-11-29 12:52:30 -08:00
send-pack.c	push: require force for refs under refs/tags/	2012-12-02 01:44:34 -08:00
shortlog.c	Merge branch 'ap/log-mailmap'	2013-01-20 17:06:53 -08:00
show-branch.c	i18n: show-branch: mark parseopt strings for translation	2012-08-22 10:58:28 -07:00
show-ref.c	Merge branch 'jk/peel-ref'	2012-10-25 06:42:27 -04:00
stripspace.c
symbolic-ref.c	git symbolic-ref --delete $symref	2012-10-21 12:17:38 -07:00
tag.c	Reduce translations by using same terminologies	2012-08-22 12:02:28 -07:00
tar-tree.c
unpack-file.c
unpack-objects.c
update-index.c	Merge branch 'kb/preload-index-more'	2012-11-20 10:32:10 -08:00
update-ref.c	Use imperative form in help usage to describe an action	2012-08-22 12:02:28 -07:00
update-server-info.c	i18n: update-server-info: mark parseopt strings for translation	2012-08-22 10:58:29 -07:00
upload-archive.c
var.c
verify-pack.c	i18n: verify-pack: mark parseopt strings for translation	2012-08-22 10:58:29 -07:00
verify-tag.c	i18n: verify-tag: mark parseopt strings for translation	2012-08-22 10:58:29 -07:00
write-tree.c	i18n: write-tree: mark parseopt strings for translation	2012-08-22 10:58:29 -07:00