git/t/t1430-bad-ref-name.sh at c491e9e4569b6304a5ce8d9f4c1602f21804d472 - mirrors/git - Incest Forge: Beyond sex. We incest.

mirrors/git

mirror of https://github.com/git/git.git synced 2024-10-31 14:27:54 +01:00

Jeff King a337292675 t1430: add another refs-escape test

In t1430, we check whether deleting the branch "../../foo"
will delete ".git/foo". However, this is not that
interesting a test; the precious file ".git/foo" does not
look like a ref, so even if we did not notice the "escape"
from the "refs/" hierarchy, we would fail for that reason
(i.e., if you turned refname_is_safe into a noop, the test
still passes).

Let's add an additional test for the same thing, but with a
file that actually looks like a ref. That will make sure we
are exercising the refname_is_safe code. While we're at it,
let's also make the code work a little harder by adding some
extra paths and some empty path components.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2015-04-16 08:15:06 -07:00

215 lines

6.7 KiB

Bash

Executable file

Raw Blame History

 #!/bin/sh
 test_description='Test handling of ref names that check-ref-format rejects'
 . ./test-lib.sh
 test_expect_success setup '
 	test_commit one &&
 	test_commit two
 '
 test_expect_success 'fast-import: fail on invalid branch name ".badbranchname"' '
 	test_when_finished "rm -f .git/objects/pack_* .git/objects/index_*" &&
 	cat >input <<-INPUT_END &&
 		commit .badbranchname
 		committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE
 		data <<COMMIT
 		corrupt
 		COMMIT
 		from refs/heads/master
 	INPUT_END
 	test_must_fail git fast-import <input
 '
 test_expect_success 'fast-import: fail on invalid branch name "bad[branch]name"' '
 	test_when_finished "rm -f .git/objects/pack_* .git/objects/index_*" &&
 	cat >input <<-INPUT_END &&
 		commit bad[branch]name
 		committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE
 		data <<COMMIT
 		corrupt
 		COMMIT
 		from refs/heads/master
 	INPUT_END
 	test_must_fail git fast-import <input
 '
 test_expect_success 'git branch shows badly named ref' '
 	cp .git/refs/heads/master .git/refs/heads/broken...ref &&
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	git branch >output &&
 	grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'branch -d can delete badly named ref' '
 	cp .git/refs/heads/master .git/refs/heads/broken...ref &&
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	git branch -d broken...ref &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'branch -D can delete badly named ref' '
 	cp .git/refs/heads/master .git/refs/heads/broken...ref &&
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	git branch -D broken...ref &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'branch -D cannot delete non-ref in .git dir' '
 	echo precious >.git/my-private-file &&
 	echo precious >expect &&
 	test_must_fail git branch -D ../../my-private-file &&
 	test_cmp expect .git/my-private-file
 '
 test_expect_success 'branch -D cannot delete ref in .git dir' '
 	git rev-parse HEAD >.git/my-private-file &&
 	git rev-parse HEAD >expect &&
 	git branch foo/legit &&
 	test_must_fail git branch -D foo////./././../../../my-private-file &&
 	test_cmp expect .git/my-private-file
 '
 test_expect_success 'branch -D cannot delete absolute path' '
 	git branch -f extra &&
 	test_must_fail git branch -D "$(pwd)/.git/refs/heads/extra" &&
 	test_cmp_rev HEAD extra
 '
 test_expect_success 'git branch cannot create a badly named ref' '
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	test_must_fail git branch broken...ref &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'branch -m cannot rename to a bad ref name' '
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	test_might_fail git branch -D goodref &&
 	git branch goodref &&
 	test_must_fail git branch -m goodref broken...ref &&
 	test_cmp_rev master goodref &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_failure 'branch -m can rename from a bad ref name' '
 	cp .git/refs/heads/master .git/refs/heads/broken...ref &&
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	git branch -m broken...ref renamed &&
 	test_cmp_rev master renamed &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'push cannot create a badly named ref' '
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	test_must_fail git push "file://$(pwd)" HEAD:refs/heads/broken...ref &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_failure 'push --mirror can delete badly named ref' '
 	top=$(pwd) &&
 	git init src &&
 	git init dest &&
 	(
 		cd src &&
 		test_commit one
 	) &&
 	(
 		cd dest &&
 		test_commit two &&
 		git checkout --detach &&
 		cp .git/refs/heads/master .git/refs/heads/broken...ref
 	) &&
 	git -C src push --mirror "file://$top/dest" &&
 	git -C dest branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'rev-parse skips symref pointing to broken name' '
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	git branch shadow one &&
 	cp .git/refs/heads/master .git/refs/heads/broken...ref &&
 	git symbolic-ref refs/tags/shadow refs/heads/broken...ref &&
 	git rev-parse --verify one >expect &&
 	git rev-parse --verify shadow >actual 2>err &&
 	test_cmp expect actual &&
 	test_i18ngrep "ignoring.*refs/tags/shadow" err
 '
 test_expect_success 'update-ref --no-deref -d can delete reference to broken name' '
 	git symbolic-ref refs/heads/badname refs/heads/broken...ref &&
 	test_when_finished "rm -f .git/refs/heads/badname" &&
 	test_path_is_file .git/refs/heads/badname &&
 	git update-ref --no-deref -d refs/heads/badname &&
 	test_path_is_missing .git/refs/heads/badname
 '
 test_expect_success 'update-ref -d can delete broken name' '
 	cp .git/refs/heads/master .git/refs/heads/broken...ref &&
 	test_when_finished "rm -f .git/refs/heads/broken...ref" &&
 	git update-ref -d refs/heads/broken...ref &&
 	git branch >output &&
 	! grep -e "broken\.\.\.ref" output
 '
 test_expect_success 'update-ref -d cannot delete non-ref in .git dir' '
 	echo precious >.git/my-private-file &&
 	echo precious >expect &&
 	test_must_fail git update-ref -d my-private-file &&
 	test_cmp expect .git/my-private-file
 '
 test_expect_success 'update-ref -d cannot delete absolute path' '
 	git branch -f extra &&
 	test_must_fail git update-ref -d "$(pwd)/.git/refs/heads/extra" &&
 	test_cmp_rev HEAD extra
 '
 test_expect_success 'update-ref --stdin fails create with bad ref name' '
 	echo "create ~a refs/heads/master" >stdin &&
 	test_must_fail git update-ref --stdin <stdin 2>err &&
 	grep "fatal: invalid ref format: ~a" err
 '
 test_expect_success 'update-ref --stdin fails update with bad ref name' '
 	echo "update ~a refs/heads/master" >stdin &&
 	test_must_fail git update-ref --stdin <stdin 2>err &&
 	grep "fatal: invalid ref format: ~a" err
 '
 test_expect_success 'update-ref --stdin fails delete with bad ref name' '
 	echo "delete ~a refs/heads/master" >stdin &&
 	test_must_fail git update-ref --stdin <stdin 2>err &&
 	grep "fatal: invalid ref format: ~a" err
 '
 test_expect_success 'update-ref --stdin -z fails create with bad ref name' '
 	printf "%s\0" "create ~a " refs/heads/master >stdin &&
 	test_must_fail git update-ref -z --stdin <stdin 2>err &&
 	grep "fatal: invalid ref format: ~a " err
 '
 test_expect_success 'update-ref --stdin -z fails update with bad ref name' '
 	printf "%s\0" "update ~a" refs/heads/master "" >stdin &&
 	test_must_fail git update-ref -z --stdin <stdin 2>err &&
 	grep "fatal: invalid ref format: ~a" err
 '
 test_expect_success 'update-ref --stdin -z fails delete with bad ref name' '
 	printf "%s\0" "delete ~a" refs/heads/master >stdin &&
 	test_must_fail git update-ref -z --stdin <stdin 2>err &&
 	grep "fatal: invalid ref format: ~a" err
 '
 test_done