1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-01 06:47:52 +01:00
Find a file
Jeff King c7ab0ba340 avoid sprintf and strcpy with flex arrays
When we are allocating a struct with a FLEX_ARRAY member, we
generally compute the size of the array and then sprintf or
strcpy into it. Normally we could improve a dynamic allocation
like this by using xstrfmt, but it doesn't work here; we
have to account for the size of the rest of the struct.

But we can improve things a bit by storing the length that
we use for the allocation, and then feeding it to xsnprintf
or memcpy, which makes it more obvious that we are not
writing more than the allocated number of bytes.

It would be nice if we had some kind of helper for
allocating generic flex arrays, but it doesn't work that
well:

 - the call signature is a little bit unwieldy:

      d = flex_struct(sizeof(*d), offsetof(d, path), fmt, ...);

   You need offsetof here instead of just writing to the
   end of the base size, because we don't know how the
   struct is packed (partially this is because FLEX_ARRAY
   might not be zero, though we can account for that; but
   the size of the struct may actually be rounded up for
   alignment, and we can't know that).

 - some sites do clever things, like over-allocating because
   they know they will write larger things into the buffer
   later (e.g., struct packed_git here).

So we're better off to just write out each allocation (or
add type-specific helpers, though many of these are one-off
allocations anyway).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-10-05 11:08:05 -07:00
block-sha1
builtin avoid sprintf and strcpy with flex arrays 2015-10-05 11:08:05 -07:00
compat probe_utf8_pathname_composition: use internal strbuf 2015-10-05 11:06:49 -07:00
contrib Merge branch 'js/maint-am-skip-performance-regression' 2015-09-14 14:59:13 -07:00
Documentation Update RelNotes to 2.6 2015-09-17 12:33:24 -07:00
ewah Merge branch 'es/osx-header-pollutes-mask-macro' into maint 2015-07-15 11:41:24 -07:00
git-gui
gitk-git Merge git://ozlabs.org/~paulus/gitk 2015-09-14 11:50:21 -07:00
gitweb
mergetools
perl send-email: reduce dependencies impact on parse_address_line 2015-07-07 14:38:20 -07:00
po l10n: de.po: better language for one string 2015-09-20 18:49:09 +02:00
ppc
t init: use strbufs to store paths 2015-10-05 11:07:04 -07:00
templates
vcs-svn
xdiff
.gitattributes
.gitignore Merge branch 'hv/submodule-config' 2015-08-31 15:38:52 -07:00
.mailmap mailmap: update my entry with new email address 2015-09-16 09:08:48 -07:00
abspath.c
aclocal.m4
advice.c pull: check if in unresolved merge state 2015-06-18 13:17:16 -07:00
advice.h pull: check if in unresolved merge state 2015-06-18 13:17:16 -07:00
alias.c config: silence warnings for command names with invalid keys 2015-08-24 08:52:23 -07:00
alloc.c
archive-tar.c archive-tar: use xsnprintf for trivial formatting 2015-09-25 10:18:18 -07:00
archive-zip.c Merge branch 'rs/archive-zip-many' into maint 2015-09-03 19:18:01 -07:00
archive.c avoid sprintf and strcpy with flex arrays 2015-10-05 11:08:05 -07:00
archive.h
argv-array.c argv-array: implement argv_array_pushv() 2015-06-15 12:40:49 -07:00
argv-array.h argv-array: implement argv_array_pushv() 2015-06-15 12:40:49 -07:00
attr.c memoize common git-path "constant" files 2015-08-10 15:37:14 -07:00
attr.h
base85.c
bisect.c Merge branch 'dt/refs-pseudo' 2015-08-25 14:57:08 -07:00
bisect.h bisect: simplify the addition of new bisect terms 2015-08-03 11:42:41 -07:00
blob.c
blob.h
branch.c Merge branch 'dt/notes-multiple' 2015-08-25 14:57:08 -07:00
branch.h worktrees: add find_shared_symref 2015-08-11 13:48:15 -07:00
builtin.h builtin-am: implement skeletal builtin am 2015-08-04 22:02:11 -07:00
bulk-checkin.c use xsnprintf for generating git object headers 2015-09-25 10:18:18 -07:00
bulk-checkin.h
bundle.c create_bundle(): duplicate file descriptor to avoid closing it twice 2015-08-10 12:57:14 -07:00
bundle.h
cache-tree.c cache-tree: introduce write_index_as_tree() 2015-08-04 22:02:11 -07:00
cache-tree.h cache-tree: introduce write_index_as_tree() 2015-08-04 22:02:11 -07:00
cache.h add_packed_git: convert strcpy into xsnprintf 2015-09-25 10:18:18 -07:00
check-builtins.sh
check-racy.c
check_bindir
color.c color: add overflow checks for parsing colors 2015-10-05 11:08:05 -07:00
color.h
column.c
column.h
combine-diff.c Merge branch 'jk/color-diff-plain-is-context' 2015-06-11 09:29:53 -07:00
command-list.txt Merge branch 'nd/multiple-work-trees' 2015-07-13 14:02:02 -07:00
commit-slab.h Merge branch 'jc/commit-slab' 2015-08-03 11:01:21 -07:00
commit.c Merge branch 'jc/commit-slab' 2015-08-03 11:01:21 -07:00
commit.h Merge branch 'jk/date-mode-format' 2015-08-03 11:01:27 -07:00
config.c Merge branch 'ss/fix-config-fd-leak' into maint 2015-09-03 19:17:59 -07:00
config.mak.in
config.mak.uname config.mak.uname: Darwin: define HAVE_GETDELIM for modern OS X releases 2015-06-03 09:38:04 -07:00
configure.ac configure: add getdelim() check 2015-06-03 09:38:19 -07:00
connect.c convert trivial sprintf / strcpy calls to xsnprintf 2015-09-25 10:18:18 -07:00
connect.h
connected.c
connected.h
convert.c convert trivial sprintf / strcpy calls to xsnprintf 2015-09-25 10:18:18 -07:00
convert.h
copy.c
COPYING
credential-cache--daemon.c credential-cache--daemon: use tempfile module 2015-08-12 14:50:11 -07:00
credential-cache.c
credential-store.c lockfile: add accessors get_lock_file_fd() and get_lock_file_fp() 2015-08-10 12:57:14 -07:00
credential.c
credential.h
csum-file.c
csum-file.h
ctype.c
daemon.c daemon: use cld->env_array when re-spawning 2015-10-05 11:08:05 -07:00
date.c introduce "format" date-mode 2015-06-29 11:39:10 -07:00
decorate.c
decorate.h
delta.h
diff-delta.c
diff-lib.c Merge branch 'nd/diff-i-t-a' 2015-06-25 10:47:46 -07:00
diff-no-index.c
diff.c use sha1_to_hex_r() instead of strcpy 2015-10-05 11:08:05 -07:00
diff.h log: add "log.follow" configuration variable 2015-07-09 10:24:23 -07:00
diffcore-break.c
diffcore-delta.c
diffcore-order.c
diffcore-pickaxe.c
diffcore-rename.c
diffcore.h
dir.c Merge branch 'dt/untracked-subdir' into maint 2015-09-17 12:12:29 -07:00
dir.h
editor.c
entry.c entry.c: convert strcpy to xsnprintf 2015-09-25 10:18:18 -07:00
environment.c replace trivial malloc + sprintf / strcpy calls with xstrfmt 2015-09-25 10:18:18 -07:00
exec_cmd.c
exec_cmd.h
fast-import.c avoid sprintf and strcpy with flex arrays 2015-10-05 11:08:05 -07:00
fetch-pack.c fetch-pack: use argv_array for index-pack / unpack-objects 2015-10-05 11:08:05 -07:00
fetch-pack.h
fmt-merge-msg.h
fsck.c Merge branch 'js/fsck-opt' 2015-08-03 11:01:18 -07:00
fsck.h fsck: git receive-pack: support excluding objects from fsck'ing 2015-06-23 14:27:37 -07:00
generate-cmdlist.sh generate-cmdlist: re-implement as shell script 2015-08-25 11:24:31 -07:00
gettext.c introduce "format" date-mode 2015-06-29 11:39:10 -07:00
gettext.h
git-add--interactive.perl
git-archimport.perl
git-bisect.sh bisect: don't mix option parsing and non-trivial code 2015-08-03 11:42:42 -07:00
git-compat-util.h probe_utf8_pathname_composition: use internal strbuf 2015-10-05 11:06:49 -07:00
git-cvsexportcommit.perl
git-cvsimport.perl Merge branch 'cn/cvsimport-perl-update' 2015-06-25 11:08:08 -07:00
git-cvsserver.perl
git-difftool--helper.sh
git-difftool.perl
git-filter-branch.sh
git-instaweb.sh
git-merge-octopus.sh
git-merge-one-file.sh
git-merge-resolve.sh
git-mergetool--lib.sh mergetool-lib: fix default tool selection 2015-06-19 11:20:52 -07:00
git-mergetool.sh
git-p4.py git-p4: honor core.ignorecase when using P4 client specs 2015-08-28 10:33:16 -07:00
git-parse-remote.sh
git-quiltimport.sh
git-rebase--am.sh rebase: return non-zero error code if format-patch fails 2015-07-08 15:36:42 -07:00
git-rebase--interactive.sh Merge branch 'gr/rebase-i-drop-warn' 2015-08-03 11:01:22 -07:00
git-rebase--merge.sh
git-rebase.sh
git-relink.perl
git-remote-testgit.sh
git-request-pull.sh
git-send-email.perl Merge branch 'bn/send-email-smtp-auth-error-message-fix' 2015-09-21 12:27:15 -07:00
git-sh-i18n.sh
git-sh-setup.sh
git-stash.sh git-stash: use update-ref --create-reflog instead of creating files 2015-07-21 14:08:49 -07:00
git-submodule.sh Merge branch 'ah/submodule-typofix-in-error' into maint 2015-09-17 12:11:08 -07:00
git-svn.perl git-svn: parse authors file more leniently 2015-09-10 17:59:38 +00:00
GIT-VERSION-GEN Git 2.6-rc3 2015-09-21 13:26:13 -07:00
git-web--browse.sh
git.c builtin-am: remove redirection to git-am.sh 2015-08-04 22:02:11 -07:00
git.rc
git.spec.in
gpg-interface.c verify-commit: add option to print raw gpg status information 2015-06-22 14:20:47 -07:00
gpg-interface.h verify-commit: add option to print raw gpg status information 2015-06-22 14:20:47 -07:00
graph.c
graph.h
grep.c grep: use xsnprintf to format failure message 2015-09-25 10:18:18 -07:00
grep.h
hashmap.c
hashmap.h
help.c Merge branch 'js/sleep-without-select' 2015-06-24 12:21:47 -07:00
help.h
hex.c add reentrant variants of sha1_to_hex and find_unique_abbrev 2015-09-25 10:18:18 -07:00
http-backend.c prefer git_pathdup to git_path in some possibly-dangerous cases 2015-08-10 15:37:12 -07:00
http-fetch.c
http-push.c drop strcpy in favor of raw sha1_to_hex 2015-10-05 11:08:05 -07:00
http-walker.c http-walker: store url in a strbuf 2015-09-25 10:18:18 -07:00
http.c use strip_suffix and xstrfmt to replace suffix 2015-09-25 10:18:18 -07:00
http.h
ident.c
imap-send.c replace trivial malloc + sprintf / strcpy calls with xstrfmt 2015-09-25 10:18:18 -07:00
INSTALL
khash.h
kwset.c
kwset.h
levenshtein.c
levenshtein.h
LGPL-2.1
line-log.c Merge branch 'jk/color-diff-plain-is-context' into maint 2015-06-25 11:02:11 -07:00
line-log.h
line-range.c
line-range.h
list-objects.c Merge branch 'jk/squelch-missing-link-warning-for-unreachable' into maint 2015-06-25 11:02:10 -07:00
list-objects.h
ll-merge.c convert trivial sprintf / strcpy calls to xsnprintf 2015-09-25 10:18:18 -07:00
ll-merge.h
lockfile.c lockfile: remove function "hold_lock_file_for_append" 2015-08-28 11:32:01 -07:00
lockfile.h lockfile: remove function "hold_lock_file_for_append" 2015-08-28 11:32:01 -07:00
log-tree.c Merge branch 'jk/date-mode-format' 2015-08-03 11:01:27 -07:00
log-tree.h
mailmap.c mailmap: replace strcpy with xstrdup 2015-09-25 10:18:18 -07:00
mailmap.h
Makefile Merge branch 'sg/help-group' 2015-09-14 14:59:05 -07:00
match-trees.c
merge-blobs.c
merge-blobs.h
merge-recursive.c merge-recursive: convert malloc / strcpy to strbuf 2015-10-05 11:08:04 -07:00
merge-recursive.h
merge.c
mergesort.c
mergesort.h
name-hash.c
notes-cache.c
notes-cache.h
notes-merge.c prefer git_pathdup to git_path in some possibly-dangerous cases 2015-08-10 15:37:12 -07:00
notes-merge.h notes: extract enum notes_merge_strategy to notes-utils.h 2015-08-17 15:36:23 -07:00
notes-utils.c notes: extract parse_notes_merge_strategy to notes-utils 2015-08-17 15:38:32 -07:00
notes-utils.h notes: extract parse_notes_merge_strategy to notes-utils 2015-08-17 15:38:32 -07:00
notes.c Sync with 2.4.9 2015-09-04 10:43:23 -07:00
notes.h
object.c
object.h
pack-bitmap-write.c
pack-bitmap.c use strip_suffix and xstrfmt to replace suffix 2015-09-25 10:18:18 -07:00
pack-bitmap.h
pack-check.c
pack-objects.c
pack-objects.h
pack-revindex.c
pack-revindex.h
pack-write.c
pack.h
pager.c Merge branch 'jk/fix-alias-pager-config-key-warnings' into maint 2015-09-03 19:17:52 -07:00
parse-options-cb.c parse-options-cb: implement parse_opt_passthru_argv() 2015-06-15 12:40:49 -07:00
parse-options.c parse-options: move unsigned long option parsing out of pack-objects.c 2015-06-22 15:07:21 -07:00
parse-options.h Merge branch 'sb/parse-options-codeformat' 2015-08-12 14:09:57 -07:00
patch-delta.c
patch-ids.c
patch-ids.h
path.c remove_leading_path: use a strbuf for internal storage 2015-10-05 11:08:05 -07:00
pathspec.c
pathspec.h
pkt-line.c pkt-line: support tracing verbatim pack contents 2015-06-16 13:24:22 -07:00
pkt-line.h
preload-index.c
pretty.c convert "enum date_mode" into a struct 2015-06-29 11:39:07 -07:00
prio-queue.c
prio-queue.h
progress.c stop_progress_msg: convert sprintf to xsnprintf 2015-09-25 10:18:18 -07:00
progress.h
prompt.c
prompt.h
quote.c
quote.h
reachable.c
reachable.h
read-cache.c read-cache: fix indentation in read_index_from 2015-08-31 12:31:00 -07:00
README
ref-filter.c ref-filter: drop sprintf and strcpy calls 2015-09-25 10:18:18 -07:00
ref-filter.h ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refname 2015-08-03 10:24:07 -07:00
reflog-walk.c replace trivial malloc + sprintf / strcpy calls with xstrfmt 2015-09-25 10:18:18 -07:00
reflog-walk.h convert "enum date_mode" into a struct 2015-06-29 11:39:07 -07:00
refs.c avoid sprintf and strcpy with flex arrays 2015-10-05 11:08:05 -07:00
refs.h Merge branch 'dt/refs-pseudo' 2015-08-25 14:57:08 -07:00
RelNotes Git 2.5.3 2015-09-17 12:16:17 -07:00
remote-curl.c use alloc_ref rather than hand-allocating "struct ref" 2015-10-05 11:08:05 -07:00
remote-testsvn.c refs: move the remaining ref module declarations to refs.h 2015-06-22 13:17:12 -07:00
remote.c stat_tracking_info: convert to argv_array 2015-10-05 11:08:05 -07:00
remote.h
replace_object.c
rerere.c rerere: release lockfile in non-writing functions 2015-09-01 15:52:54 -07:00
rerere.h rerere: release lockfile in non-writing functions 2015-09-01 15:52:54 -07:00
resolve-undo.c
resolve-undo.h
revision.c Merge branch 'jk/log-missing-default-HEAD' into maint 2015-09-03 19:18:04 -07:00
revision.h convert "enum date_mode" into a struct 2015-06-29 11:39:07 -07:00
run-command.c Merge branch 'jk/long-error-messages' 2015-08-25 14:57:06 -07:00
run-command.h find_hook: keep our own static buffer 2015-08-10 15:37:13 -07:00
send-pack.c Merge branch 'db/push-sign-if-asked' 2015-08-31 15:39:08 -07:00
send-pack.h push: support signing pushes iff the server supports it 2015-08-19 12:58:45 -07:00
sequencer.c Merge branch 'dt/refs-pseudo' 2015-08-25 14:57:08 -07:00
sequencer.h
server-info.c
setup.c replace trivial malloc + sprintf / strcpy calls with xstrfmt 2015-09-25 10:18:18 -07:00
sh-i18n--envsubst.c
sha1-array.c
sha1-array.h
sha1-lookup.c
sha1-lookup.h
sha1_file.c avoid sprintf and strcpy with flex arrays 2015-10-05 11:08:05 -07:00
sha1_name.c diagnose_invalid_index_path: use strbuf to avoid strcpy/strcat 2015-10-05 11:08:05 -07:00
shallow.c Merge branch 'mh/tempfile' 2015-08-25 14:57:09 -07:00
shell.c
shortlog.h
show-index.c
sideband.c convert trivial sprintf / strcpy calls to xsnprintf 2015-09-25 10:18:18 -07:00
sideband.h
sigchain.c
sigchain.h
split-index.c
split-index.h
strbuf.c convert trivial sprintf / strcpy calls to xsnprintf 2015-09-25 10:18:18 -07:00
strbuf.h add reentrant variants of sha1_to_hex and find_unique_abbrev 2015-09-25 10:18:18 -07:00
streaming.c
streaming.h
string-list.c
string-list.h
submodule-config.c submodule: allow erroneous values for the fetchRecurseSubmodules option 2015-08-19 11:43:10 -07:00
submodule-config.h submodule: allow erroneous values for the fetchRecurseSubmodules option 2015-08-19 11:43:10 -07:00
submodule.c avoid sprintf and strcpy with flex arrays 2015-10-05 11:08:05 -07:00
submodule.h submodule: allow erroneous values for the fetchRecurseSubmodules option 2015-08-19 11:43:10 -07:00
symlinks.c
tag.c
tag.h
tar.h
tempfile.c register_tempfile(): new function to handle an existing temporary file 2015-08-10 12:57:14 -07:00
tempfile.h register_tempfile(): new function to handle an existing temporary file 2015-08-10 12:57:14 -07:00
test-chmtime.c
test-config.c
test-ctype.c
test-date.c convert "enum date_mode" into a struct 2015-06-29 11:39:07 -07:00
test-delta.c
test-dump-cache-tree.c test-dump-cache-tree: avoid overflow of cache-tree name 2015-09-25 10:18:18 -07:00
test-dump-split-index.c commit: don't rewrite shared index unnecessarily 2015-08-31 08:41:07 -07:00
test-dump-untracked-cache.c
test-genrandom.c
test-hashmap.c
test-index-version.c
test-line-buffer.c
test-match-trees.c
test-mergesort.c
test-mktemp.c
test-parse-options.c parse-options: move unsigned long option parsing out of pack-objects.c 2015-06-22 15:07:21 -07:00
test-path-utils.c
test-prio-queue.c
test-read-cache.c
test-regex.c
test-revision-walking.c convert "enum date_mode" into a struct 2015-06-29 11:39:07 -07:00
test-run-command.c
test-scrap-cache-tree.c
test-sha1-array.c
test-sha1.c
test-sha1.sh
test-sigchain.c
test-string-list.c
test-submodule-config.c submodule: use new config API for worktree configurations 2015-08-19 11:43:10 -07:00
test-subprocess.c
test-svn-fe.c
test-urlmatch-normalization.c
test-wildmatch.c
thread-utils.c
thread-utils.h
trace.c trace: use strbuf for quote_crnl output 2015-09-25 10:18:18 -07:00
trace.h pkt-line: support tracing verbatim pack contents 2015-06-16 13:24:22 -07:00
trailer.c Merge branch 'cc/trailers-corner-case-fix' into maint 2015-09-03 19:18:03 -07:00
trailer.h
transport-helper.c Merge branch 'db/push-sign-if-asked' 2015-08-31 15:39:08 -07:00
transport.c transport: use strbufs for status table "quickref" strings 2015-10-05 11:08:04 -07:00
transport.h push: support signing pushes iff the server supports it 2015-08-19 12:58:45 -07:00
tree-diff.c
tree-walk.c
tree-walk.h
tree.c Merge branch 'jk/squelch-missing-link-warning-for-unreachable' into maint 2015-06-25 11:02:10 -07:00
tree.h Merge branch 'jk/squelch-missing-link-warning-for-unreachable' into maint 2015-06-25 11:02:10 -07:00
unicode_width.h
unimplemented.sh
unix-socket.c
unix-socket.h
unpack-trees.c replace trivial malloc + sprintf / strcpy calls with xstrfmt 2015-09-25 10:18:18 -07:00
unpack-trees.h
update_unicode.sh
upload-pack.c Merge branch 'bc/object-id' 2015-06-05 12:17:37 -07:00
url.c
url.h
urlmatch.c
urlmatch.h
usage.c vreportf: avoid intermediate buffer 2015-08-11 14:29:36 -07:00
userdiff.c userdiff: add support for Fountain documents 2015-07-23 14:44:51 -07:00
userdiff.h
utf8.c
utf8.h Merge branch 'es/utf8-stupid-compiler-workaround' into maint 2015-07-15 11:41:23 -07:00
varint.c
varint.h
version.c
version.h
versioncmp.c
walker.c drop strcpy in favor of raw sha1_to_hex 2015-10-05 11:08:05 -07:00
walker.h
wildmatch.c
wildmatch.h
wrap-for-bin.sh
wrapper.c add xsnprintf helper function 2015-09-25 10:18:18 -07:00
write_or_die.c
ws.c
wt-status.c Merge branch 'sg/wt-status-header-inclusion' into maint 2015-09-03 19:17:57 -07:00
wt-status.h wt-status: move #include "pathspec.h" to the header 2015-08-21 14:49:27 -07:00
xdiff-interface.c
xdiff-interface.h
zlib.c

////////////////////////////////////////////////////////////////

	Git - the stupid content tracker

////////////////////////////////////////////////////////////////

"git" can mean anything, depending on your mood.

 - random three-letter combination that is pronounceable, and not
   actually used by any common UNIX command.  The fact that it is a
   mispronunciation of "get" may or may not be relevant.
 - stupid. contemptible and despicable. simple. Take your pick from the
   dictionary of slang.
 - "global information tracker": you're in a good mood, and it actually
   works for you. Angels sing, and a light suddenly fills the room.
 - "goddamn idiotic truckload of sh*t": when it breaks

Git is a fast, scalable, distributed revision control system with an
unusually rich command set that provides both high-level operations
and full access to internals.

Git is an Open Source project covered by the GNU General Public
License version 2 (some parts of it are under different licenses,
compatible with the GPLv2). It was originally written by Linus
Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

See Documentation/gittutorial.txt to get started, then see
Documentation/giteveryday.txt for a useful minimum set of commands, and
Documentation/git-commandname.txt for documentation of each command.
If git has been correctly installed, then the tutorial can also be
read with "man gittutorial" or "git help tutorial", and the
documentation of each command with "man git-commandname" or "git help
commandname".

CVS users may also want to read Documentation/gitcvs-migration.txt
("man gitcvs-migration" or "git help cvs-migration" if git is
installed).

Many Git online resources are accessible from http://git-scm.com/
including full documentation and Git related tools.

The user discussion and development of Git take place on the Git
mailing list -- everyone is welcome to post bug reports, feature
requests, comments and patches to git@vger.kernel.org (read
Documentation/SubmittingPatches for instructions on patch submission).
To subscribe to the list, send an email with just "subscribe git" in
the body to majordomo@vger.kernel.org. The mailing list archives are
available at http://news.gmane.org/gmane.comp.version-control.git/,
http://marc.info/?l=git and other archival sites.

The maintainer frequently sends the "What's cooking" reports that
list the current status of various development topics to the mailing
list.  The discussion following them give a good reference for
project status, development direction and remaining tasks.