mirror of
https://github.com/git/git.git
synced 2024-11-02 15:28:21 +01:00
de83f8cc4c
If we feed a bad dictionary name to aspell on startup it may appear to start (as Tcl found the executable in our $PATH) but it fails to give us the version string. In such a case the close of the pipe will report the exit status of the process (failure) and that is an error in Tcl. We now trap the subprocess failure and display the stderr message from it, letting the user know why the failure is happening. We then disable the spell checker, but keep our object instance so the user can alter their preferred dictionary through the options dialog, and possibly restart the spell checker. I was also originally wrong to use "error" here for the display of the problem to the user. I meant to use "error_popup", which will open a message box and show the failure in a GUI context, rather than killing git-gui and showing the message on the console. Noticed by Ilari on #git. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> |
||
|---|---|---|
| .. | ||
| about.tcl | ||
| blame.tcl | ||
| branch.tcl | ||
| branch_checkout.tcl | ||
| branch_create.tcl | ||
| branch_delete.tcl | ||
| branch_rename.tcl | ||
| browser.tcl | ||
| checkout_op.tcl | ||
| choose_font.tcl | ||
| choose_repository.tcl | ||
| choose_rev.tcl | ||
| class.tcl | ||
| commit.tcl | ||
| console.tcl | ||
| database.tcl | ||
| date.tcl | ||
| diff.tcl | ||
| encoding.tcl | ||
| error.tcl | ||
| git-gui.ico | ||
| index.tcl | ||
| logo.tcl | ||
| merge.tcl | ||
| option.tcl | ||
| remote.tcl | ||
| remote_branch_delete.tcl | ||
| shortcut.tcl | ||
| spellcheck.tcl | ||
| status_bar.tcl | ||
| transport.tcl | ||
| win32.tcl | ||
| win32_shortcut.js | ||