1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-15 05:33:04 +01:00
git/t
Junio C Hamano 7fec10b7f4 index: be careful when handling long names
We currently use lower 12-bit (masked with CE_NAMEMASK) in the
ce_flags field to store the length of the name in cache_entry,
without checking the length parameter given to
create_ce_flags().  This can make us store incorrect length.

Currently we are mostly protected by the fact that many
codepaths first copy the path in a variable of size PATH_MAX,
which typically is 4096 that happens to match the limit, but
that feels like a bug waiting to happen.  Besides, that would
not allow us to shorten the width of CE_NAMEMASK to use the bits
for new flags.

This redefines the meaning of the name length stored in the
cache_entry.  A name that does not fit is represented by storing
CE_NAMEMASK in the field, and the actual length needs to be
computed by actually counting the bytes in the name[] field.
This way, only the unusually long paths need to suffer.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-01-21 12:44:31 -08:00
..
t3900
t4013
t4100 Replace the word 'update-cache' by 'update-index' everywhere 2007-11-30 15:09:40 -08:00
t4101
t5100
t5515
t7004
t7500
t9110
t9111
t9115
.gitignore
annotate-tests.sh
diff-lib.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
lib-git-svn.sh git-svn: replace .rev_db with a more space-efficient .rev_map format 2007-12-10 21:28:25 -08:00
lib-read-tree-m-3way.sh
Makefile
README
t0000-basic.sh index: be careful when handling long names 2008-01-21 12:44:31 -08:00
t0001-init.sh Do not rely on the exit status of "unset" for unset variables 2007-12-04 14:48:45 -08:00
t0010-racy-git.sh
t0020-crlf.sh Officially deprecate repo-config. 2008-01-17 22:52:40 -08:00
t0021-conversion.sh
t0022-crlf-rename.sh
t0023-crlf-am.sh
t0030-stripspace.sh
t0040-parse-options.sh parse-options: abbreviation engine fix. 2007-11-05 22:46:45 -08:00
t1000-read-tree-m-3way.sh
t1001-read-tree-m-2way.sh
t1002-read-tree-m-u-2way.sh
t1003-read-tree-prefix.sh
t1004-read-tree-m-u-wf.sh
t1020-subdirectory.sh
t1100-commit-tree-options.sh
t1200-tutorial.sh
t1300-repo-config.sh Improve error messages when int/long cannot be parsed from config 2007-12-26 11:37:45 -08:00
t1301-shared-repo.sh
t1302-repo-version.sh Do check_repository_format() early (re-fix) 2007-12-05 15:06:37 -08:00
t1303-wacky-config.sh config: handle lack of newline at end of file better 2008-01-02 02:28:54 -08:00
t1400-update-ref.sh Be more careful about updating refs 2008-01-16 11:53:35 -08:00
t1410-reflog.sh Add "--expire <time>" option to 'git prune' 2007-11-30 15:47:01 -08:00
t1420-lost-found.sh
t1500-rev-parse.sh
t1501-worktree.sh
t2000-checkout-cache-clash.sh
t2001-checkout-cache-clash.sh
t2002-checkout-cache-u.sh
t2003-checkout-cache-mkdir.sh
t2004-checkout-cache-temp.sh
t2005-checkout-index-symlinks.sh
t2007-checkout-symlink.sh
t2008-checkout-subdir.sh git-checkout: Test for relative path use. 2007-11-11 17:00:08 -08:00
t2050-git-dir-relative.sh
t2100-update-cache-badpath.sh
t2101-update-index-reupdate.sh
t2102-update-index-symlinks.sh
t2200-add-update.sh t2200: test more cases of "add -u" 2007-11-11 18:44:16 -08:00
t3000-ls-files-others.sh
t3001-ls-files-others-exclude.sh Replace "runstatus" with "status" in the tests 2007-11-22 17:05:04 -08:00
t3002-ls-files-dashpath.sh
t3010-ls-files-killed-modified.sh
t3020-ls-files-error-unmatch.sh
t3030-merge-recursive.sh
t3040-subprojects-basic.sh
t3050-subprojects-fetch.sh
t3060-ls-files-with-tree.sh
t3100-ls-tree-restrict.sh
t3101-ls-tree-dirname.sh
t3200-branch.sh
t3201-branch-contains.sh git-branch --contains: doc and test 2007-11-22 22:11:28 -08:00
t3210-pack-refs.sh
t3300-funny-names.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
t3400-rebase.sh
t3401-rebase-partial.sh
t3402-rebase-merge.sh rebase: operate on a detached HEAD 2007-11-09 01:30:31 -08:00
t3403-rebase-skip.sh Merge branch 'mh/rebase-skip-hard' 2007-11-24 16:31:08 -08:00
t3404-rebase-interactive.sh rebase -p -i: handle "no changes" gracefully 2007-12-17 20:49:18 -08:00
t3405-rebase-malformed.sh
t3406-rebase-message.sh
t3500-cherry.sh
t3501-revert-cherry-pick.sh
t3502-cherry-pick-merge.sh t3502: Disambiguate between file and rev by adding -- 2007-11-05 15:04:57 -08:00
t3600-rm.sh t/t{3600,3800,5401}: do not use egrep when grep would do 2008-01-05 00:07:57 -08:00
t3700-add.sh Fix per-directory exclude handing for "git add" 2007-11-16 17:05:13 -08:00
t3800-mktag.sh t/t3800: do not use a temporary file to hold expected result. 2008-01-05 00:07:57 -08:00
t3900-i18n-commit.sh
t3901-8859-1.txt
t3901-i18n-patch.sh
t3901-utf8.txt
t3902-quoted.sh Skip t3902-quoted.sh if the file system does not support funny names. 2007-11-14 15:18:39 -08:00
t3903-stash.sh
t4000-diff-format.sh Replace the word 'update-cache' by 'update-index' everywhere 2007-11-30 15:09:40 -08:00
t4001-diff-rename.sh Merge branch 'kh/commit' 2007-12-04 17:16:33 -08:00
t4002-diff-basic.sh
t4003-diff-rename-1.sh
t4004-diff-rename-symlink.sh
t4005-diff-rename-2.sh
t4006-diff-mode.sh
t4007-rename-3.sh
t4008-diff-break-rewrite.sh rename: Break filepairs with different types. 2007-12-02 02:24:46 -08:00
t4009-diff-rename-4.sh
t4010-diff-pathspec.sh
t4011-diff-symlink.sh
t4012-diff-binary.sh
t4013-diff-various.sh
t4014-format-patch.sh
t4015-diff-whitespace.sh whitespace: fix initial-indent checking 2007-12-16 13:07:49 -08:00
t4016-diff-quote.sh
t4017-diff-retval.sh Test interaction between diff --check and --exit-code 2007-12-14 20:52:26 -08:00
t4017-quiet.sh
t4018-diff-funcname.sh Make test scripts executable. 2007-11-22 16:48:55 -08:00
t4019-diff-wserror.sh Use gitattributes to define per-path whitespace rule 2007-12-06 00:45:30 -08:00
t4020-diff-external.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
t4021-format-patch-numbered.sh format-patch: Test --[no-]numbered and format.numbered 2007-11-04 01:26:30 -08:00
t4021-format-patch-signer-mime.sh test format-patch -s: make sure MIME content type is shown as needed 2007-11-07 18:37:28 -08:00
t4022-diff-rewrite.sh Fix "quote" misconversion for rewrite diff output. 2007-11-21 23:06:44 -08:00
t4023-diff-rename-typechange.sh rename: Break filepairs with different types. 2007-12-02 02:24:46 -08:00
t4024-diff-optimize-common.sh t4024: fix test script to use simpler sed pattern 2007-12-20 01:11:37 -08:00
t4025-hunk-header.sh diff: do not chomp hunk-header in the middle of a character 2008-01-06 22:44:44 -08:00
t4100-apply-stat.sh
t4101-apply-nonl.sh
t4102-apply-rename.sh
t4103-apply-binary.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
t4104-apply-boundary.sh
t4109-apply-multifrag.sh
t4110-apply-scan.sh
t4112-apply-renames.sh
t4113-apply-ending.sh
t4114-apply-typechange.sh
t4115-apply-symlink.sh
t4116-apply-reverse.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
t4117-apply-reject.sh
t4118-apply-empty-context.sh
t4119-apply-config.sh t4119: correct overeager war-on-whitespace 2007-11-24 16:46:42 -08:00
t4120-apply-popt.sh
t4121-apply-diffs.sh
t4122-apply-symlink-inside.sh
t4123-apply-shrink.sh
t4124-apply-ws-rule.sh Use gitattributes to define per-path whitespace rule 2007-12-06 00:45:30 -08:00
t4200-rerere.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
t4201-shortlog.sh Officially deprecate repo-config. 2008-01-17 22:52:40 -08:00
t4202-log.sh Fix "git log --diff-filter" bug 2007-12-26 11:57:36 -08:00
t5000-tar-tree.sh
t5100-mailinfo.sh
t5300-pack-object.sh the use of 'tr' in the test suite isn't really portable 2007-12-17 20:49:18 -08:00
t5301-sliding-window.sh
t5302-pack-index.sh rehabilitate some t5302 tests on 32-bit off_t machines 2007-11-15 21:18:07 -08:00
t5400-send-pack.sh
t5401-update-hooks.sh t/t{3600,3800,5401}: do not use egrep when grep would do 2008-01-05 00:07:57 -08:00
t5402-post-merge-hook.sh
t5403-post-checkout-hook.sh
t5404-tracking-branches.sh send-pack: check ref->status before updating tracking refs 2007-11-17 12:10:50 -08:00
t5405-send-pack-rewind.sh send-pack: segfault fix on forced push 2007-11-08 01:43:34 -08:00
t5406-remote-rejects.sh send-pack: assign remote errors to each ref 2007-11-17 12:10:50 -08:00
t5500-fetch-pack.sh
t5502-quickfetch.sh git-fetch: avoid local fetching from alternate (again) 2007-11-11 17:09:55 -08:00
t5505-remote.sh
t5510-fetch.sh t5510: add a bit more tests for fetch 2007-12-04 21:58:42 -08:00
t5512-ls-remote.sh Reteach builtin-ls-remote to understand remotes 2007-11-06 22:51:04 -08:00
t5515-fetch-merge-logic.sh
t5516-fetch-push.sh Merge branch 'sp/refspec-match' 2007-12-04 17:07:10 -08:00
t5517-push-mirror.sh Add tests for git push'es mirror mode 2007-11-12 18:22:09 -08:00
t5520-pull.sh Teach 'git pull' about --rebase 2007-11-28 17:32:23 -08:00
t5530-upload-pack-error.sh upload-pack: Use finish_{command,async}() instead of waitpid(). 2007-11-05 22:47:28 -08:00
t5600-clone-fail-cleanup.sh
t5700-clone-reference.sh
t5701-clone-local.sh
t5702-clone-options.sh test "git clone -o" 2007-12-19 14:59:18 -08:00
t5710-info-alternate.sh
t6000lib.sh
t6001-rev-list-graft.sh
t6002-rev-list-bisect.sh
t6003-rev-list-topo-order.sh
t6004-rev-list-path-optim.sh
t6005-rev-list-count.sh
t6006-rev-list-format.sh custom pretty format: tolerate empty e-mail address 2008-01-06 18:41:43 -08:00
t6007-rev-list-cherry-pick-file.sh
t6008-rev-list-submodule.sh Fix rev-list when showing objects involving submodules 2007-11-16 22:05:33 -08:00
t6010-merge-base.sh
t6020-merge-df.sh
t6021-merge-criss-cross.sh
t6022-merge-rename.sh
t6023-merge-file.sh
t6023-merge-rename-nocruft.sh
t6024-recursive-merge.sh
t6025-merge-symlinks.sh
t6026-merge-attr.sh
t6027-merge-binary.sh
t6028-merge-up-to-date.sh
t6030-bisect-porcelain.sh Bisect reset: do nothing when not bisecting. 2007-11-20 01:01:46 -08:00
t6101-rev-parse-parents.sh
t6120-describe.sh
t6200-fmt-merge-msg.sh
t6300-for-each-ref.sh for-each-ref: Fix quoting style constants. 2007-12-06 07:53:20 -08:00
t7001-mv.sh t/t7001: avoid unnecessary ERE when using grep 2008-01-05 00:07:57 -08:00
t7002-grep.sh
t7003-filter-branch.sh t7003-filter-branch: Fix test of a failing --msg-filter. 2007-11-30 14:16:52 -08:00
t7004-tag.sh Force the sticked form for options with optional arguments. 2007-12-22 10:26:08 -08:00
t7005-editor.sh t7005: do not exit inside test. 2007-12-22 19:45:06 -08:00
t7101-reset.sh
t7102-reset.sh builtin-reset: avoid forking "update-index --refresh" 2007-11-05 22:47:22 -08:00
t7103-reset-bare.sh git-reset: refuse to do hard reset in a bare repository 2008-01-02 02:28:54 -08:00
t7201-co.sh Add more checkout tests 2007-12-10 11:24:56 -08:00
t7300-clean.sh t7300: add test for clean with wildcard pathspec 2007-12-05 22:47:45 -08:00
t7400-submodule-basic.sh
t7500-commit.sh builtin-commit --s: add a newline if the last line was not a S-o-b 2007-11-22 17:05:03 -08:00
t7501-commit.sh commit: allow --amend to reuse message from another commit 2007-12-14 15:39:54 -08:00
t7502-commit.sh Allow selection of different cleanup modes for commit messages 2007-12-22 19:55:07 -08:00
t7502-status.sh add status.relativePaths config variable 2007-12-08 03:33:24 -08:00
t7503-pre-commit-hook.sh Style fixes for pre-commit hook tests 2007-12-10 00:05:52 -08:00
t7504-commit-msg-hook.sh Interactive editor tests for commit-msg hook 2007-12-10 00:05:52 -08:00
t7600-merge.sh t/t7600: avoid GNUism in grep 2008-01-05 00:07:51 -08:00
t8001-annotate.sh
t8002-blame.sh
t8003-blame.sh
t8004-blame.sh
t9001-send-email.sh send-email: add no-validate option 2008-01-18 13:33:57 -08:00
t9100-git-svn-basic.sh
t9101-git-svn-props.sh Merge branch 'maint' 2007-11-16 21:30:06 -08:00
t9102-git-svn-deep-rmdir.sh
t9103-git-svn-tracked-directory-removed.sh git-svn: handle our top-level path being deleted and later re-added 2007-12-14 12:06:23 -08:00
t9104-git-svn-follow-parent.sh
t9105-git-svn-commit-diff.sh
t9106-git-svn-commit-diff-clobber.sh
t9106-git-svn-dcommit-clobber-series.sh t9106: fix a race condition that caused svn to miss modifications 2007-11-21 20:11:11 -08:00
t9107-git-svn-migrate.sh git-svn: replace .rev_db with a more space-efficient .rev_map format 2007-12-10 21:28:25 -08:00
t9108-git-svn-glob.sh
t9110-git-svn-use-svm-props.sh
t9111-git-svn-use-svnsync-props.sh
t9112-git-svn-md5less-file.sh
t9113-git-svn-dcommit-new-file.sh
t9114-git-svn-dcommit-merge.sh git-svn: t9114: verify merge commit message in test 2007-11-05 12:58:39 -08:00
t9115-git-svn-dcommit-funky-renames.sh
t9116-git-svn-log.sh git-svn log: handle unreachable revisions like "svn log" 2007-11-17 13:28:21 -08:00
t9117-git-svn-init-clone.sh git-svn: add tests for command-line usage of init and clone commands 2007-11-17 13:28:21 -08:00
t9118-git-svn-funky-branch-names.sh git-svn: support for funky branch and project names over HTTP(S) 2007-11-12 00:22:49 -08:00
t9119-git-svn-info.sh disable t9119 for now. 2007-12-12 11:53:29 -08:00
t9200-git-cvsexportcommit.sh Officially deprecate repo-config. 2008-01-17 22:52:40 -08:00
t9300-fast-import.sh
t9301-fast-export.sh fast-export: rename the signed tag mode 'ignore' to 'verbatim' 2007-12-03 23:43:07 -08:00
t9400-git-cvsserver-server.sh
t9500-gitweb-standalone-no-errors.sh gitweb: Make config_to_multi return [] instead of [undef] 2007-12-16 11:56:27 -08:00
t9600-cvsimport.sh t9600: require cvsps 2.1 to perform tests 2007-12-04 14:43:05 -08:00
test-lib.sh test-lib.sh: move error line after error() declaration 2007-11-10 11:04:56 -08:00
test4012.png
test9200a.png
test9200b.png

Core GIT Tests
==============

This directory holds many test scripts for core GIT tools.  The
first part of this short document describes how to run the tests
and read their output.

When fixing the tools or adding enhancements, you are strongly
encouraged to add tests in this directory to cover what you are
trying to fix or enhance.  The later part of this short document
describes how your test scripts should be organized.


Running Tests
-------------

The easiest way to run tests is to say "make".  This runs all
the tests.

    *** t0000-basic.sh ***
    *   ok 1: .git/objects should be empty after git-init in an empty repo.
    *   ok 2: .git/objects should have 256 subdirectories.
    *   ok 3: git-update-index without --add should fail adding.
    ...
    *   ok 23: no diff after checkout and git-update-index --refresh.
    * passed all 23 test(s)
    *** t0100-environment-names.sh ***
    *   ok 1: using old names should issue warnings.
    *   ok 2: using old names but having new names should not issue warnings.
    ...

Or you can run each test individually from command line, like
this:

    $ sh ./t3001-ls-files-killed.sh
    *   ok 1: git-update-index --add to add various paths.
    *   ok 2: git-ls-files -k to show killed files.
    *   ok 3: validate git-ls-files -k output.
    * passed all 3 test(s)

You can pass --verbose (or -v), --debug (or -d), and --immediate
(or -i) command line argument to the test.

--verbose::
	This makes the test more verbose.  Specifically, the
	command being run and their output if any are also
	output.

--debug::
	This may help the person who is developing a new test.
	It causes the command defined with test_debug to run.

--immediate::
	This causes the test to immediately exit upon the first
	failed test.


Naming Tests
------------

The test files are named as:

	tNNNN-commandname-details.sh

where N is a decimal digit.

First digit tells the family:

	0 - the absolute basics and global stuff
	1 - the basic commands concerning database
	2 - the basic commands concerning the working tree
	3 - the other basic commands (e.g. ls-files)
	4 - the diff commands
	5 - the pull and exporting commands
	6 - the revision tree commands (even e.g. merge-base)
	7 - the porcelainish commands concerning the working tree
	8 - the porcelainish commands concerning forensics
	9 - the git tools

Second digit tells the particular command we are testing.

Third digit (optionally) tells the particular switch or group of switches
we are testing.

If you create files under t/ directory (i.e. here) that is not
the top-level test script, never name the file to match the above
pattern.  The Makefile here considers all such files as the
top-level test script and tries to run all of them.  A care is
especially needed if you are creating a common test library
file, similar to test-lib.sh, because such a library file may
not be suitable for standalone execution.


Writing Tests
-------------

The test script is written as a shell script.  It should start
with the standard "#!/bin/sh" with copyright notices, and an
assignment to variable 'test_description', like this:

	#!/bin/sh
	#
	# Copyright (c) 2005 Junio C Hamano
	#

	test_description='xxx test (option --frotz)

	This test registers the following structure in the cache
	and tries to run git-ls-files with option --frotz.'


Source 'test-lib.sh'
--------------------

After assigning test_description, the test script should source
test-lib.sh like this:

	. ./test-lib.sh

This test harness library does the following things:

 - If the script is invoked with command line argument --help
   (or -h), it shows the test_description and exits.

 - Creates an empty test directory with an empty .git/objects
   database and chdir(2) into it.  This directory is 't/trash'
   if you must know, but I do not think you care.

 - Defines standard test helper functions for your scripts to
   use.  These functions are designed to make all scripts behave
   consistently when command line arguments --verbose (or -v),
   --debug (or -d), and --immediate (or -i) is given.


End with test_done
------------------

Your script will be a sequence of tests, using helper functions
from the test harness library.  At the end of the script, call
'test_done'.


Test harness library
--------------------

There are a handful helper functions defined in the test harness
library for your script to use.

 - test_expect_success <message> <script>

   This takes two strings as parameter, and evaluates the
   <script>.  If it yields success, test is considered
   successful.  <message> should state what it is testing.

   Example:

	test_expect_success \
	    'git-write-tree should be able to write an empty tree.' \
	    'tree=$(git-write-tree)'

 - test_expect_failure <message> <script>

   This is the opposite of test_expect_success.  If <script>
   yields success, test is considered a failure.

   Example:

	test_expect_failure \
	    'git-update-index without --add should fail adding.' \
	    'git-update-index should-be-empty'

 - test_debug <script>

   This takes a single argument, <script>, and evaluates it only
   when the test script is started with --debug command line
   argument.  This is primarily meant for use during the
   development of a new test script.

 - test_done

   Your test script must have test_done at the end.  Its purpose
   is to summarize successes and failures in the test script and
   exit with an appropriate error code.


Tips for Writing Tests
----------------------

As with any programming projects, existing programs are the best
source of the information.  However, do _not_ emulate
t0000-basic.sh when writing your tests.  The test is special in
that it tries to validate the very core of GIT.  For example, it
knows that there will be 256 subdirectories under .git/objects/,
and it knows that the object ID of an empty tree is a certain
40-byte string.  This is deliberately done so in t0000-basic.sh
because the things the very basic core test tries to achieve is
to serve as a basis for people who are changing the GIT internal
drastically.  For these people, after making certain changes,
not seeing failures from the basic test _is_ a failure.  And
such drastic changes to the core GIT that even changes these
otherwise supposedly stable object IDs should be accompanied by
an update to t0000-basic.sh.

However, other tests that simply rely on basic parts of the core
GIT working properly should not have that level of intimate
knowledge of the core GIT internals.  If all the test scripts
hardcoded the object IDs like t0000-basic.sh does, that defeats
the purpose of t0000-basic.sh, which is to isolate that level of
validation in one place.  Your test also ends up needing
updating when such a change to the internal happens, so do _not_
do it and leave the low level of validation to t0000-basic.sh.