mirror of
https://github.com/git/git.git
synced 2024-10-29 21:37:53 +01:00
f9bc573fda
Callers who ask for ERROR_ON_NO_NAME are not so much concerned that the name will be blank (because, after all, we will fall back to using the username), but rather it is a check to make sure that low-quality identities do not end up in things like commit messages or emails (whereas it is OK for them to end up in things like reflogs). When future commits add more quality checks on the identity, each of these callers would want to use those checks, too. Rather than modify each of them later to add a new flag, let's refactor the flag. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
93 lines
1.7 KiB
C
93 lines
1.7 KiB
C
/*
|
|
* GIT - The information manager from hell
|
|
*
|
|
* Copyright (C) Eric Biederman, 2005
|
|
*/
|
|
#include "builtin.h"
|
|
|
|
static const char var_usage[] = "git var (-l | <variable>)";
|
|
|
|
static const char *editor(int flag)
|
|
{
|
|
const char *pgm = git_editor();
|
|
|
|
if (!pgm && flag & IDENT_STRICT)
|
|
die("Terminal is dumb, but EDITOR unset");
|
|
|
|
return pgm;
|
|
}
|
|
|
|
static const char *pager(int flag)
|
|
{
|
|
const char *pgm = git_pager(1);
|
|
|
|
if (!pgm)
|
|
pgm = "cat";
|
|
return pgm;
|
|
}
|
|
|
|
struct git_var {
|
|
const char *name;
|
|
const char *(*read)(int);
|
|
};
|
|
static struct git_var git_vars[] = {
|
|
{ "GIT_COMMITTER_IDENT", git_committer_info },
|
|
{ "GIT_AUTHOR_IDENT", git_author_info },
|
|
{ "GIT_EDITOR", editor },
|
|
{ "GIT_PAGER", pager },
|
|
{ "", NULL },
|
|
};
|
|
|
|
static void list_vars(void)
|
|
{
|
|
struct git_var *ptr;
|
|
const char *val;
|
|
|
|
for (ptr = git_vars; ptr->read; ptr++)
|
|
if ((val = ptr->read(0)))
|
|
printf("%s=%s\n", ptr->name, val);
|
|
}
|
|
|
|
static const char *read_var(const char *var)
|
|
{
|
|
struct git_var *ptr;
|
|
const char *val;
|
|
val = NULL;
|
|
for (ptr = git_vars; ptr->read; ptr++) {
|
|
if (strcmp(var, ptr->name) == 0) {
|
|
val = ptr->read(IDENT_STRICT);
|
|
break;
|
|
}
|
|
}
|
|
return val;
|
|
}
|
|
|
|
static int show_config(const char *var, const char *value, void *cb)
|
|
{
|
|
if (value)
|
|
printf("%s=%s\n", var, value);
|
|
else
|
|
printf("%s\n", var);
|
|
return git_default_config(var, value, cb);
|
|
}
|
|
|
|
int cmd_var(int argc, const char **argv, const char *prefix)
|
|
{
|
|
const char *val = NULL;
|
|
if (argc != 2)
|
|
usage(var_usage);
|
|
|
|
if (strcmp(argv[1], "-l") == 0) {
|
|
git_config(show_config, NULL);
|
|
list_vars();
|
|
return 0;
|
|
}
|
|
git_config(git_default_config, NULL);
|
|
val = read_var(argv[1]);
|
|
if (!val)
|
|
usage(var_usage);
|
|
|
|
printf("%s\n", val);
|
|
|
|
return 0;
|
|
}
|