Commit graph

35107 commits

Author SHA1 Message Date
Jonah Graham
1d4945eec3 Typo.
Change-Id: I4d9ec6da1f02cc41643539c17ba34567ec95ba7b
2021-09-09 15:27:27 -04:00
Jonah Graham
be9e1a55c8 Bug 575903: Call correct clean method
The old clean method was removed from use in Bug 571134 but this call
to it was missed.

Change-Id: I01310a3e3c1f45534e55d146f9480ac323446dd4
2021-09-09 15:27:27 -04:00
Jonah Graham
0923a6a9f1 [releng] Prepare repo for 10.3.3 release
Change-Id: Ic9494a18d792c14d53f887ff37c66498596b1cda
2021-09-09 15:14:27 -04:00
Jonah Graham
a70e9c4449 [releng] Prepare repo for 10.3.2 release
Change-Id: I967dbe189100d72b5de22f489106a96fe99eaad3
2021-07-24 13:49:30 -04:00
Jonah Graham
1071e55fb1 Bug 574519: Always collect WSL entries in a Job
Change-Id: I35abec7ca075bf525e972e4cbc03af4361d1d490
2021-07-24 12:57:38 -04:00
Jeff Johnston
da616bcc43 Bug 574874 - Disable full gdb console support if running CDT in flatpak
- add check for flatpak environment variable in
  GDBBackend_7_12.isFullGdbConsoleSupported() method
  and return false if variable is set
- bump up org.eclipse.cdt.dsf.gdb version

Change-Id: I667a63395592e2671ab3bf6f255e7428371086b3
(cherry picked from commit d27126df9a)
2021-07-16 14:48:51 -04:00
Jonah Graham
dcbb2a51bb Bug 574331: Set default query results for tests
Most of the tests in this bundle already had this bit of code
before calling create project. This makes BuildDescriptionModelTests
consistent with the rest.

Note that this modifies global state and does not restore it. However,
as that is consistent with the other tests in this bundle, and the
global state is only maintained while running tests on this bundle,
I am not fixing this aspect of the code.

Change-Id: I2004af177a959e1efbd45b23c960b517d8993b7c
2021-06-19 15:32:31 -04:00
Jonah Graham
6b332e35cd Bug 574271: Draw characters in the correct color on macos
There is a bug in SWT on macos - Bug 568777 - with the cache of single
character drawStrings with transparent backgrounds as a performance
boost. This causes the terminal to draw some characters in the
wrong color.

The workaround is to not draw with transparency, which should be fine
because we just filled the background with the same color that the
1 character string will draw with.

The performance, measured with TerminalTextUITest in Fast mode with
no throttling, does not seem affected and in my testing there does
not seem to be any graphic side effects.

Change-Id: I1b0aadae100d81a8f4533ba73273ccc8202e068f
2021-06-19 13:16:45 -04:00
Jonah Graham
a319ec5c2e [releng] Prepare repo for 10.3.1 release
Change-Id: Ie654a14eb270d9a7e7fd79bd4453282cae2bc045
2021-06-19 12:58:15 -04:00
Martin Weber
fce6d2f93f eliminate class StringUtil
Change-Id: I07cd8c70d2db8abe415f720275b6c25d464ba91c
Signed-off-by: Martin Weber <fifteenknots505@gmail.com>
2021-06-07 20:42:09 +02:00
Jonah Graham
d49362a526 Add missing copyright header.
Change-Id: If005b907dd902acd8647dfb5932bcfbbfa0ae0a3
2021-06-07 11:39:57 -04:00
Jonah Graham
48ff7a223d Bug 574057: Prevent null set of selected data volumes
Prefer an empty set instead.

Change-Id: I6b13f78ffbbbe0cbac2b69ad50abdc90f15fed66
2021-06-07 11:39:57 -04:00
Jonah Graham
087e0e4a3e Typo. s/Java Element/C Element/
Change-Id: Ida00d0fe8884ebf3beb4afc9b7fb44e084a028a5
2021-06-04 21:27:49 -04:00
Jonah Graham
074acd9ea2 Bug 573996: dispose of fonts created in the new project wizard
Change-Id: I3ca9d37ac6bda563284cb21a3e3e164abc2c63d3
2021-06-03 21:35:07 -04:00
Torbjörn Svensson
50dcf3dbfa Bug 573688: Compare flags for the same address
Contributed by STMicroelectronics

Change-Id: I4a7ea55b341653bbf01b9e69b3129023278104f9
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-05-31 14:55:03 -04:00
Torbjörn Svensson
224b14318b Use the launch name in the help text
The "eclipse.launcher" property is available when using the eclipse
launcher. If the headless builder app is launched without the eclipse
launcher, fall back to generic "PROGRAM".

The property is not available when running eclipse in runtime mode!

Contributed by STMicroelectronics

Change-Id: If2c99a234fd841451af05e3635d44fe2967c9537
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-05-28 19:23:00 +02:00
Jonah Graham
37fef0749c Bug 573786: Handle UnsatisfiedLinkError turn off ConPTY
When starting on older versions of Windows ensure that WinPTY continues
to be used by catching all the types of exceptions that may indicate
that ConPTY is not available. This change catches all Throwables as
we want to know about all RuntimeExceptions and Errors

Change-Id: I7524d9286efe9296f1bb44311c4a3be1e5195c14
2021-05-26 10:21:29 -04:00
Anton Backstrom
01cc2ac4d2 Bug 573696: add dummy listener to DebugPlugin
Change-Id: Ic8603d82dd9aaeaec845a9ca33ee715b63a901fd
Signed-off-by: Anton Backstrom <anton.backstrom@gaisler.com>
2021-05-25 16:44:48 +02:00
Jonah Graham
7e134ccf24 Bug 562776: Fix enablement variable for ConPTY
Change-Id: I46a6a64ddd1ca74a4466ea13ef8a942cd83c1853
2021-05-24 21:29:24 -04:00
Torbjörn SVENSSON
fcbf0b6963 Bug 573722: Allow sub-class to output custom lines in header
Contributed by STMicroelectronics

Change-Id: If7163f33c804dc40bc950da067d81396a26d8f74
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
2021-05-24 09:52:20 -04:00
Torbjörn Svensson
6187228a08 Bug 573688: Do no inherit flags from cached blocks
Memory region may change access rights during the execution time. For
example, in embedded, a memory location might be clocked or not clocked
depending om some SFR. As the region can be changed during the
execution time, it's not enough to use the initial flags.

Contributed by STMicroelectronics

Change-Id: Ida4d6ed69faf3fb6e515aa0a29fa90ea241135dc
Also-By: Anders Jansson <anders.jansson-ext@st.com>
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-05-24 09:02:39 -04:00
Torbjörn Svensson
b5969f2cb9 Fixed typo in documentation links
Contributed by STMicroelectronics

Change-Id: Ie5abafc4b1d1d7dbd968cd627ff5b3d4f863e15a
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2021-05-24 12:25:05 +02:00
Jonah Graham
261af5106c Bug 573719: Display error on shell open failed
Save shell before disposing control so error message has somewhere to go

Change-Id: I3bcaa0e8f23a8c177309e72b6d9dfbb8afb72cf4
2021-05-24 00:30:58 -04:00
Jonah Graham
f71d92114f Bug 573646: Open primary terminal view when there is no last available
Change-Id: I286d039d6cb3eb1e73fdb5b76c8743a8e0870d94
2021-05-24 00:30:58 -04:00
Jonah Graham
cb89216031 Bug 573712: Populate WSL entries in terminal list like git bash is
Change-Id: I371d5455296e9d1bcb9137e538d5cc2ed5417ba1
2021-05-24 00:30:58 -04:00
Jonah Graham
1557c2c4f5 Bug 573677: Mark methods that don't handle commands well as deprecated
Some of these commands work "by accident" on Windows, but there are lots
of special/corner cases that may not. On Linux they almost certainly
never do the correct thing when spaces are in arguments.

Change-Id: Idce714da9c1d6ac7a67dc174d5b30bf619534c53
2021-05-23 20:49:26 -04:00
Jonah Graham
a4963b35ad Bug 573712: Reduce work done at Eclipse startup time on main thread
In Bug 466650, the git bash detector was removed from startup to reduce
overhead on startup. Later during a rewrite it was added back in under
a different code path for Bug 473107. In the context of Bug 573712
which is going to add more detectors that may do much more work on
a full load, reduce the amount of work needed to do the presence check.

Change-Id: If1ae3f12ec51b1edc2d419f0efd89fed81a7b56e
2021-05-23 20:49:26 -04:00
Jonah Graham
a7fab87648 Bug 573712: Reorganize external tools detection code
The code was not very extensible and the main purpose of the bug
is to add additional detectors. This first commit refactors
the code to make that easier, and to provide a platform for
what could become an extension point.

Change-Id: I5ce514eda11f2573098d6e16663e324954da961b
2021-05-23 20:49:26 -04:00
Jonah Graham
ece07888a8 Bug 573713: Support alternate way of bright escape codes
ConPTY uses 90-107 to indicate bright instead of using extra 1; parameter.

Change-Id: I42263edd5dbe78fe164f00b99d1850ca5be85081
2021-05-23 20:49:26 -04:00
Jonah Graham
4e92239952 Bug 562776: Use Windows ConPTY API instead of WinPTY
There are lots of bugs in WinPTY, while upgrading WinPTY would
resolve some of them, there are others that are unresolvable. See
https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/
for a backgrounder on the general subject.

In this first version ConPTY won't be enabled by default, it requires
system property
org.eclipse.cdt.core.conpty_enabled=true
to be set. i.e. start Eclipse with:
-vmargs -Dorg.eclipse.cdt.core.conpty_enabled=true

In a future version the default will change to on if available,
so to force it off use:
org.eclipse.cdt.core.conpty_enabled=false

Change-Id: Ib2df0095027c23f20daa6aa044d9e5f0b0443164
2021-05-23 20:49:26 -04:00
Jonah Graham
2443cfbeff Bug 572880: Display an ellipsis if opcode is wider than column
Instead of silently having opcode bytes not display, show an ellipsis
in the last column of the opcodes if the length required for that line
is too long.

Change-Id: If1379846c2dd7111324933c2bd72244f6abade02
2021-05-23 00:25:59 -04:00
Jonah Graham
17cabff257 Add missing imports for Javadocs
These imports are only used for Javadocs, which is why it was sort
of ok that they were missing until now.

Change-Id: Ia941ca55c56a101766b709290b40609c20fdda9d
2021-05-19 23:26:40 -04:00
Jonah Graham
e44ef41078 Bug 573646: Restore to correct secondary tab
The handling of ssecondary ids was problematic, special cases were
not well documented and depending on code paths, a secondary ID
of null would mean different things.

This commit fixes that documentation, defines shared constants, and
fixes the logic so secondary id dispayed terminals restore to the
correct location on restart.

Change-Id: Ia87b64f735a37d505e1a5a7b7a4a8e210dfb8c1e
2021-05-19 23:26:07 -04:00
Jonah Graham
df78cd3055 Bug 460495: Save/restore terminal process/args and other settings
Change-Id: Id87d1ade4b58a4abf759c5016dcf4ab24b4b028b
2021-05-19 14:47:53 -04:00
Jonah Graham
a7e14187ea Bug 453696: Save CWD in terminal to restore it
Change-Id: I6a432fcbd40f6b4e991e49ba582b8b9f7cae823e
2021-05-19 12:54:10 -04:00
Jonah Graham
fe2dfb7dd2 Bug 573619: Preserve UI settings in Build Targets (Make) view
This includes saving:
- selection in tree
- expansion in tree
- scroll position

Change-Id: I835d8fabab4f56b01fb0858e92ae63f9e82c9c85
2021-05-19 10:03:25 -04:00
Jonah Graham
c8c65758d5 Bug 338776: Add working set support to Build Targets (Make) view
Change-Id: I3accec157248c474c87d22699c151e4a64ae6f5b
2021-05-19 10:03:25 -04:00
Jonah Graham
7743993a08 Bug 572880: Keep internal representation of opcode as a String
We receive a string from GDB and then display the same string to the
user. So instead of converting it internally into a Byte[] to then
convert it back into a String, keep it as a String.

This fixes a regression where some GDBs' output format was not as space
separated 8-bit-bytes, but as words or similar.

Change-Id: I4ea241ff9ea45165489604fee26a3593ec3f6756
2021-05-19 09:32:42 -04:00
Jonah Graham
02286a6a34 Bug 572878: Rewrite signing of dlls to preserve full file name
This is a fixup of the previous commits which has some basic
shell errors

Change-Id: I9572148d0fa9c6fdad5c6e256d6ccabaed9c8a9c
2021-05-19 08:53:56 -04:00
Jeff Johnston
2ec6d64b1b Bug 568957 - Missing significant macros on hdrs with pragma once syntax
- replace printStackTrace with CCorePlugin.log call

Change-Id: I2eb5398cfbd3ebfbfe3ab02acaf40a748699902a
2021-05-17 21:59:39 -04:00
Jonah Graham
8e3e8366c1 Bug 572878: Preserve file name when passing file to be signed
Do this by using a temp dir to store the unsigned files in rather
than mangling the name

Change-Id: I25d3b1fbb5751f8615266168a919990d9111204c
2021-05-17 21:26:40 -04:00
Jonah Graham
241c3a38fd Bug 572878: Preserve file extension when passing file to be signed
Change-Id: I28d15a6430ac3860ba65f6414498793e22dffee0
2021-05-17 21:01:58 -04:00
Jonah Graham
3f5438aad8 Bug 572878: Fail build if curl fails by having curl return error code
Change-Id: Iad5c276f0fbbda96a22d8fbf55d06485cf63f1d4
2021-05-17 20:42:47 -04:00
Jonah Graham
f07ba87a12 Bug 572582: Increase minimum fully supported version of GDB to 8.0
Eclipse CDT supports GDB version 6.6 and newer. Some features
in Eclipse CDT require newer versions of GDB. The Eclipse CDT
project focuses its testing time on GDB version 8.0 and newer.

Change-Id: Ifb7cd77c9fae4b9d1b82e0aa8a2cea206a4298b7
2021-05-15 21:15:15 -04:00
Stephan Oostveen
260c1b39f7 Bug 573560: Mark GCC constexpr message as info
A GCC information message starting with 'in constexpr expansion'
was incorrectly parsed as an error.

Change-Id: If6142f8486e97c088315060c826d59e61566692b
Signed-off-by: Stephan Oostveen <stephan.oostveen@nextlevel-electronics.com>
2021-05-15 19:43:18 -04:00
Jonah Graham
381f29b74e Bug 573417: Add https URL for p2 site on CDT installs
Up until now we have added http:// URLs

Change-Id: Ib7c41cd16fed176d66c9377b1bd31ddbac6128d2
2021-05-15 17:59:46 -04:00
Jonah Graham
76bb80f06d Bug 573512: Add verbose option for progress monitor
During operations, such as remove projects, the subtask of a progress
monitor has useful information for users. However during a normal build
there ends up being lots of output that is of little value.

Change-Id: Ie5bf95a743e8909242a0224883fd22e49ff55ed6
2021-05-15 17:57:13 -04:00
Marc Siebenhaar
8b385ffc1f Bug 573512: Added parameter for removing projects from workspace.
This is command line option to -remove and -removeAll projects from
the workspace.

Change-Id: Ice4e7db3485d2a0c698f48dc2aa0662170289f36
2021-05-15 17:57:13 -04:00
Jonah Graham
78b9b1e16c Bug 573498: Fix bg color when hovering over annotations in dark mode
SWT.COLOR_GRAY is gray in dark or light mode, but COLOR_TEXT_DISABLED_BACKGROUND
changes with the theme so always leaves the text legible.

Change-Id: I3d0c2d1a19baa618ef08c5c40e35fbdda11691e2
2021-05-15 16:21:33 -04:00
Jonah Graham
2c63592dd6 Bug 573546: Clear old selection in hover on annotation ruler
The select can be called twice when the expansion first opens,
so clear out the old selection before processing the new one.

If this isn't done, the oldStyles gets set to the highlighted
version on the second call, which prevents deselect from
removing the highlight.

Change-Id: Ibc8ae45d4164d380b7946cd492c29f33c9fac981
2021-05-15 16:21:13 -04:00