We weren't dealting with relative include paths returned from
the call to gcc -E properly. Resolves them against the build
directory before checking if their a directory. Results in them
added.
Tested with ESP-IDF's feature/cmake branch.
Change-Id: I1e2583e03cce6380ee4382146b177978c9c81806
(cherry picked from commit 3b44424539)
Fixed with the patch for 533552, only the CodeFormatter needed fixing.
Change-Id: I258617d01b091764ad9776921e773e208002c989
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Fix and test.
Also fixes formatting errors with DefaultStatements.
Change-Id: Idac4a7105d7ae86db40755bd27cef60e197de664
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Fix and tests.
Also fixes bug 535265, since the Codan Quickfix tests fail otherwise.
Change-Id: Id31e40907b7ebdeee4a67c014c3a1b1cd37579ad
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Ensure that the remote connection has been opened before showing
RemoteResourceBrowser dialog so that the dialog's layout would not
depend on the state of the connection.
Change-Id: Iec70c243b75723de418e55a1f07cd8e9804400b6
Signed-off-by: Chin Huat Ang <chin.huat.ang@intel.com>
All sorts of views, variables, memory, etc can do a DSF operation
that causes an error. But for some reason only the disassembly
view generally displays this error to the user in a pop-up.
This change converts the pop-up (which says things like "Target not
available" or "Failed to execute MI command:
-var-create - * symbol_that_user_typed_that_doesnt_exist
Error message from debugger back end:
-var-create: unable to create variable object") to just log the
error instead.
Errors are dealt with in the UI already (example, bad location in
text box in toolbar gets an exclamation next to it). However, I don't
know if there are some errors that really do need to be displayed
to the user with a pop-up.
Change-Id: I27b398c34e558db98d34cef773a2689fa9222149
AttributeWriter.writeGCCAttributeSpecifier()
* Added test to reproduce initial issue.
Change-Id: I72e60fb2244b7d40492bfcdeaa58a8707c39e277
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Includes reverting 851295e821:
[releng] work around Tycho issues of obtaining *.jre.javase [10.0.0]
Change-Id: I1d49b519ba111e48545ef37c991859dfa68960cd
The original implementation used plain-text string manipulation of the
IDocument. This changeset changes the implementation to make use of the
ASTRewrite infrastructure, which automatically honors the const
placement setting.
Change-Id: Ib5ae9381b93ca8ab4d1ad3e16b1c3c8b1ec62d78
Signed-off-by: Felix Morgner <fmorgner@hsr.ch>
Fix and test
Change-Id: I14088e69aed829940fb1e9f5197dedf18d9bb7a5
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
- Launch bar is usually expecting a LaunchConfigurationTargeted
Delegate which calculates the binary but Container build
uses the ContainerLaunchConfigurationDelegate which expects
the program name, working dir, connection, and image id
set up as ILaunchConfiguration attributes
- modify ContainerLaunchConfigurationDelegate to add
finalLaunchCheck method which can verify if the launch
config attributes are set up and if not, set them from
the build config (since this is post-build)
- fix getImageName() in CoreBuildContainerLaunchConfigProvider
to use toolchain attributes
Change-Id: Iad6cc26928c33e964650b99844e065df8653858f
Fix and test
Change-Id: I785ecfd0715f1fa8ff86b87bd01d16ac6d5d5da2
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Guard against NULL oldValues, which is legitimate, in which case use an
empty Map.
Change-Id: I78ac252d3e91d431340320719cb57b32145813f0
Signed-off-by: John Moule <evil_bandit_betamax@yahoo.co.uk>
The output of the call to gcc to pick out the defines and include paths
produces them on different streams, defines on stdout and paths on
stderr. Separate the scanning of the two into two threads.
Change-Id: I3173d3619e53d13a51a6e283eb320a618daacf21
When a line is double-clicked, or the highlight error is otherwise
changed, the redrawing of the highlighting was done by redrawing
the entire build console document. This was slow on very large
documents. Instead only redraw the line losing the highlight (if
any) and the line gaining the highlight.
In addition, as we only change the foreground colour to highlight,
avoid redrawing the background.
Change-Id: I5e652449715a588cb8702e0100a472d1f566e2a8
The BuildConsolePartitioner used to compute partitions from offsets
by iterating over the list of partitions. This strategy is fine
for small build outputs. But outputs in the 100,000+ line range
can have huge number of partitions. This commit updates the logic
to take advantage of the fact that the partitions are sorted
and contiguous to do binary searches to find the partition, and
uses a new method (computePartitioningAsList) to use a view onto
the original partitions list instead of significant copying.
Change-Id: I4395df36431a6ae45e6b77d6f76fd29532347ac5
This patch adds parsing and semantic support for lambda init-captures.
Change-Id: Ia5f39ea6f8780ecd6a9685f432bcbdf39e09c82a
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Change in super-hierarchy caused API breakage. As these interfaces
have long since been deprecated, rather than adding default methods
for them, simply mark them as noimplement/noextend. The implementation
in CDT already has the new effective method - getAttributeSpecifiers() -
implemented.
Change-Id: I252fdeb33c0edcbe73338dc6fca477201bd4d468
Added a loop in read(byte[], int, int) to block until any input is
available. Or until the port is closed, or an exception occurs.
Change-Id: I1ead6f465571274e77e74de685b8185c8cdde108
Signed-off-by: Waqas Ilyas <waqas.ilyas@gmail.com>
Within CDT new constants in interfaces do not require major version
increment, just a commented API filter. However in this case as the
interface is a grabbag for constants, it is even more appropriate
to mark it noextend/noimplement
Change-Id: I1ac6da12093bdd3e92cfa51c097383c9964f41a2
This does not happen in Eclipse using the target platform directly,
and when this last happened for [9.0.0] this workaround
worked, as documented in https://bugs.eclipse.org/bugs/show_bug.cgi?id=530207#c1
Change-Id: I55ce926c0ad73e78d24d1c0e78a6db7cce4d101e
With this patch we allow any keyword to be used as a UDL operator, which
for example GCC compiles fine with. They are then no longer highlighted
as keywords but colored the same as normal text. This can be overridden
by coloring overloading operators differently.
Change-Id: If80faf0f3dc599ab4f12fe98977c556aaaefe6aa
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
The name of the JTAG probe is not translateable since the name is saved
as-is in the launch configuration. To make the string translateable, use
the id instead to select probe implementation.
Change-Id: Id7e654ea1e26f47cd1c8ccfec857a94f3be9e0ad
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Signed-off-by: John Dallaway <john@dallaway.org.uk>
- add check for network ports coming back empty for a Container
launch and if so, fall-back to use the ip address of the Container
for the remote host
Change-Id: I83d68a10e2dc92f7d0f27bb9dec304388594b4a3
Changed GCC build parser to handle simple defines like "-D FOO"
and defines them to 1.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=534454
Change-Id: Ic9065914bc82dafc43d0814f4fed27a26eeeeb28
Signed-off-by: Eric Woestman <woestman@ensoftcorp.com>
