Commit graph

25987 commits

Author SHA1 Message Date
Jonah Graham
aa1040a21a Bug 540373: Remove '(non-Javadoc)' comments
These were inserted in the past automatically by Eclipse but
newer tooling makes them redundant.

These were removed by doing a global find/replace on *.java files
using the following regular expression:
\t/\*\n\t \* \(non-Javadoc\)[^/]*/\n

Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
2018-11-22 22:00:29 +00:00
Jonah Graham
eeb3006e27 Bug 540373: Cleanup: Remove redundant semicolons
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant semicolons
and completing the wizard

Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
2018-11-22 21:57:01 +00:00
Jonah Graham
caf2292768 Bug 540373: Cleanup: Remove redundant type arguments
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant type arguments
and completing the wizard

Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22 21:55:36 +00:00
Jonah Graham
8844a8f9f2 Bug 540373: Cleanup: Remove unnecessary casts
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove unnecessary casts
and completing the wizard

Change-Id: I287d4066b12fc19d7f73a016e11c9405abb4ceb9
2018-11-22 21:53:35 +00:00
Jonah Graham
8985c7b63f Bug 540373: Cleanup: Add missing annotations
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Add missing Annotations - and selecting all three types:
 - @Override
 - @Override on interface methods
 - @Deprecated
and completing the wizard

Change-Id: I5d367dacb04327107f25e147edc08efc4eb1c2fe
2018-11-22 21:51:31 +00:00
Jonah Graham
a923614c73 Bug 540373: Cleanup: Organize Imports
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Organize Imports
and completing the wizard

Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22 21:47:02 +00:00
Jonah Graham
170e654b47 Bug 540373: Cleanup: Format & Remove trailing whitespace
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Format source code
- Remove trailing white spaces on all lines
and completing the wizard

Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22 21:47:02 +00:00
Jonah Graham
35996a5c5c Bug 540373: Standard .settings auto applied
The releng/scripts/apply_jdt_prefs_to_all_projects.sh was run to
copy standard settings to all other projects.

Change-Id: I4436c947d7f0142f56b709e661379c3eb54f666b
2018-11-22 21:47:02 +00:00
Jonah Graham
4f9a44aa3d Bug 540373: Standard .settings for JDT/PDE
This commit contains the formatter settings and compiler settings,
using org.eclipse.cdt.core as the master for .settings and
a script to copy them to all the other projects with
apply_jdt_prefs_to_all_projects.sh

Change-Id: Ifd1a45879bed716273cae0ea05b55f629210c36e
2018-11-22 21:47:02 +00:00
Jonah Graham
37f0f660c8 Bug 540373: Fix tests that rely on format of Java code
TestSourceReader.getContentsForTest() does not examine lines containing
@ to see if they have the test method. This means that changing
the formatting of this test could break it as the reader would see
the // comments as test data. Things which are comments and not
test data should have /**/ comments as this commit now does.

Change-Id: Ic30a63df3910c6a5643b4ac734c05526e3420095
2018-11-22 20:34:33 +00:00
Jonah Graham
086e6e30b7 Bug 540373: Fix tests that rely on whitespace at end of line
Change-Id: I2aa5d28e5fbd9ba1f12f6ec275ea1474730efe46
2018-11-22 20:34:33 +00:00
Jonah Graham
871c91ee5e Bug 540373: Fix declaration to interface
This file was always intended to be an interface. The discussion
on fixing this happened as part of the review to
change I240bbe08666b89861fe132c6384174be7883c022

Change-Id: I7ddd211f927f7089ed40abdf578ae10c0c437329
2018-11-22 20:34:29 +00:00
Jonah Graham
c5c5412f8d Bug 540373: Remove invalid javadoc API tags
Change-Id: I240bbe08666b89861fe132c6384174be7883c022
2018-11-22 20:33:28 +00:00
Jonah Graham
f70a8b35c1 Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.sh
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-22 20:31:51 +00:00
Jonah Graham
f0ce92d3b5 Bug 540371: normalize files before applying EPLv2
Change-Id: I8bfd427bba1df18579d6d5e58ad1e5d704485050
2018-11-22 20:30:13 +00:00
Jonah Graham
cd61252736 Bug 540371: Script for updating to EPLv2
Script based on work done by Lars Vogel on Eclipse Platform.

See https://git.eclipse.org/r/#/c/127598/

Change-Id: Ic8d04a20c955179645fdeeb11cb3861d7b31fa3f
2018-11-20 21:22:12 +00:00
Jonah Graham
48d2271a58 Bug 540373: Normalize newlines with .gitattributes
There is also a new script to verify completeness of .gitattributes:
releng/scripts/verify_gitattributes.sh

Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-11-20 21:20:39 +00:00
Jonah Graham
3cf0297769 Bug 532077: Preserve Ignore Count set in the platform breakpoint
Change-Id: I19ad64254b0e9ed55114f2e83fe2f09e2aeac83c
2018-11-18 12:36:44 +00:00
Jonah Graham
090fc94fa0 Bug 536448: Require target platform bundles as minimum version
Without setting dependent plug-ins to minimum version to match the
target platform we are aiming for we can imply (and therefore let install)
CDT into older versions of Eclipse where CDT does not actually work.

This can be exposed in very odd ways, such as IllegalAccessError, when
platform has allowed API changes.

However, rather than update every single bundle in CDT, only the
o.e.cdt.core/ui bundles are being updated as this should achieve the
desired result without every other bundle needing to be touched.

Change-Id: Idf166bc4f4a39ad5096386e24cbff234c0238900
2018-11-17 20:41:49 +00:00
Jonah Graham
a7425a05b4 Bug 541270: Fix Restore Defaults for Console Prefs
Bug 414525 was trying to workaround Bug 270326/320723 but did not
handle the case that no plugin_customization.ini was provided.
This fix make Restore Defaults for Preferences ->  C/C++ ->
Build -> Console work again.

Change-Id: Idbacc2a0baece6c3f594cfac4a2eeece886bac80
2018-11-17 19:55:31 +00:00
Jonah Graham
39b6373f66 Bug 407405: Limit wrapping in Build Console
If the build console is too long word wrapping is very slow. The
underlying issue is Bug 168557, this is just a workaround so users
don't fall down this particular rabbit hole.

Change-Id: I1be3540003d475e2d5431295219198ae2db7862f
2018-11-17 19:55:27 +00:00
Nathan Ridge
e082f73b56 Bug 540957 - Implement equivalence checking for expressions
This is used for declaration matching in function templates.

Change-Id: I80044304b2d9dfda085a13f0cfc040f1200a2e1c
2018-11-17 03:02:51 -05:00
Jonah Graham
54f6c19de2 Bug 541069: Don't error on missing variables when doing substitution
This is a follow up to 60d95da97b (Bug
399460) as in that change the reporting option inadvertently changed.

Change-Id: I1afe70632107ab388be09a707e8e9fc419f76b91
2018-11-16 11:24:38 +00:00
Nathan Ridge
b6c1a085d1 Bug 540909 - underlying_type of typedef to enum
Change-Id: Ic4f48c4da79419d5404e132da2944ee2823ca41f
2018-11-15 21:47:11 -05:00
Marc-Andre Laperle
ef2b34f148 [releng] Fix missing dependency in stand-alone debugger
Change-Id: I347d47ea4689aa154ddb090b9cc05e7dc132959e
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-14 18:57:24 -05:00
Jonah Graham
41c369ee01 [releng] Update to newer tools.template for javax.xml.bind issues in Java11
Change-Id: I224e0248eb49feeea79b05ef394f94b943b2a6a6
2018-11-14 07:13:44 +00:00
Marc-Andre Laperle
7999eab841 Bug 516046 - NPE in AbstractDebugTextHover when hovering over undefined macro
Change-Id: If732a826801f025e929f711fa35a793545d0ed73
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-13 21:20:13 -05:00
Nathan Ridge
a561d301ca Bug 512297 - Improve propagation of semantic problem IDs
Change-Id: I3c95a244e88abe37f550370ff6c7c9aec2c102da
2018-11-13 17:46:50 -05:00
Doug Schaefer
afe7d18793 Bug 540978 Rename lsp plugins to be org.eclipse.cdt.lsp.*
To make it clear these are CDT's future :).

Change-Id: I64935e3998a46632f4f4006589a17eb01959eb27
2018-11-10 14:09:43 -05:00
Marc-Andre Laperle
f9250cb361 Add com.sun.xml.bind to target
This is a convenience for working in combination with the source
of o.e.tools.template which is not unusual.
Also add a few more missing things to Oomph setup for Java 11.

Change-Id: Ifc6105e251a7b8d855cf76401cdb3740c55f79c9
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-09 15:09:34 -05:00
Jeff Johnston
331be6c45c Bug 540423 - C/C++ Container Launcher missing Port Binding
- add new ContainerPortDialog class to allow user to specify
  ports in the launch configuration Container tab
- add new ContainerTabModel and ExposedPortModel classes to
  support new functionality
- add new Ports group to ContainerTab and have a table
  where a user can add, edit, remove, and select ports
  for publishing to the host
- add new attribute ATTR_EXPOSED_PORTS to ILaunchConstants for
  saving and restoring user selected ports in C launch
  configuration
- add needed internal messages to support new port settings
  functionality
- bump up org.eclipse.cdt.docker.launcher version

Change-Id: I93b7503bdc141e3077418800352507ef38e65ab1
2018-11-08 17:57:23 -05:00
Hannes Vogt
f9c8f0da02 Bug 540676 - Improve parsing of alias templates
- If the argument for a template template paramter is unknown
(ICPPUnknownType), don't create a problem.
- Ensure that a possible argument-parameter mismatch is caught at
template instantiation time.

Change-Id: Ief61ef93f9d0c19d043aedb89f1c5e66c0374ef2
Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-11-06 10:31:06 -05:00
Jonah Graham
c3d4f06575 [releng] Update to newest maven-pmd-plugin
Change-Id: I357bdc57b8f1743928899fb91ac4a316008b58bf
2018-11-05 09:24:26 +00:00
Jeff Johnston
eea4bbabd6 Bug 540699 - NoClassDefFoundError in AutotoolsNewMakeGenerator
- use of CommandLaunchManager requires higher version of cdt.core
  than Autotools specified so up to 6.5.0

Change-Id: I315e69defeee9d7d1e6c016edff2d96013fe13e9
2018-11-02 10:46:29 -04:00
Hannes Vogt
481db37a59 Bug 540450 - Fix @since version
Change-Id: I5c31d97dbbd277a87147cb05d0245ce0953189bb
Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-11-02 02:13:52 -04:00
Marc-Andre Laperle
a8a9138258 Remove NewMakeProjectPreferencePage (unused)
It is not used anywhere and it's internal.

Change-Id: I4e157ec7fd1184118aea8f6bef35a850dfeb0945
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-01 23:09:46 -04:00
Marc-Andre Laperle
c278f4575f [lldb] Remove work-around for missing '-gdb-set breakpoint pending'
For more recent versions fo LLDB (8.0.0-r345563) this work-around is not required.
This is a follow-up to bug 539641.
See also https://reviews.llvm.org/D52953

Change-Id: If5f951a33fab8781a594175571d0ad5131e9ef15
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-01 22:38:11 -04:00
Hannes Vogt
b33ebe2ee6 Bug 540450 - Parsing dependent template name
Parse dependent template names as type.

Change-Id: I35461b2e4a615f34749e6ff17b2a85406ec2cf12
Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-10-31 01:21:26 -04:00
Karsten Thoms
652602febd Bug 540610 - Add Automatic-Module-Name header
Change-Id: Ia990b24469751050dd9ec8f9b5550804816308b3
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-10-30 15:49:15 +01:00
Jeff Johnston
26bdf7e82f Bug 540523 - NullPointerException in MesonPropertyPage.performOk method
- add check that buildConfig field has been set before performing any
  activities on it

Change-Id: If3ab7a0b20b54a9c16b26902c06b615e4c514ffa
(cherry picked from commit 9031090393)
2018-10-29 17:36:03 -05:00
Marc-Andre Laperle
08721bdf8e Bug 540257 - "Align Const" save action causes NPE when saving Assembler files
Change-Id: Ie3a086ddc7bc79eaef259a570327408e098bef51
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-10-29 01:11:07 -04:00
Hannes Vogt
8404a76e6e Bug 540538 - Pack size for CPPTemplateParameter
Change-Id: Ie67f27711ca658e9b4b3526c5c3c28541dcd3a15
Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-10-29 00:06:15 -04:00
Nathan Ridge
1cbe7e32b9 Bug 540159 - ClassCastException in ExecDeclarator.unmarshal()
Change-Id: Ia51244b558798c052f1ec7a6918c6f85a6509655
2018-10-28 22:53:09 -04:00
Nathan Ridge
a00346af22 Bug 540112 - Perform C++14 return type deduction in ReturnChecker
As part of this change, ReturnChecker was refactored to compute the
return type as an IType, which allowed for removal of some logic in
ReturnChecker which duplicated CPPVisitor's type resolution work.

Change-Id: I9cd8512164d650a5ee11d2e58fdae477e3c428a2
2018-10-28 22:52:37 -04:00
William Riley
4689fdee68 Bug 540367 - Enable Reproducible Version Qualifiers
Change-Id: I1ccd2330951a83a7632c67a6274b7527cd9f237c
2018-10-24 04:44:00 -04:00
Jeff Johnston
cc20f1a9bb Bug 540410 - ContainerTargetTypeProvider causes ClassNotFoundException
- bump up minimum org.eclipse.cdt.core needed for
  org.eclipse.cdt.docker.launcher plug-in so that
  ICBuildConfigurationManager2 interface is available

Change-Id: I5e77e7b43bdea1f0b59c79fcdfced7c162b64e9a
2018-10-23 17:21:56 -04:00
William Riley
f3ca365140 Bug 540367 - Increment version numbers
Change-Id: I4a355170a7075f0a98ba3c1a5131c235c89b07d2
2018-10-23 11:20:31 -04:00
Hannes Vogt
e61ba5a731 Bug 529656 - Error if docker build failed
If the build command in a container build terminates with non zero exit
code (e.g. make command not found) an error is displayed.

Change-Id: Ib6349aa6c22c1a3bb9c0d2920110bc69773f8da1
Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-10-22 11:10:26 -04:00
Evgueni Driouk
1fa5f7d6e5 Bug 540369 - HeadlessBuilder: change private to protected
Change-Id: Ib8ca36aa50ce6060d4f8fb14f5b74c3662bc8862
Signed-off-by: Evgueni Driouk <Evgueni.Driouk@arm.com>
2018-10-22 09:51:01 -04:00
Christian Walther
ebc9420473 Bug 534423 - Sort configurations in the Exclude from build dialog
Sort the configuration list in the same order as used by the project
property pages (case-insensitive nonlocalized), almost the same order as
used in the Project > Build Configurations > Set Active menu
(case-sensitive nonlocalized), not in the internal order coming from the
.cproject file.

Change-Id: Ia05bd163043f762dd96da4c69d409ecee9accb8c
Signed-off-by: Christian Walther <walther@indel.ch>
2018-10-22 06:16:24 -04:00