Jeff King e4da43b1f0 prefix_filename: return newly allocated string ... The prefix_filename() function returns a pointer to static storage, which makes it easy to use dangerously. We already fixed one buggy caller in hash-object recently, and the calls in apply.c are suspicious (I didn't dig in enough to confirm that there is a bug, but we call the function once in apply_all_patches() and then again indirectly from parse_chunk()). Let's make it harder to get wrong by allocating the return value. For simplicity, we'll do this even when the prefix is empty (and we could just return the original file pointer). That will cause us to allocate sometimes when we wouldn't otherwise need to, but this function isn't called in performance critical code-paths (and it already _might_ allocate on any given call, so a caller that cares about performance is questionable anyway). The downside is that the callers need to remember to free() the result to avoid leaking. Most of them already used xstrdup() on the result, so we know they are OK. The remainder have been converted to use free() as appropriate. I considered retaining a prefix_filename_unsafe() for cases where we know the static lifetime is OK (and handling the cleanup is awkward). This is only a handful of cases, though, and it's not worth the mental energy in worrying about whether the "unsafe" variant is OK to use in any situation. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2017-03-21 11:18:41 -07:00
..
add.c	hold_locked_index(): align error handling with hold_lockfile_for_update()	2016-12-07 11:31:59 -08:00
am.c	delete_ref: accept a reflog message argument	2017-02-20 22:04:47 -08:00
annotate.c
apply.c	Convert read_mmblob to take struct object_id.	2016-09-07 12:59:42 -07:00
archive.c	archive: read local configuration	2016-11-22 13:55:20 -08:00
bisect--helper.c
blame.c	Merge branch 'rs/blame-code-cleanup'	2017-03-17 13:50:24 -07:00
branch.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
bundle.c
cat-file.c	Convert object iteration callbacks to struct object_id	2017-02-22 10:12:15 -08:00
check-attr.c	attr: tighten const correctness with git_attr and match_attr	2017-02-01 13:46:53 -08:00
check-ignore.c
check-mailmap.c
check-ref-format.c
checkout-index.c	hold_locked_index(): align error handling with hold_lockfile_for_update()	2016-12-07 11:31:59 -08:00
checkout.c	Merge branch 'jk/interpret-branch-name'	2017-03-14 15:23:18 -07:00
clean.c	Merge branch 'nd/clean-preserve-errno-in-warning'	2017-02-27 13:57:16 -08:00
clone.c	builtin/clone: convert to struct object_id	2017-02-22 10:12:15 -08:00
column.c
commit-tree.c	builtin/commit-tree: convert to struct object_id	2016-09-07 12:59:43 -07:00
commit.c	builtin/commit: convert to struct object_id	2017-02-20 01:11:26 -08:00
config.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
count-objects.c	Convert object iteration callbacks to struct object_id	2017-02-22 10:12:15 -08:00
credential.c
describe.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
diff-files.c	diff: run arguments through precompose_argv	2016-05-13 14:35:49 -07:00
diff-index.c	diff: run arguments through precompose_argv	2016-05-13 14:35:49 -07:00
diff-tree.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
diff.c	use SWAP macro	2017-01-30 14:17:00 -08:00
difftool.c	difftool: handle modified symlinks in dir-diff mode	2017-03-15 12:08:10 -07:00
fast-export.c	builtin/fast-export: convert to struct object_id	2017-02-22 10:12:15 -08:00
fetch-pack.c	fetch-pack: move code to report unmatched refs to a function	2017-03-02 11:12:53 -08:00
fetch.c	Merge branch 'js/remote-rename-with-half-configured-remote'	2017-01-31 13:14:59 -08:00
fmt-merge-msg.c	builtin/fmt-merge-message: convert to struct object_id	2017-02-22 10:12:15 -08:00
for-each-ref.c	tag, branch, for-each-ref: add --ignore-case for sorting and filtering	2016-12-05 14:59:29 -08:00
fsck.c	Convert object iteration callbacks to struct object_id	2017-02-22 10:12:15 -08:00
gc.c	Merge branch 'cc/split-index-config'	2017-03-17 13:50:23 -07:00
get-tar-commit-id.c
grep.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
hash-object.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
help.c	Merge branch 'js/no-html-bypass-on-windows' into maint	2016-09-08 21:35:55 -07:00
index-pack.c	index-pack: skip collision check when not in repository	2016-12-16 13:57:19 -08:00
init-db.c	real_pathdup(): fix callsites that wanted it to die on error	2017-03-08 14:38:41 -08:00
interpret-trailers.c	Merge branch 'jk/parseopt-string-list' into jk/string-list-static-init	2016-06-13 10:37:48 -07:00
log.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
ls-files.c	ls-files: move only kept cache entries in prune_cache()	2017-02-13 12:06:10 -08:00
ls-remote.c
ls-tree.c	ls-tree: convert show_recursive to use the pathspec struct interface	2017-01-08 18:04:17 -08:00
mailinfo.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
mailsplit.c	mailsplit: support unescaping mboxrd messages	2016-06-06 11:14:43 -07:00
merge-base.c	builtin/merge-base: convert to struct object_id	2017-02-22 10:12:16 -08:00
merge-file.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
merge-index.c	use oid_to_hex_r() for converting struct object_id hashes to hex strings	2017-01-30 14:23:40 -08:00
merge-ours.c
merge-recursive.c	i18n: merge-recursive: mark verbose message for translation	2016-09-15 13:17:32 -07:00
merge-tree.c
merge.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
mktag.c
mktree.c	use QSORT	2016-09-29 15:42:18 -07:00
mv.c	Merge branch 'bw/pathspec-cleanup'	2017-01-18 15:12:15 -08:00
name-rev.c	name-rev: add support to exclude refs by pattern match	2017-01-23 18:33:17 -08:00
notes.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
pack-objects.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
pack-redundant.c
pack-refs.c
patch-id.c	Merge branch 'rs/patch-id-use-skip-prefix'	2016-06-03 14:38:03 -07:00
prune-packed.c	Convert object iteration callbacks to struct object_id	2017-02-22 10:12:15 -08:00
prune.c	Convert object iteration callbacks to struct object_id	2017-02-22 10:12:15 -08:00
pull.c	Merge branch 'jc/pull-rebase-ff' into maint	2017-01-17 15:11:05 -08:00
push.c	Merge branch 'bw/push-submodule-only'	2017-01-31 13:14:56 -08:00
read-tree.c	read-tree: use OPT_BOOL instead of OPT_SET_INT	2017-01-11 13:17:16 -08:00
rebase--helper.c	rebase--helper: add a builtin helper for interactive rebases	2017-02-09 14:55:26 -08:00
receive-pack.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
reflog.c	refs: convert each_reflog_ent_fn to struct object_id	2017-02-22 10:12:15 -08:00
remote-ext.c	pkt-line: rename packet_write() to packet_write_fmt()	2016-10-17 11:36:50 -07:00
remote-fd.c
remote.c	Merge branch 'rl/remote-allow-missing-branch-name-merge'	2017-02-27 13:57:18 -08:00
repack.c	repack: die on incremental + write-bitmap-index	2016-12-29 13:45:37 -08:00
replace.c	Merge branch 'bc/object-id'	2017-03-17 13:50:25 -07:00
rerere.c
reset.c	delete_ref: accept a reflog message argument	2017-02-20 22:04:47 -08:00
rev-list.c	use oid_to_hex_r() for converting struct object_id hashes to hex strings	2017-01-30 14:23:40 -08:00
rev-parse.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
revert.c	Merge branch 'jk/cherry-pick-0-mainline'	2017-03-17 13:50:28 -07:00
rm.c	rm: reuse strbuf for all remove_dir_recursively() calls, again	2017-02-13 14:33:32 -08:00
send-pack.c	Merge branch 'sk/send-pack-all-fix' into maint	2016-04-29 14:15:57 -07:00
shortlog.c	Merge branch 'rs/log-email-subject'	2017-03-10 13:24:24 -08:00
show-branch.c	Merge branch 'jk/show-branch-lift-name-len-limit'	2017-02-27 13:57:16 -08:00
show-ref.c	show-ref: remove a stale comment	2017-01-23 18:51:56 -08:00
stripspace.c	stripspace: respect repository config	2016-11-21 11:00:38 -08:00
submodule--helper.c	submodule init: warn about falling back to a local path	2017-02-28 13:46:22 -08:00
symbolic-ref.c	delete_ref: accept a reflog message argument	2017-02-20 22:04:47 -08:00
tag.c	Merge branch 'km/delete-ref-reflog-message'	2017-02-27 13:57:18 -08:00
unpack-file.c
unpack-objects.c	unpack-objects: add --max-input-size=<size> option	2016-08-24 12:31:05 -07:00
update-index.c	update-index: warn in case of split-index incoherency	2017-03-01 13:24:21 -08:00
update-ref.c	update-ref: pass reflog message to delete_ref()	2017-02-20 22:04:47 -08:00
update-server-info.c
upload-archive.c	archive: read local configuration	2016-11-22 13:55:20 -08:00
var.c
verify-commit.c
verify-pack.c
verify-tag.c	builtin/verify-tag: add --format to verify-tag	2017-01-17 16:10:22 -08:00
worktree.c	prefix_filename: return newly allocated string	2017-03-21 11:18:41 -07:00
write-tree.c